* [Buildroot] [PATCH 1/1] package/shairport-sync: fix init script
@ 2014-11-12 23:06 Jörg Krause
2014-11-18 22:50 ` Yann E. MORIN
2014-11-19 21:50 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Jörg Krause @ 2014-11-12 23:06 UTC (permalink / raw)
To: buildroot
shairport-sync uses libdaemon for running as daemon and creating the pidfile
which conflicts with start-stop-daemons `-b -m` options. For that reason
shairport-sync does not start using /etc/init.d/S99shairport-sync start.
The issue is fixed by removing the background and pidfile task from
start-stop-daemon and add a daemon option `-d` to shairport-sync.
Signed-off-by: J?rg Krause <jkrause@posteo.de>
---
package/shairport-sync/S99shairport-sync | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/shairport-sync/S99shairport-sync b/package/shairport-sync/S99shairport-sync
index 31359fc..54d20ff 100644
--- a/package/shairport-sync/S99shairport-sync
+++ b/package/shairport-sync/S99shairport-sync
@@ -1,12 +1,12 @@
#! /bin/sh
# Additional options that are passed to Shairport Sync
-OPTIONS=""
+OPTIONS="-d"
case "$1" in
start)
echo -n "Starting shairport-sync: "
- start-stop-daemon -S -q -m -b -p /var/run/shairport-sync.pid --exec /usr/bin/shairport-sync -- $OPTIONS
+ start-stop-daemon -S -q -p /var/run/shairport-sync.pid --exec /usr/bin/shairport-sync -- $OPTIONS
[ $? = 0 ] && echo "OK" || echo "FAIL"
;;
stop)
--
2.1.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/shairport-sync: fix init script
2014-11-12 23:06 [Buildroot] [PATCH 1/1] package/shairport-sync: fix init script Jörg Krause
@ 2014-11-18 22:50 ` Yann E. MORIN
2014-11-19 21:50 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2014-11-18 22:50 UTC (permalink / raw)
To: buildroot
J?rg, All,
On 2014-11-13 00:06 +0100, J?rg Krause spake thusly:
> shairport-sync uses libdaemon for running as daemon and creating the pidfile
> which conflicts with start-stop-daemons `-b -m` options. For that reason
> shairport-sync does not start using /etc/init.d/S99shairport-sync start.
>
> The issue is fixed by removing the background and pidfile task from
> start-stop-daemon and add a daemon option `-d` to shairport-sync.
>
> Signed-off-by: J?rg Krause <jkrause@posteo.de>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/shairport-sync/S99shairport-sync | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/shairport-sync/S99shairport-sync b/package/shairport-sync/S99shairport-sync
> index 31359fc..54d20ff 100644
> --- a/package/shairport-sync/S99shairport-sync
> +++ b/package/shairport-sync/S99shairport-sync
> @@ -1,12 +1,12 @@
> #! /bin/sh
>
> # Additional options that are passed to Shairport Sync
> -OPTIONS=""
> +OPTIONS="-d"
>
> case "$1" in
> start)
> echo -n "Starting shairport-sync: "
> - start-stop-daemon -S -q -m -b -p /var/run/shairport-sync.pid --exec /usr/bin/shairport-sync -- $OPTIONS
> + start-stop-daemon -S -q -p /var/run/shairport-sync.pid --exec /usr/bin/shairport-sync -- $OPTIONS
> [ $? = 0 ] && echo "OK" || echo "FAIL"
> ;;
> stop)
> --
> 2.1.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/shairport-sync: fix init script
2014-11-12 23:06 [Buildroot] [PATCH 1/1] package/shairport-sync: fix init script Jörg Krause
2014-11-18 22:50 ` Yann E. MORIN
@ 2014-11-19 21:50 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-11-19 21:50 UTC (permalink / raw)
To: buildroot
Dear J?rg Krause,
On Thu, 13 Nov 2014 00:06:26 +0100, J?rg Krause wrote:
> shairport-sync uses libdaemon for running as daemon and creating the pidfile
> which conflicts with start-stop-daemons `-b -m` options. For that reason
> shairport-sync does not start using /etc/init.d/S99shairport-sync start.
>
> The issue is fixed by removing the background and pidfile task from
> start-stop-daemon and add a daemon option `-d` to shairport-sync.
>
> Signed-off-by: J?rg Krause <jkrause@posteo.de>
> ---
> package/shairport-sync/S99shairport-sync | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-19 21:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-12 23:06 [Buildroot] [PATCH 1/1] package/shairport-sync: fix init script Jörg Krause
2014-11-18 22:50 ` Yann E. MORIN
2014-11-19 21:50 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.