From: Vignesh Raghavendra <vigneshr@ti.com>
To: <Tudor.Ambarus@microchip.com>, <sergei.shtylyov@cogentembedded.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] mtd: spi-nor: Fix description of the sr_ready() return value
Date: Tue, 28 Apr 2020 17:51:53 +0530 [thread overview]
Message-ID: <14162c9a-2189-024f-7af2-e072ea1511da@ti.com> (raw)
In-Reply-To: <20200421063129.244466-2-tudor.ambarus@microchip.com>
On 21/04/20 12:01 pm, Tudor.Ambarus@microchip.com wrote:
> From: Tudor Ambarus <tudor.ambarus@microchip.com>
>
> The functions return 1 if ready, 0 if not ready, -errno on errors.
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
> drivers/mtd/spi-nor/core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 9dcc53bda8b0..9611553e829f 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -499,7 +499,7 @@ int spi_nor_xread_sr(struct spi_nor *nor, u8 *sr)
> * the flash is ready for new commands.
> * @nor: pointer to 'struct spi_nor'.
> *
> - * Return: 0 on success, -errno otherwise.
> + * Return: 1 if ready, 0 if not ready, -errno on errors.
> */
> static int spi_nor_xsr_ready(struct spi_nor *nor)
> {
> @@ -542,7 +542,7 @@ static void spi_nor_clear_sr(struct spi_nor *nor)
> * for new commands.
> * @nor: pointer to 'struct spi_nor'.
> *
> - * Return: 0 on success, -errno otherwise.
> + * Return: 1 if ready, 0 if not ready, -errno on errors.
> */
> static int spi_nor_sr_ready(struct spi_nor *nor)
> {
> @@ -606,7 +606,7 @@ static void spi_nor_clear_fsr(struct spi_nor *nor)
> * ready for new commands.
> * @nor: pointer to 'struct spi_nor'.
> *
> - * Return: 0 on success, -errno otherwise.
> + * Return: 1 if ready, 0 if not ready, -errno on errors.
> */
> static int spi_nor_fsr_ready(struct spi_nor *nor)
> {
> @@ -647,7 +647,7 @@ static int spi_nor_fsr_ready(struct spi_nor *nor)
> * spi_nor_ready() - Query the flash to see if it is ready for new commands.
> * @nor: pointer to 'struct spi_nor'.
> *
> - * Return: 0 on success, -errno otherwise.
> + * Return: 1 if ready, 0 if not ready, -errno on errors.
> */
> static int spi_nor_ready(struct spi_nor *nor)
> {
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-04-28 12:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 6:31 [PATCH 1/2] mtd: spi-nor: Uniformize the return value in spi_nor_*_ready() Tudor.Ambarus
2020-04-21 6:31 ` [PATCH 2/2] mtd: spi-nor: Fix description of the sr_ready() return value Tudor.Ambarus
2020-04-28 12:21 ` Vignesh Raghavendra [this message]
2020-04-29 6:49 ` Tudor.Ambarus
2020-04-28 12:06 ` [PATCH 1/2] mtd: spi-nor: Uniformize the return value in spi_nor_*_ready() Vignesh Raghavendra
2020-04-29 6:48 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14162c9a-2189-024f-7af2-e072ea1511da@ti.com \
--to=vigneshr@ti.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=linux-mtd@lists.infradead.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.