All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vignesh Raghavendra <vigneshr@ti.com>
To: <Tudor.Ambarus@microchip.com>, <sergei.shtylyov@cogentembedded.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/2] mtd: spi-nor: Uniformize the return value in spi_nor_*_ready()
Date: Tue, 28 Apr 2020 17:36:19 +0530	[thread overview]
Message-ID: <38a730a2-2a16-6ed4-3203-31e1fbe8dd99@ti.com> (raw)
In-Reply-To: <20200421063129.244466-1-tudor.ambarus@microchip.com>



On 21/04/20 12:01 pm, Tudor.Ambarus@microchip.com wrote:
> From: Tudor Ambarus <tudor.ambarus@microchip.com>
> 
> spi_nor_ready() returns 1 if ready, 0 if not ready and -errono on errors.

s/-errono/-errno

With that:

Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>

> Do the same in all the spi_nor_*_ready() children.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
>  drivers/mtd/spi-nor/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index cc68ea84318e..9dcc53bda8b0 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -640,7 +640,7 @@ static int spi_nor_fsr_ready(struct spi_nor *nor)
>  		return -EIO;
>  	}
>  
> -	return nor->bouncebuf[0] & FSR_READY;
> +	return !!(nor->bouncebuf[0] & FSR_READY);
>  }
>  
>  /**
> 

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2020-04-28 12:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21  6:31 [PATCH 1/2] mtd: spi-nor: Uniformize the return value in spi_nor_*_ready() Tudor.Ambarus
2020-04-21  6:31 ` [PATCH 2/2] mtd: spi-nor: Fix description of the sr_ready() return value Tudor.Ambarus
2020-04-28 12:21   ` Vignesh Raghavendra
2020-04-29  6:49     ` Tudor.Ambarus
2020-04-28 12:06 ` Vignesh Raghavendra [this message]
2020-04-29  6:48   ` [PATCH 1/2] mtd: spi-nor: Uniformize the return value in spi_nor_*_ready() Tudor.Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38a730a2-2a16-6ed4-3203-31e1fbe8dd99@ti.com \
    --to=vigneshr@ti.com \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.