[PATCH 0/6] Port some recipes from openembedded and upgrade

[PATCH 0/6] Port some recipes from openembedded and upgrade

[Bian Naimeng]

Port some recipes from openembedded and upgrade

Bian Naimeng (6):
  evieext: Port evieext from openembedded.
  fontcacheproto: Port fontcacheproto from openembedded.
  libxfontcache: Port libxfontcache from openembedded.
  printproto: Port printproto from openembedded.
  libxp: Port libxp from openembedded.
  corosync: Port corosync from openembedded and upgrade to 1.4.7

 .../xorg-lib/libxfontcache_1.0.5.bb                | 15 ++++++++
 .../xorg-lib/libxp/fix-cast-error.patch            | 42 ++++++++++++++++++++++
 meta-oe/recipes-graphics/xorg-lib/libxp_1.0.1.bb   | 22 ++++++++++++
 .../recipes-graphics/xorg-proto/evieext_1.1.1.bb   | 14 ++++++++
 .../xorg-proto/fontcacheproto_0.1.3.bb             | 16 +++++++++
 .../xorg-proto/printproto_1.0.5.bb                 | 16 +++++++++
 meta-oe/recipes-support/corosync/corosync_1.4.7.bb | 31 ++++++++++++++++
 .../corosync/files/config-site.corosync            |  4 +++
 meta-oe/recipes-support/corosync/files/groff.patch | 12 +++++++
 9 files changed, 172 insertions(+)
 create mode 100644 meta-oe/recipes-graphics/xorg-lib/libxfontcache_1.0.5.bb
 create mode 100644 meta-oe/recipes-graphics/xorg-lib/libxp/fix-cast-error.patch
 create mode 100644 meta-oe/recipes-graphics/xorg-lib/libxp_1.0.1.bb
 create mode 100644 meta-oe/recipes-graphics/xorg-proto/evieext_1.1.1.bb
 create mode 100644 meta-oe/recipes-graphics/xorg-proto/fontcacheproto_0.1.3.bb
 create mode 100644 meta-oe/recipes-graphics/xorg-proto/printproto_1.0.5.bb
 create mode 100644 meta-oe/recipes-support/corosync/corosync_1.4.7.bb
 create mode 100644 meta-oe/recipes-support/corosync/files/config-site.corosync
 create mode 100644 meta-oe/recipes-support/corosync/files/groff.patch

-- 
1.9.1

[PATCH 1/6] [meta-oe] evieext: Port evieext from openembedded

[Bian Naimeng]

Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
---
 meta-oe/recipes-graphics/xorg-proto/evieext_1.1.1.bb | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 meta-oe/recipes-graphics/xorg-proto/evieext_1.1.1.bb

diff --git a/meta-oe/recipes-graphics/xorg-proto/evieext_1.1.1.bb b/meta-oe/recipes-graphics/xorg-proto/evieext_1.1.1.bb
new file mode 100644
index 0000000..5a30f09
--- /dev/null
+++ b/meta-oe/recipes-graphics/xorg-proto/evieext_1.1.1.bb
@@ -0,0 +1,14 @@
+require recipes-graphics/xorg-proto/xorg-proto-common.inc
+
+SUMMARY = "EvIE: X Event Interception Extension headers"
+
+DESCRIPTION = "This package provides the wire protocol for the X Event \
+Interception Extension.  This extension allows the interception of \
+keyboard and mouse events."
+
+PE = "1"
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=4db9fc6a58e873c6392eec53082d89b5"
+
+SRC_URI[archive.md5sum] = "98bd86a13686f65f0873070fdee6efc7"
+SRC_URI[archive.sha256sum] = "1cf74114436d99f56577a90b6438a32ba31b8128c9e63842bb179aba592733fe"
-- 
1.9.1

[PATCH 2/6] [meta-oe] fontcacheproto: Port fontcacheproto from openembedded.

[Bian Naimeng]

Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
---
 .../recipes-graphics/xorg-proto/fontcacheproto_0.1.3.bb  | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 meta-oe/recipes-graphics/xorg-proto/fontcacheproto_0.1.3.bb

diff --git a/meta-oe/recipes-graphics/xorg-proto/fontcacheproto_0.1.3.bb b/meta-oe/recipes-graphics/xorg-proto/fontcacheproto_0.1.3.bb
new file mode 100644
index 0000000..749b283
--- /dev/null
+++ b/meta-oe/recipes-graphics/xorg-proto/fontcacheproto_0.1.3.bb
@@ -0,0 +1,16 @@
+require recipes-graphics/xorg-proto/xorg-proto-common.inc
+
+SUMMARY = "XFontCache: X Font Cache extension headers"
+
+DESCRIPTION = "This package provides the wire protocol for the X Font \
+Cache extension.  This extension is used by X-TrueType to cache \
+information about fonts."
+
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://COPYING;md5=ba9fcd8fe6d09af9f733daccc1a21857 \
+                    file://fontcacheP.h;endline=28;md5=85c80bfa96c802ee85a570862ee60214"
+
+PE = "1"
+
+SRC_URI[md5sum] = "a8a50e5e995bfacb0359575faf7f6906"
+SRC_URI[sha256sum] = "1dcaa659d416272ff68e567d1910ccc1e369768f13b983cffcccd6c563dbe3cb"
-- 
1.9.1

[PATCH 3/6] [meta-oe] libxfontcache: Port libxfontcache from openembedded.

[Bian Naimeng]

Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
---
 meta-oe/recipes-graphics/xorg-lib/libxfontcache_1.0.5.bb | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 meta-oe/recipes-graphics/xorg-lib/libxfontcache_1.0.5.bb

diff --git a/meta-oe/recipes-graphics/xorg-lib/libxfontcache_1.0.5.bb b/meta-oe/recipes-graphics/xorg-lib/libxfontcache_1.0.5.bb
new file mode 100644
index 0000000..023bf04
--- /dev/null
+++ b/meta-oe/recipes-graphics/xorg-lib/libxfontcache_1.0.5.bb
@@ -0,0 +1,15 @@
+require recipes-graphics/xorg-lib/xorg-lib-common.inc
+
+SUMMARY = "XFontCache: X Font Cache extension library"
+
+DESCRIPTION = "FontCache is an extension that is used by X-TrueType to cache \
+information about fonts."
+
+DEPENDS += "libxext fontcacheproto zlib"
+LIC_FILES_CHKSUM = "file://COPYING;md5=62a75d5d3da40f1f6eb1cbe3bcc0a5d0"
+PE = "1"
+
+XORG_PN = "libXfontcache"
+
+SRC_URI[md5sum] = "bbd37768c87f63cf2eb845b2c0f56515"
+SRC_URI[sha256sum] = "0d639219549f51fa0e6b4414383f5d13e6c1638e66b3434f4626eb989ffacbce"
-- 
1.9.1

[PATCH 4/6] [meta-oe] printproto: Port printproto from openembedded

[Bian Naimeng]

Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
---
 meta-oe/recipes-graphics/xorg-proto/printproto_1.0.5.bb | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 meta-oe/recipes-graphics/xorg-proto/printproto_1.0.5.bb

diff --git a/meta-oe/recipes-graphics/xorg-proto/printproto_1.0.5.bb b/meta-oe/recipes-graphics/xorg-proto/printproto_1.0.5.bb
new file mode 100644
index 0000000..27b56b6
--- /dev/null
+++ b/meta-oe/recipes-graphics/xorg-proto/printproto_1.0.5.bb
@@ -0,0 +1,16 @@
+require recipes-graphics/xorg-proto/xorg-proto-common.inc
+
+SUMMARY = "XP: X Printing extension headers"
+
+DESCRIPTION = "This package provides the wire protocol for the X \
+Printing extension.  This extension provides a way for client \
+applications to render to non-display devices."
+
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://COPYING;md5=658463213f19b48b81f8672d2696069f \
+                    file://Print.h;beginline=2;endline=59;md5=db19e065445b3755c09432864dcd8a9b"
+
+PE = "1"
+
+SRC_URI[md5sum] = "99d0e25feea2fead7d8325b7000b41c3"
+SRC_URI[sha256sum] = "1298316cf43b987365ab7764d61b022a3d7f180b67b423eed3456862d155911a"
-- 
1.9.1

[PATCH 5/6] [meta-oe] libxp: Port libxp from openembedded.

[Bian Naimeng]

Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
---
 .../xorg-lib/libxp/fix-cast-error.patch            | 42 ++++++++++++++++++++++
 meta-oe/recipes-graphics/xorg-lib/libxp_1.0.1.bb   | 22 ++++++++++++
 2 files changed, 64 insertions(+)
 create mode 100644 meta-oe/recipes-graphics/xorg-lib/libxp/fix-cast-error.patch
 create mode 100644 meta-oe/recipes-graphics/xorg-lib/libxp_1.0.1.bb

diff --git a/meta-oe/recipes-graphics/xorg-lib/libxp/fix-cast-error.patch b/meta-oe/recipes-graphics/xorg-lib/libxp/fix-cast-error.patch
new file mode 100644
index 0000000..fea18cf
--- /dev/null
+++ b/meta-oe/recipes-graphics/xorg-lib/libxp/fix-cast-error.patch
@@ -0,0 +1,42 @@
+This patch fixes these new errors:
+
+| XpNotifyPdm.c:234:10: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
+| XpNotifyPdm.c:271:10: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
+| XpNotifyPdm.c:286:10: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
+
+
+Upstream-Status: Pending
+
+Signed-off-by: Saul Wold <sgw@linux.intel.com>
+
+Index: libXp-1.0.1/src/XpNotifyPdm.c
+===================================================================
+--- libXp-1.0.1.orig/src/XpNotifyPdm.c
++++ libXp-1.0.1/src/XpNotifyPdm.c
+@@ -231,7 +231,7 @@ XpGetPdmStartParams (
+ 	/*
+ 	 * Error - cannot determine or establish a selection_display.
+ 	 */
+-	return( (Status) NULL );
++	return( (Status) 0 );
+     }
+ 
+     /*
+@@ -268,7 +268,7 @@ XpGetPdmStartParams (
+ 	    XCloseDisplay( *selection_display );
+ 	    *selection_display = (Display *) NULL;
+ 	}
+-	return( (Status) NULL );
++	return( (Status) 0 );
+     }
+ 
+     status = XmbTextListToTextProperty( *selection_display, list, 6,
+@@ -283,7 +283,7 @@ XpGetPdmStartParams (
+ 	    XCloseDisplay( *selection_display );
+ 	    *selection_display = (Display *) NULL;
+ 	}
+-	return( (Status) NULL );
++	return( (Status) 0 );
+     }
+ 
+     *type              = text_prop.encoding;
diff --git a/meta-oe/recipes-graphics/xorg-lib/libxp_1.0.1.bb b/meta-oe/recipes-graphics/xorg-lib/libxp_1.0.1.bb
new file mode 100644
index 0000000..748c3ea
--- /dev/null
+++ b/meta-oe/recipes-graphics/xorg-lib/libxp_1.0.1.bb
@@ -0,0 +1,22 @@
+require recipes-graphics/xorg-lib/xorg-lib-common.inc
+
+SUMMARY = "XP: X Printing extension library"
+
+DESCRIPTION = "libXp provides public APIs to allow client applications \
+to render to non-display devices, making use of the X Print Service."
+
+LICENSE = "MIT & MIT-style"
+LIC_FILES_CHKSUM = "file://COPYING;md5=9504a1264f5ddd4949254a57c0f8d6bb \
+                    file://src/XpPage.c;beginline=2;endline=35;md5=2b7d3d2ba5505b19271cf31b6918997e"
+
+DEPENDS += "libxext libxau printproto"
+PE = "1"
+
+XORG_PN = "libXp"
+
+CFLAGS_append = " -I ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
+
+SRC_URI += "file://fix-cast-error.patch"
+
+SRC_URI[md5sum] = "7ae1d63748e79086bd51a633da1ff1a9"
+SRC_URI[sha256sum] = "71d1f260005616d646b8c8788365f2b7d93911dac57bb53b65753d9f9e6443d2"
-- 
1.9.1

[PATCH 6/6] [meta-oe] Port corosync from openembedded and upgrade to 1.4.7

[Bian Naimeng]

Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
---
 meta-oe/recipes-support/corosync/corosync_1.4.7.bb | 31 ++++++++++++++++++++++
 .../corosync/files/config-site.corosync            |  4 +++
 meta-oe/recipes-support/corosync/files/groff.patch | 12 +++++++++
 3 files changed, 47 insertions(+)
 create mode 100644 meta-oe/recipes-support/corosync/corosync_1.4.7.bb
 create mode 100644 meta-oe/recipes-support/corosync/files/config-site.corosync
 create mode 100644 meta-oe/recipes-support/corosync/files/groff.patch

diff --git a/meta-oe/recipes-support/corosync/corosync_1.4.7.bb b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
new file mode 100644
index 0000000..a3b8864
--- /dev/null
+++ b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
@@ -0,0 +1,31 @@
+SUMMARY = "The Corosync Cluster Engine and Application Programming Interfaces"
+DESCRIPTION = "This package contains the Corosync Cluster Engine Executive, several default \
+APIs and libraries, default configuration files, and an init script."
+HOMEPAGE = "http://corosync.github.io/corosync/"
+
+inherit autotools pkgconfig
+
+SRC_URI = "http://build.clusterlabs.org/corosync/releases/${BPN}-${PV}.tar.gz \
+           file://config-site.corosync \
+           file://groff.patch \
+	   "
+
+SRC_URI[md5sum] = "da9b2cf0b55f08ac4cf7cd82ac2f977a"
+SRC_URI[sha256sum] = "c1d005b2093e9a725abd1dfb2be936114b561c0b3145aca11f58c1a733a05af8"
+
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=25656171d1e4054c636a9893067f8c30"
+
+CONFIG_SITE = "${WORKDIR}/config-site.corosync"
+
+DEPENDS = "groff-native nss"
+
+EXTRA_OECONF += " --enable-nss "
+CFLAGS_append += " -fPIC "
+
+do_compile() {
+    DESCPATH="${STAGING_DATADIR_NATIVE}/groff/`groff -v | awk '{if(NR==1)print $4}'`/font"
+    oe_runmake DESCPATH=${DESCPATH}
+}
+
+FILES_${PN}-dbg += "${libexecdir}/lcrso/.debug"
diff --git a/meta-oe/recipes-support/corosync/files/config-site.corosync b/meta-oe/recipes-support/corosync/files/config-site.corosync
new file mode 100644
index 0000000..3472dec
--- /dev/null
+++ b/meta-oe/recipes-support/corosync/files/config-site.corosync
@@ -0,0 +1,4 @@
+ac_cv_func_fnmatch_works=yes
+ac_cv_func_malloc_0_nonnull=yes
+ac_cv_func_realloc_0_nonnull=yes
+
diff --git a/meta-oe/recipes-support/corosync/files/groff.patch b/meta-oe/recipes-support/corosync/files/groff.patch
new file mode 100644
index 0000000..da1378a
--- /dev/null
+++ b/meta-oe/recipes-support/corosync/files/groff.patch
@@ -0,0 +1,12 @@
+diff -Nurp corosync-1.3.1.org/man/Makefile.am corosync-1.3.1/man/Makefile.am
+--- corosync-1.3.1.org/man/Makefile.am	2011-04-25 10:37:50.000000000 +0800
++++ corosync-1.3.1/man/Makefile.am	2014-11-24 10:33:36.583426707 +0800
+@@ -126,7 +126,7 @@ HTML_DOCS = $(dist_man_MANS:%=%.html)
+ INDEX_HTML = index.html
+ 
+ %.html: %
+-	$(GROFF) -mandoc -Thtml $^ > $@
++	$(GROFF) -F $(DESCPATH) -mandoc -Thtml $^ > $@
+ 
+ install-data-local:
+ 	$(INSTALL) -d $(DESTDIR)/${docdir}/html
-- 
1.9.1

Re: [PATCH 4/6] [meta-oe] printproto: Port printproto from openembedded

[Burton, Ross]

On 24 November 2014 at 06:45, Bian Naimeng <biannm@cn.fujitsu.com> wrote:

>  meta-oe/recipes-graphics/xorg-proto/printproto_1.0.5.bb | 16
> ++++++++++++++++
>

Really?  Are you just trying to add every recipe from oe-classic to
meta-oe, or in this case are you actually using XPrint?  XPrint was removed
from xserver in 2008 because it didn't actually work[1] - that's *six*
years ago.  meta-oe doesn't need pointless recipes that are unmaintained,
and if you're using an ancient X server and enable XPrint, then you can
also carry the XPrint proto/libs.

Ross

[1]
http://cgit.freedesktop.org/xorg/xserver/commit/?id=1c8bd318fbaf65890ef16fe26c76dd5e6f14dfde

Re: [PATCH 1/6] [meta-oe] evieext: Port evieext from openembedded

[Burton, Ross]

On 24 November 2014 at 06:45, Bian Naimeng <biannm@cn.fujitsu.com> wrote:

>  meta-oe/recipes-graphics/xorg-proto/evieext_1.1.1.bb | 14 ++++++++++++++
>

NAK.

commit aee0f321ef939e7d7ad9585a66e8cb22cad7514f
Author: Ross Burton <ross.burton@intel.com>
Date:   Fri Oct 12 09:32:16 2012 +0000

    xorg-proto: remove evieext

    It was removed from xserver in 2008.

Ross

Re: [PATCH 2/6] [meta-oe] fontcacheproto: Port fontcacheproto from openembedded.

[Burton, Ross]

On 24 November 2014 at 06:45, Bian Naimeng <biannm@cn.fujitsu.com> wrote:

>  .../recipes-graphics/xorg-proto/fontcacheproto_0.1.3.bb  | 16
> ++++++++++++++++
>

Just to continue the theme:

commit 3f516bbcc57e1f12cde55ff9049202efa2e27f60
Author: Ross Burton <ross.burton@intel.com>
Date:   Wed Oct 10 13:51:16 2012 +0100

    xorg: remove fontcache support

    This was removed from the Xorg server in 2008.

    (From OE-Core rev: 02fc0a197ca16e983becb0aedeb9238a0aeb6661)

Ross

Re: [PATCH 6/6] [meta-oe] Port corosync from openembedded and upgrade to 1.4.7

[Joe MacDonald]

[-- Attachment #1: Type: text/plain, Size: 4144 bytes --]

Hi Bian,

[[oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and upgrade to 1.4.7] On 14.11.24 (Mon 14:45) Bian Naimeng wrote:

> Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
> ---
>  meta-oe/recipes-support/corosync/corosync_1.4.7.bb | 31 ++++++++++++++++++++++
>  .../corosync/files/config-site.corosync            |  4 +++
>  meta-oe/recipes-support/corosync/files/groff.patch | 12 +++++++++
>  3 files changed, 47 insertions(+)
>  create mode 100644 meta-oe/recipes-support/corosync/corosync_1.4.7.bb
>  create mode 100644 meta-oe/recipes-support/corosync/files/config-site.corosync
>  create mode 100644 meta-oe/recipes-support/corosync/files/groff.patch

This probably belongs in meta-networking (unless there's strong opinion
it belongs somewhere else).  Did you have a look at what has been done
in meta-cgl (git://git.enea.com/linux/meta-cgl) with the recipe to see
if there was anything useful there?  I know meta-cgl isn't very well
publicized yet, but it is in the layer index.  If you haven't looked at
what's there yet, it may be worth having a look to see if any of it can
save you some time.

For what it's worth, there does seem to be rather a lot more in meta-cgl
and I think at least some of it still applies (eg. the volatiles file).

> diff --git a/meta-oe/recipes-support/corosync/corosync_1.4.7.bb b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> new file mode 100644
> index 0000000..a3b8864
> --- /dev/null
> +++ b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> @@ -0,0 +1,31 @@
> +SUMMARY = "The Corosync Cluster Engine and Application Programming Interfaces"
> +DESCRIPTION = "This package contains the Corosync Cluster Engine Executive, several default \
> +APIs and libraries, default configuration files, and an init script."
> +HOMEPAGE = "http://corosync.github.io/corosync/"
> +
> +inherit autotools pkgconfig
> +
> +SRC_URI = "http://build.clusterlabs.org/corosync/releases/${BPN}-${PV}.tar.gz \
> +           file://config-site.corosync \
> +           file://groff.patch \
> +	   "

Please remove the tab before space above.

> +
> +SRC_URI[md5sum] = "da9b2cf0b55f08ac4cf7cd82ac2f977a"
> +SRC_URI[sha256sum] = "c1d005b2093e9a725abd1dfb2be936114b561c0b3145aca11f58c1a733a05af8"
> +
> +LICENSE = "BSD"

I think this is actually a BSD-3-Clause license, isn't it?

> +LIC_FILES_CHKSUM = "file://LICENSE;md5=25656171d1e4054c636a9893067f8c30"
> +
> +CONFIG_SITE = "${WORKDIR}/config-site.corosync"
> +
> +DEPENDS = "groff-native nss"
> +
> +EXTRA_OECONF += " --enable-nss "
> +CFLAGS_append += " -fPIC "
> +
> +do_compile() {
> +    DESCPATH="${STAGING_DATADIR_NATIVE}/groff/`groff -v | awk '{if(NR==1)print $4}'`/font"
> +    oe_runmake DESCPATH=${DESCPATH}
> +}
> +
> +FILES_${PN}-dbg += "${libexecdir}/lcrso/.debug"
> diff --git a/meta-oe/recipes-support/corosync/files/config-site.corosync b/meta-oe/recipes-support/corosync/files/config-site.corosync
> new file mode 100644
> index 0000000..3472dec
> --- /dev/null
> +++ b/meta-oe/recipes-support/corosync/files/config-site.corosync
> @@ -0,0 +1,4 @@
> +ac_cv_func_fnmatch_works=yes
> +ac_cv_func_malloc_0_nonnull=yes
> +ac_cv_func_realloc_0_nonnull=yes
> +
> diff --git a/meta-oe/recipes-support/corosync/files/groff.patch b/meta-oe/recipes-support/corosync/files/groff.patch

Can you add a header to this patch please?

Thanks.

-J.

> new file mode 100644
> index 0000000..da1378a
> --- /dev/null
> +++ b/meta-oe/recipes-support/corosync/files/groff.patch
> @@ -0,0 +1,12 @@
> +diff -Nurp corosync-1.3.1.org/man/Makefile.am corosync-1.3.1/man/Makefile.am
> +--- corosync-1.3.1.org/man/Makefile.am	2011-04-25 10:37:50.000000000 +0800
> ++++ corosync-1.3.1/man/Makefile.am	2014-11-24 10:33:36.583426707 +0800
> +@@ -126,7 +126,7 @@ HTML_DOCS = $(dist_man_MANS:%=%.html)
> + INDEX_HTML = index.html
> + 
> + %.html: %
> +-	$(GROFF) -mandoc -Thtml $^ > $@
> ++	$(GROFF) -F $(DESCPATH) -mandoc -Thtml $^ > $@
> + 
> + install-data-local:
> + 	$(INSTALL) -d $(DESTDIR)/${docdir}/html
> -- 
> 1.9.1
> 
-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 501 bytes --]

Re: [PATCH 6/6] [meta-oe] Port corosync from openembedded and upgrade to 1.4.7

[Bian, Naimeng]

Hi Joe

Thanks for your advices.
I will look at meta-cgl.

Regards
 Bian

> -----Original Message-----
> From: Joe MacDonald [mailto:Joe_MacDonald@mentor.com]
> Sent: Tuesday, November 25, 2014 3:40 AM
> Cc: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded
> and upgrade to 1.4.7
> 
> Hi Bian,
> 
> [[oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and upgrade
> to 1.4.7] On 14.11.24 (Mon 14:45) Bian Naimeng wrote:
> 
> > Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
> > ---
> >  meta-oe/recipes-support/corosync/corosync_1.4.7.bb | 31
> ++++++++++++++++++++++
> >  .../corosync/files/config-site.corosync            |  4 +++
> >  meta-oe/recipes-support/corosync/files/groff.patch | 12 +++++++++
> >  3 files changed, 47 insertions(+)
> >  create mode 100644 meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> >  create mode 100644
> > meta-oe/recipes-support/corosync/files/config-site.corosync
> >  create mode 100644 meta-oe/recipes-support/corosync/files/groff.patch
> 
> This probably belongs in meta-networking (unless there's strong opinion
> it belongs somewhere else).  Did you have a look at what has been done in
> meta-cgl (git://git.enea.com/linux/meta-cgl) with the recipe to see if
> there was anything useful there?  I know meta-cgl isn't very well publicized
> yet, but it is in the layer index.  If you haven't looked at what's there
> yet, it may be worth having a look to see if any of it can save you some
> time.
> 
> For what it's worth, there does seem to be rather a lot more in meta-cgl
> and I think at least some of it still applies (eg. the volatiles file).
> 
> > diff --git a/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > new file mode 100644
> > index 0000000..a3b8864
> > --- /dev/null
> > +++ b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > @@ -0,0 +1,31 @@
> > +SUMMARY = "The Corosync Cluster Engine and Application Programming
> Interfaces"
> > +DESCRIPTION = "This package contains the Corosync Cluster Engine
> > +Executive, several default \ APIs and libraries, default configuration
> files, and an init script."
> > +HOMEPAGE = "http://corosync.github.io/corosync/"
> > +
> > +inherit autotools pkgconfig
> > +
> > +SRC_URI =
> "http://build.clusterlabs.org/corosync/releases/${BPN}-${PV}.tar.gz \
> > +           file://config-site.corosync \
> > +           file://groff.patch \
> > +	   "
> 
> Please remove the tab before space above.
> 
> > +
> > +SRC_URI[md5sum] = "da9b2cf0b55f08ac4cf7cd82ac2f977a"
> > +SRC_URI[sha256sum] =
> "c1d005b2093e9a725abd1dfb2be936114b561c0b3145aca11f58c1a733a05af8"
> > +
> > +LICENSE = "BSD"
> 
> I think this is actually a BSD-3-Clause license, isn't it?
> 
> > +LIC_FILES_CHKSUM =
> "file://LICENSE;md5=25656171d1e4054c636a9893067f8c30"
> > +
> > +CONFIG_SITE = "${WORKDIR}/config-site.corosync"
> > +
> > +DEPENDS = "groff-native nss"
> > +
> > +EXTRA_OECONF += " --enable-nss "
> > +CFLAGS_append += " -fPIC "
> > +
> > +do_compile() {
> > +    DESCPATH="${STAGING_DATADIR_NATIVE}/groff/`groff -v | awk
> '{if(NR==1)print $4}'`/font"
> > +    oe_runmake DESCPATH=${DESCPATH}
> > +}
> > +
> > +FILES_${PN}-dbg += "${libexecdir}/lcrso/.debug"
> > diff --git
> > a/meta-oe/recipes-support/corosync/files/config-site.corosync
> > b/meta-oe/recipes-support/corosync/files/config-site.corosync
> > new file mode 100644
> > index 0000000..3472dec
> > --- /dev/null
> > +++ b/meta-oe/recipes-support/corosync/files/config-site.corosync
> > @@ -0,0 +1,4 @@
> > +ac_cv_func_fnmatch_works=yes
> > +ac_cv_func_malloc_0_nonnull=yes
> > +ac_cv_func_realloc_0_nonnull=yes
> > +
> > diff --git a/meta-oe/recipes-support/corosync/files/groff.patch
> > b/meta-oe/recipes-support/corosync/files/groff.patch
> 
> Can you add a header to this patch please?
> 
> Thanks.
> 
> -J.
> 
> > new file mode 100644
> > index 0000000..da1378a
> > --- /dev/null
> > +++ b/meta-oe/recipes-support/corosync/files/groff.patch
> > @@ -0,0 +1,12 @@
> > +diff -Nurp corosync-1.3.1.org/man/Makefile.am
> corosync-1.3.1/man/Makefile.am
> > +--- corosync-1.3.1.org/man/Makefile.am	2011-04-25
> 10:37:50.000000000 +0800
> > ++++ corosync-1.3.1/man/Makefile.am	2014-11-24 10:33:36.583426707
> +0800
> > +@@ -126,7 +126,7 @@ HTML_DOCS = $(dist_man_MANS:%=%.html)  INDEX_HTML
> > += index.html
> > +
> > + %.html: %
> > +-	$(GROFF) -mandoc -Thtml $^ > $@
> > ++	$(GROFF) -F $(DESCPATH) -mandoc -Thtml $^ > $@
> > +
> > + install-data-local:
> > + 	$(INSTALL) -d $(DESTDIR)/${docdir}/html
> > --
> > 1.9.1
> >
> --
> -Joe MacDonald.
> :wq

Re: [PATCH 4/6] [meta-oe] printproto: Port printproto from openembedded

[Bian, Naimeng]

> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
> Burton, Ross
> Sent: Monday, November 24, 2014 6:31 PM
> To: OE-devel
> Subject: Re: [oe] [PATCH 4/6] [meta-oe] printproto: Port printproto from
> openembedded
> 
> On 24 November 2014 at 06:45, Bian Naimeng <biannm@cn.fujitsu.com> wrote:
> 
> >  meta-oe/recipes-graphics/xorg-proto/printproto_1.0.5.bb | 16
> > ++++++++++++++++
> >
> 
> Really?  Are you just trying to add every recipe from oe-classic to meta-oe,
> or in this case are you actually using XPrint?  XPrint was removed from
> xserver in 2008 because it didn't actually work[1] - that's *six* years
> ago.  meta-oe doesn't need pointless recipes that are unmaintained, and
> if you're using an ancient X server and enable XPrint, then you can also
> carry the XPrint proto/libs.
> 

No, I don't have a plan to add every recipe from oe-classic. ^_^
These recipes just used by our distro. 
It looks like we should change our specification.

Regards
 Bian

> Ross
> 
> [1]
> http://cgit.freedesktop.org/xorg/xserver/commit/?id=1c8bd318fbaf65890e
> f16fe26c76dd5e6f14dfde
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [PATCH 4/6] [meta-oe] printproto: Port printproto from openembedded

[Burton, Ross]

On 25 November 2014 at 01:14, Bian, Naimeng <biannm@cn.fujitsu.com> wrote:

> No, I don't have a plan to add every recipe from oe-classic. ^_^
> These recipes just used by our distro.
> It looks like we should change our specification.
>

Sending in recipes that you've ported is much appreciated, but in this case
as all of these X recipes are not used by any X servers available in OE you
keep them locally.  In all honesty unless you're using an old X server
they're not needed anyway.

Ross

Re: [PATCH 4/6] [meta-oe] printproto: Port printproto from openembedded

[Bian, Naimeng]

> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
> Burton, Ross
> Sent: Tuesday, November 25, 2014 5:14 PM
> To: OE-devel
> Subject: Re: [oe] [PATCH 4/6] [meta-oe] printproto: Port printproto from
> openembedded
> 
> On 25 November 2014 at 01:14, Bian, Naimeng <biannm@cn.fujitsu.com> wrote:
> 
> > No, I don't have a plan to add every recipe from oe-classic. ^_^ These
> > recipes just used by our distro.
> > It looks like we should change our specification.
> >
> 
> Sending in recipes that you've ported is much appreciated, but in this case
> as all of these X recipes are not used by any X servers available in OE you
> keep them locally.  In all honesty unless you're using an old X server they're
> not needed anyway.
> 

Thanks for your explanation. It's helpful to me 
I will consider whether it's necessary to upgrad our X implementation.

Regards
 Bian

> Ross
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [PATCH 6/6] [meta-oe] Port corosync from openembedded and upgrade to 1.4.7

[Alexandru Vaduva]

It is my opinion that meta-cgl is the place for your patch being the fact that pacemaker and the rest of the HA cluster resources are available here.
Also I believe this patch should be available inside the open embedded repository.

If it would be ok with you I would suggest to have two patches: one sent for the OpenEmbedded and one for the meta-cgl.
If the porting for meta-cgl would not be possible please let me know for assuring that the patch is ported inside meta-cgl.

Another extra reason for which I would prefer this patch to be also available inside meta-cgl would be the extra testing that will be done for it and the fact that corosync messaging layer will be used with pacemaker.


Thank you,
Alex Vaduva

-----Original Message-----
From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Bian, Naimeng
Sent: Tuesday, November 25, 2014 2:29 AM
To: Joe MacDonald
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and upgrade to 1.4.7

Hi Joe

Thanks for your advices.
I will look at meta-cgl.

Regards
 Bian

> -----Original Message-----
> From: Joe MacDonald [mailto:Joe_MacDonald@mentor.com]
> Sent: Tuesday, November 25, 2014 3:40 AM
> Cc: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from 
> openembedded and upgrade to 1.4.7
> 
> Hi Bian,
> 
> [[oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and 
> upgrade to 1.4.7] On 14.11.24 (Mon 14:45) Bian Naimeng wrote:
> 
> > Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
> > ---
> >  meta-oe/recipes-support/corosync/corosync_1.4.7.bb | 31
> ++++++++++++++++++++++
> >  .../corosync/files/config-site.corosync            |  4 +++
> >  meta-oe/recipes-support/corosync/files/groff.patch | 12 +++++++++
> >  3 files changed, 47 insertions(+)
> >  create mode 100644 
> > meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> >  create mode 100644
> > meta-oe/recipes-support/corosync/files/config-site.corosync
> >  create mode 100644 
> > meta-oe/recipes-support/corosync/files/groff.patch
> 
> This probably belongs in meta-networking (unless there's strong 
> opinion it belongs somewhere else).  Did you have a look at what has 
> been done in meta-cgl (git://git.enea.com/linux/meta-cgl) with the 
> recipe to see if there was anything useful there?  I know meta-cgl 
> isn't very well publicized yet, but it is in the layer index.  If you 
> haven't looked at what's there yet, it may be worth having a look to 
> see if any of it can save you some time.
> 
> For what it's worth, there does seem to be rather a lot more in 
> meta-cgl and I think at least some of it still applies (eg. the volatiles file).
> 
> > diff --git a/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > new file mode 100644
> > index 0000000..a3b8864
> > --- /dev/null
> > +++ b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > @@ -0,0 +1,31 @@
> > +SUMMARY = "The Corosync Cluster Engine and Application Programming
> Interfaces"
> > +DESCRIPTION = "This package contains the Corosync Cluster Engine 
> > +Executive, several default \ APIs and libraries, default 
> > +configuration
> files, and an init script."
> > +HOMEPAGE = "http://corosync.github.io/corosync/"
> > +
> > +inherit autotools pkgconfig
> > +
> > +SRC_URI =
> "http://build.clusterlabs.org/corosync/releases/${BPN}-${PV}.tar.gz \
> > +           file://config-site.corosync \
> > +           file://groff.patch \
> > +	   "
> 
> Please remove the tab before space above.
> 
> > +
> > +SRC_URI[md5sum] = "da9b2cf0b55f08ac4cf7cd82ac2f977a"
> > +SRC_URI[sha256sum] =
> "c1d005b2093e9a725abd1dfb2be936114b561c0b3145aca11f58c1a733a05af8"
> > +
> > +LICENSE = "BSD"
> 
> I think this is actually a BSD-3-Clause license, isn't it?
> 
> > +LIC_FILES_CHKSUM =
> "file://LICENSE;md5=25656171d1e4054c636a9893067f8c30"
> > +
> > +CONFIG_SITE = "${WORKDIR}/config-site.corosync"
> > +
> > +DEPENDS = "groff-native nss"
> > +
> > +EXTRA_OECONF += " --enable-nss "
> > +CFLAGS_append += " -fPIC "
> > +
> > +do_compile() {
> > +    DESCPATH="${STAGING_DATADIR_NATIVE}/groff/`groff -v | awk
> '{if(NR==1)print $4}'`/font"
> > +    oe_runmake DESCPATH=${DESCPATH} }
> > +
> > +FILES_${PN}-dbg += "${libexecdir}/lcrso/.debug"
> > diff --git
> > a/meta-oe/recipes-support/corosync/files/config-site.corosync
> > b/meta-oe/recipes-support/corosync/files/config-site.corosync
> > new file mode 100644
> > index 0000000..3472dec
> > --- /dev/null
> > +++ b/meta-oe/recipes-support/corosync/files/config-site.corosync
> > @@ -0,0 +1,4 @@
> > +ac_cv_func_fnmatch_works=yes
> > +ac_cv_func_malloc_0_nonnull=yes
> > +ac_cv_func_realloc_0_nonnull=yes
> > +
> > diff --git a/meta-oe/recipes-support/corosync/files/groff.patch
> > b/meta-oe/recipes-support/corosync/files/groff.patch
> 
> Can you add a header to this patch please?
> 
> Thanks.
> 
> -J.
> 
> > new file mode 100644
> > index 0000000..da1378a
> > --- /dev/null
> > +++ b/meta-oe/recipes-support/corosync/files/groff.patch
> > @@ -0,0 +1,12 @@
> > +diff -Nurp corosync-1.3.1.org/man/Makefile.am
> corosync-1.3.1/man/Makefile.am
> > +--- corosync-1.3.1.org/man/Makefile.am	2011-04-25
> 10:37:50.000000000 +0800
> > ++++ corosync-1.3.1/man/Makefile.am	2014-11-24 10:33:36.583426707
> +0800
> > +@@ -126,7 +126,7 @@ HTML_DOCS = $(dist_man_MANS:%=%.html)  
> > +INDEX_HTML = index.html
> > +
> > + %.html: %
> > +-	$(GROFF) -mandoc -Thtml $^ > $@
> > ++	$(GROFF) -F $(DESCPATH) -mandoc -Thtml $^ > $@
> > +
> > + install-data-local:
> > + 	$(INSTALL) -d $(DESTDIR)/${docdir}/html
> > --
> > 1.9.1
> >
> --
> -Joe MacDonald.
> :wq
--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [PATCH 6/6] [meta-oe] Port corosync from openembedded and upgrade to 1.4.7

[Bian, Naimeng]

> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
> Alexandru Vaduva
> Sent: Tuesday, November 25, 2014 6:19 PM
> To: openembedded-devel@lists.openembedded.org; Joe MacDonald
> Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and
> upgrade to 1.4.7
> 
> It is my opinion that meta-cgl is the place for your patch being the fact that
> pacemaker and the rest of the HA cluster resources are available here.

Thanks.
I confirmed that corosync-1.2.8 and pacemaker are available inside meta-cgl.

> Also I believe this patch should be available inside the open embedded
> repository.
> 

Actually, I do not know what kinds of recipes meta-openembedded likes to merge.
In another hand, what kinds of recipes are no good.
(Of course the unmaintained one such as printproto is no good.)

If there are some rules, would you tell me what's that.
Maybe it's helpful to a newcomer such as me. ^_^

I got some points from the following document, but it's not detailed.
http://www.openembedded.org/wiki/OpenEmbedded-Core#meta-openembedded

----------------------------------------------------------------------------------
meta-openembedded

  For items shared amongst multiple layers that do not fit into OE-Core or any other 
 existing layer, there is the meta-oe layer. This exists in a repository, also called 
 meta-openembedded, which contains a number of other more focused layers (meta-efl, 
 meta-gnome, etc.). This layer will need to be managed carefully over time to avoid 
 it turning into just a newer version of OE-classic.
----------------------------------------------------------------------------------

Maybe we should update this document, add some suggestions like following.
----------------------------------------------------------------------------------
Attention
 Please avoid send a patch such as following.
 1. have not been unmaintained by upstream long time
 2. ... ...
----------------------------------------------------------------------------------

> If it would be ok with you I would suggest to have two patches: one sent for
> the OpenEmbedded and one for the meta-cgl.
> If the porting for meta-cgl would not be possible please let me know for assuring
> that the patch is ported inside meta-cgl.

I confirmed that corosync-1.2.8 is available inside meta-cgl now.
I will send the patch for corosync-1.4.7 to meta-cgl later.

> 
> Another extra reason for which I would prefer this patch to be also available
> inside meta-cgl would be the extra testing that will be done for it and the
> fact that corosync messaging layer will be used with pacemaker.
>

Looks good.
And the same question.  ^_^
Would you tell me what kinds of recipes meta-cgl likes to merge.

Regards
 Bian

> 
> Thank you,
> Alex Vaduva
> 
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Bian,
> Naimeng
> Sent: Tuesday, November 25, 2014 2:29 AM
> To: Joe MacDonald
> Cc: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and
> upgrade to 1.4.7
> 
> Hi Joe
> 
> Thanks for your advices.
> I will look at meta-cgl.
> 
> Regards
>  Bian
> 
> > -----Original Message-----
> > From: Joe MacDonald [mailto:Joe_MacDonald@mentor.com]
> > Sent: Tuesday, November 25, 2014 3:40 AM
> > Cc: openembedded-devel@lists.openembedded.org
> > Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from
> > openembedded and upgrade to 1.4.7
> >
> > Hi Bian,
> >
> > [[oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and
> > upgrade to 1.4.7] On 14.11.24 (Mon 14:45) Bian Naimeng wrote:
> >
> > > Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
> > > ---
> > >  meta-oe/recipes-support/corosync/corosync_1.4.7.bb | 31
> > ++++++++++++++++++++++
> > >  .../corosync/files/config-site.corosync            |  4 +++
> > >  meta-oe/recipes-support/corosync/files/groff.patch | 12 +++++++++
> > >  3 files changed, 47 insertions(+)
> > >  create mode 100644
> > > meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > >  create mode 100644
> > > meta-oe/recipes-support/corosync/files/config-site.corosync
> > >  create mode 100644
> > > meta-oe/recipes-support/corosync/files/groff.patch
> >
> > This probably belongs in meta-networking (unless there's strong
> > opinion it belongs somewhere else).  Did you have a look at what has
> > been done in meta-cgl (git://git.enea.com/linux/meta-cgl) with the
> > recipe to see if there was anything useful there?  I know meta-cgl
> > isn't very well publicized yet, but it is in the layer index.  If you
> > haven't looked at what's there yet, it may be worth having a look to
> > see if any of it can save you some time.
> >
> > For what it's worth, there does seem to be rather a lot more in
> > meta-cgl and I think at least some of it still applies (eg. the volatiles
> file).
> >
> > > diff --git a/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > > b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > > new file mode 100644
> > > index 0000000..a3b8864
> > > --- /dev/null
> > > +++ b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > > @@ -0,0 +1,31 @@
> > > +SUMMARY = "The Corosync Cluster Engine and Application Programming
> > Interfaces"
> > > +DESCRIPTION = "This package contains the Corosync Cluster Engine
> > > +Executive, several default \ APIs and libraries, default
> > > +configuration
> > files, and an init script."
> > > +HOMEPAGE = "http://corosync.github.io/corosync/"
> > > +
> > > +inherit autotools pkgconfig
> > > +
> > > +SRC_URI =
> > "http://build.clusterlabs.org/corosync/releases/${BPN}-${PV}.tar.gz \
> > > +           file://config-site.corosync \
> > > +           file://groff.patch \
> > > +	   "
> >
> > Please remove the tab before space above.
> >
> > > +
> > > +SRC_URI[md5sum] = "da9b2cf0b55f08ac4cf7cd82ac2f977a"
> > > +SRC_URI[sha256sum] =
> > "c1d005b2093e9a725abd1dfb2be936114b561c0b3145aca11f58c1a733a05af8"
> > > +
> > > +LICENSE = "BSD"
> >
> > I think this is actually a BSD-3-Clause license, isn't it?
> >
> > > +LIC_FILES_CHKSUM =
> > "file://LICENSE;md5=25656171d1e4054c636a9893067f8c30"
> > > +
> > > +CONFIG_SITE = "${WORKDIR}/config-site.corosync"
> > > +
> > > +DEPENDS = "groff-native nss"
> > > +
> > > +EXTRA_OECONF += " --enable-nss "
> > > +CFLAGS_append += " -fPIC "
> > > +
> > > +do_compile() {
> > > +    DESCPATH="${STAGING_DATADIR_NATIVE}/groff/`groff -v | awk
> > '{if(NR==1)print $4}'`/font"
> > > +    oe_runmake DESCPATH=${DESCPATH} }
> > > +
> > > +FILES_${PN}-dbg += "${libexecdir}/lcrso/.debug"
> > > diff --git
> > > a/meta-oe/recipes-support/corosync/files/config-site.corosync
> > > b/meta-oe/recipes-support/corosync/files/config-site.corosync
> > > new file mode 100644
> > > index 0000000..3472dec
> > > --- /dev/null
> > > +++ b/meta-oe/recipes-support/corosync/files/config-site.corosync
> > > @@ -0,0 +1,4 @@
> > > +ac_cv_func_fnmatch_works=yes
> > > +ac_cv_func_malloc_0_nonnull=yes
> > > +ac_cv_func_realloc_0_nonnull=yes
> > > +
> > > diff --git a/meta-oe/recipes-support/corosync/files/groff.patch
> > > b/meta-oe/recipes-support/corosync/files/groff.patch
> >
> > Can you add a header to this patch please?
> >
> > Thanks.
> >
> > -J.
> >
> > > new file mode 100644
> > > index 0000000..da1378a
> > > --- /dev/null
> > > +++ b/meta-oe/recipes-support/corosync/files/groff.patch
> > > @@ -0,0 +1,12 @@
> > > +diff -Nurp corosync-1.3.1.org/man/Makefile.am
> > corosync-1.3.1/man/Makefile.am
> > > +--- corosync-1.3.1.org/man/Makefile.am	2011-04-25
> > 10:37:50.000000000 +0800
> > > ++++ corosync-1.3.1/man/Makefile.am	2014-11-24 10:33:36.583426707
> > +0800
> > > +@@ -126,7 +126,7 @@ HTML_DOCS = $(dist_man_MANS:%=%.html)
> > > +INDEX_HTML = index.html
> > > +
> > > + %.html: %
> > > +-	$(GROFF) -mandoc -Thtml $^ > $@
> > > ++	$(GROFF) -F $(DESCPATH) -mandoc -Thtml $^ > $@
> > > +
> > > + install-data-local:
> > > + 	$(INSTALL) -d $(DESTDIR)/${docdir}/html
> > > --
> > > 1.9.1
> > >
> > --
> > -Joe MacDonald.
> > :wq
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [PATCH 6/6] [meta-oe] Port corosync from openembedded and upgrade to 1.4.7

[Alexandru Vaduva]

[-- Attachment #1: Type: text/plain, Size: 9758 bytes --]

Meta-cgl is a placeholder for the packages that offer solutions to CGL reguirements:
https://www.linuxfoundation.org/sites/main/files/CGL_5.0_Specification.pdf

Also here is a list with some of the packages that meta-cgl requires, of course it can be extended with similar packages that respond to the same cgl requirement:


Alex Vaduva

-----Original Message-----
From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Bian, Naimeng
Sent: Wednesday, November 26, 2014 5:36 AM
To: openembedded-devel@lists.openembedded.org; Joe MacDonald
Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and upgrade to 1.4.7

> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf 
> Of Alexandru Vaduva
> Sent: Tuesday, November 25, 2014 6:19 PM
> To: openembedded-devel@lists.openembedded.org; Joe MacDonald
> Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from 
> openembedded and upgrade to 1.4.7
> 
> It is my opinion that meta-cgl is the place for your patch being the 
> fact that pacemaker and the rest of the HA cluster resources are available here.

Thanks.
I confirmed that corosync-1.2.8 and pacemaker are available inside meta-cgl.

> Also I believe this patch should be available inside the open embedded 
> repository.
> 

Actually, I do not know what kinds of recipes meta-openembedded likes to merge.
In another hand, what kinds of recipes are no good.
(Of course the unmaintained one such as printproto is no good.)

If there are some rules, would you tell me what's that.
Maybe it's helpful to a newcomer such as me. ^_^

I got some points from the following document, but it's not detailed.
http://www.openembedded.org/wiki/OpenEmbedded-Core#meta-openembedded

----------------------------------------------------------------------------------
meta-openembedded

  For items shared amongst multiple layers that do not fit into OE-Core or any other  existing layer, there is the meta-oe layer. This exists in a repository, also called  meta-openembedded, which contains a number of other more focused layers (meta-efl,  meta-gnome, etc.). This layer will need to be managed carefully over time to avoid  it turning into just a newer version of OE-classic.
----------------------------------------------------------------------------------

Maybe we should update this document, add some suggestions like following.
----------------------------------------------------------------------------------
Attention
 Please avoid send a patch such as following.
 1. have not been unmaintained by upstream long time  2. ... ...
----------------------------------------------------------------------------------

> If it would be ok with you I would suggest to have two patches: one 
> sent for the OpenEmbedded and one for the meta-cgl.
> If the porting for meta-cgl would not be possible please let me know 
> for assuring that the patch is ported inside meta-cgl.

I confirmed that corosync-1.2.8 is available inside meta-cgl now.
I will send the patch for corosync-1.4.7 to meta-cgl later.

> 
> Another extra reason for which I would prefer this patch to be also 
> available inside meta-cgl would be the extra testing that will be done 
> for it and the fact that corosync messaging layer will be used with pacemaker.
>

Looks good.
And the same question.  ^_^
Would you tell me what kinds of recipes meta-cgl likes to merge.

Regards
 Bian

> 
> Thank you,
> Alex Vaduva
> 
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf 
> Of Bian, Naimeng
> Sent: Tuesday, November 25, 2014 2:29 AM
> To: Joe MacDonald
> Cc: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from 
> openembedded and upgrade to 1.4.7
> 
> Hi Joe
> 
> Thanks for your advices.
> I will look at meta-cgl.
> 
> Regards
>  Bian
> 
> > -----Original Message-----
> > From: Joe MacDonald [mailto:Joe_MacDonald@mentor.com]
> > Sent: Tuesday, November 25, 2014 3:40 AM
> > Cc: openembedded-devel@lists.openembedded.org
> > Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from 
> > openembedded and upgrade to 1.4.7
> >
> > Hi Bian,
> >
> > [[oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and 
> > upgrade to 1.4.7] On 14.11.24 (Mon 14:45) Bian Naimeng wrote:
> >
> > > Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
> > > ---
> > >  meta-oe/recipes-support/corosync/corosync_1.4.7.bb | 31
> > ++++++++++++++++++++++
> > >  .../corosync/files/config-site.corosync            |  4 +++
> > >  meta-oe/recipes-support/corosync/files/groff.patch | 12 +++++++++
> > >  3 files changed, 47 insertions(+)  create mode 100644 
> > > meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > >  create mode 100644
> > > meta-oe/recipes-support/corosync/files/config-site.corosync
> > >  create mode 100644
> > > meta-oe/recipes-support/corosync/files/groff.patch
> >
> > This probably belongs in meta-networking (unless there's strong 
> > opinion it belongs somewhere else).  Did you have a look at what has 
> > been done in meta-cgl (git://git.enea.com/linux/meta-cgl) with the 
> > recipe to see if there was anything useful there?  I know meta-cgl 
> > isn't very well publicized yet, but it is in the layer index.  If 
> > you haven't looked at what's there yet, it may be worth having a 
> > look to see if any of it can save you some time.
> >
> > For what it's worth, there does seem to be rather a lot more in 
> > meta-cgl and I think at least some of it still applies (eg. the 
> > volatiles
> file).
> >
> > > diff --git a/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > > b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > > new file mode 100644
> > > index 0000000..a3b8864
> > > --- /dev/null
> > > +++ b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > > @@ -0,0 +1,31 @@
> > > +SUMMARY = "The Corosync Cluster Engine and Application 
> > > +Programming
> > Interfaces"
> > > +DESCRIPTION = "This package contains the Corosync Cluster Engine 
> > > +Executive, several default \ APIs and libraries, default 
> > > +configuration
> > files, and an init script."
> > > +HOMEPAGE = "http://corosync.github.io/corosync/"
> > > +
> > > +inherit autotools pkgconfig
> > > +
> > > +SRC_URI =
> > "http://build.clusterlabs.org/corosync/releases/${BPN}-${PV}.tar.gz 
> > \
> > > +           file://config-site.corosync \
> > > +           file://groff.patch \
> > > +	   "
> >
> > Please remove the tab before space above.
> >
> > > +
> > > +SRC_URI[md5sum] = "da9b2cf0b55f08ac4cf7cd82ac2f977a"
> > > +SRC_URI[sha256sum] =
> > "c1d005b2093e9a725abd1dfb2be936114b561c0b3145aca11f58c1a733a05af8"
> > > +
> > > +LICENSE = "BSD"
> >
> > I think this is actually a BSD-3-Clause license, isn't it?
> >
> > > +LIC_FILES_CHKSUM =
> > "file://LICENSE;md5=25656171d1e4054c636a9893067f8c30"
> > > +
> > > +CONFIG_SITE = "${WORKDIR}/config-site.corosync"
> > > +
> > > +DEPENDS = "groff-native nss"
> > > +
> > > +EXTRA_OECONF += " --enable-nss "
> > > +CFLAGS_append += " -fPIC "
> > > +
> > > +do_compile() {
> > > +    DESCPATH="${STAGING_DATADIR_NATIVE}/groff/`groff -v | awk
> > '{if(NR==1)print $4}'`/font"
> > > +    oe_runmake DESCPATH=${DESCPATH} }
> > > +
> > > +FILES_${PN}-dbg += "${libexecdir}/lcrso/.debug"
> > > diff --git
> > > a/meta-oe/recipes-support/corosync/files/config-site.corosync
> > > b/meta-oe/recipes-support/corosync/files/config-site.corosync
> > > new file mode 100644
> > > index 0000000..3472dec
> > > --- /dev/null
> > > +++ b/meta-oe/recipes-support/corosync/files/config-site.corosync
> > > @@ -0,0 +1,4 @@
> > > +ac_cv_func_fnmatch_works=yes
> > > +ac_cv_func_malloc_0_nonnull=yes
> > > +ac_cv_func_realloc_0_nonnull=yes
> > > +
> > > diff --git a/meta-oe/recipes-support/corosync/files/groff.patch
> > > b/meta-oe/recipes-support/corosync/files/groff.patch
> >
> > Can you add a header to this patch please?
> >
> > Thanks.
> >
> > -J.
> >
> > > new file mode 100644
> > > index 0000000..da1378a
> > > --- /dev/null
> > > +++ b/meta-oe/recipes-support/corosync/files/groff.patch
> > > @@ -0,0 +1,12 @@
> > > +diff -Nurp corosync-1.3.1.org/man/Makefile.am
> > corosync-1.3.1/man/Makefile.am
> > > +--- corosync-1.3.1.org/man/Makefile.am	2011-04-25
> > 10:37:50.000000000 +0800
> > > ++++ corosync-1.3.1/man/Makefile.am	2014-11-24 10:33:36.583426707
> > +0800
> > > +@@ -126,7 +126,7 @@ HTML_DOCS = $(dist_man_MANS:%=%.html) 
> > > +INDEX_HTML = index.html
> > > +
> > > + %.html: %
> > > +-	$(GROFF) -mandoc -Thtml $^ > $@
> > > ++	$(GROFF) -F $(DESCPATH) -mandoc -Thtml $^ > $@
> > > +
> > > + install-data-local:
> > > + 	$(INSTALL) -d $(DESTDIR)/${docdir}/html
> > > --
> > > 1.9.1
> > >
> > --
> > -Joe MacDonald.
> > :wq
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

[-- Attachment #2: cgl-packages-list.txt --]
[-- Type: text/plain, Size: 564 bytes --]

acl
corosync
device-mapper-multipath
Device-mapper-multipath
dhcp
e2fsprogs
ext4
gcc
gdb
ipsec-tools
Ipsec-tools
iscsi-initiator-utils
kernel
kexec-tools
libevent
lksctp-tools
lm-sensors
LSB
lvm2
mdadm
monit
net-snmp
ntp
openais
openipmi
openssl
pacemaker
pam
quota
rpm
selinux
smartmontools
strongswan
syslog-ng
udev
vlan
kernel (+corresponding patches)

evlog
ifenslave
mipv6-daemon-umip
openl2tp
crash

drbd
grsecurity
logcheck
makedumpfile
numactl
ocfs2-tools
pam_passwdqc
samhain
ftrace
ltt-userspace

Re: [PATCH 6/6] [meta-oe] Port corosync from openembedded and upgrade to 1.4.7

[Joe MacDonald]

[-- Attachment #1: Type: text/plain, Size: 11063 bytes --]

[RE: [oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and upgrade to 1.4.7] On 14.11.26 (Wed 03:36) Bian, Naimeng wrote:

> > -----Original Message-----
> > From: openembedded-devel-bounces@lists.openembedded.org
> > [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
> > Alexandru Vaduva
> > Sent: Tuesday, November 25, 2014 6:19 PM
> > To: openembedded-devel@lists.openembedded.org; Joe MacDonald
> > Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and
> > upgrade to 1.4.7
> > 
> > It is my opinion that meta-cgl is the place for your patch being the fact that
> > pacemaker and the rest of the HA cluster resources are available here.
> 
> Thanks.
> I confirmed that corosync-1.2.8 and pacemaker are available inside meta-cgl.
> 
> > Also I believe this patch should be available inside the open embedded
> > repository.
> > 
> 
> Actually, I do not know what kinds of recipes meta-openembedded likes to merge.
> In another hand, what kinds of recipes are no good.
> (Of course the unmaintained one such as printproto is no good.)
> 
> If there are some rules, would you tell me what's that.
> Maybe it's helpful to a newcomer such as me. ^_^

I can't speak for everyone but in all honesty, where I do networking and
CGL stuff I see a lot of things that go 'unmaintained' for years and are
still perfectly functional and widely used.  Time since last commit
isn't an immediate disqualifier in my view.  That said, as I think was
mentioned with some of your other submissions, if you have a recipe for
a package that hasn't been maintained in several years, you should
expect to be asked "but why?"  There may be a very good answer to that
that convinces a layer maintainer to integrate your recipe.  You just
need to be prepared for the question.

For what it's worth, that can also apply to brand new packages.  :-)

> I got some points from the following document, but it's not detailed.
> http://www.openembedded.org/wiki/OpenEmbedded-Core#meta-openembedded
> 
> ----------------------------------------------------------------------------------
> meta-openembedded
> 
>   For items shared amongst multiple layers that do not fit into OE-Core or any other 
>  existing layer, there is the meta-oe layer. This exists in a repository, also called 
>  meta-openembedded, which contains a number of other more focused layers (meta-efl, 
>  meta-gnome, etc.). This layer will need to be managed carefully over time to avoid 
>  it turning into just a newer version of OE-classic.
> ----------------------------------------------------------------------------------

This last is the crux of the matter, I think.  I personally want to
avoid collecting a bunch of recipes that aren't regularly used and fall
out of date (either with the needs of the community or with the
upstream).

> Maybe we should update this document, add some suggestions like following.
> ----------------------------------------------------------------------------------
> Attention
>  Please avoid send a patch such as following.
>  1. have not been unmaintained by upstream long time
>  2. ... ...
> ----------------------------------------------------------------------------------
> 
> > If it would be ok with you I would suggest to have two patches: one sent for
> > the OpenEmbedded and one for the meta-cgl.
> > If the porting for meta-cgl would not be possible please let me know for assuring
> > that the patch is ported inside meta-cgl.
> 
> I confirmed that corosync-1.2.8 is available inside meta-cgl now.
> I will send the patch for corosync-1.4.7 to meta-cgl later.

That is probably best.  I have no objection to it being in
meta-networking, but I'm not sure it is broadly applicable and if Alex
prefers to keep a corosync recipe in meta-cgl, I'm all for that.

> > Another extra reason for which I would prefer this patch to be also available
> > inside meta-cgl would be the extra testing that will be done for it and the
> > fact that corosync messaging layer will be used with pacemaker.
> >
> 
> Looks good.
> And the same question.  ^_^
> Would you tell me what kinds of recipes meta-cgl likes to merge.

Alex gave you a pointer, I would also say if you're just asking in
general, you can have a look at what software packages are used by CGL
registered distributions here:

http://www.linuxfoundation.org/collaborate/workgroups/cgl/registered-distributions

and the specs, linked from the same page, if you really want to dig into
it.  The stated goal of meta-cgl is to provide a CGL layer for Yocto, so
I'd hazard a guess that anything that gets it closer to that goal in a
sensible fashion is welcome.

-J.

> 
> Regards
>  Bian
> 
> > 
> > Thank you,
> > Alex Vaduva
> > 
> > -----Original Message-----
> > From: openembedded-devel-bounces@lists.openembedded.org
> > [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Bian,
> > Naimeng
> > Sent: Tuesday, November 25, 2014 2:29 AM
> > To: Joe MacDonald
> > Cc: openembedded-devel@lists.openembedded.org
> > Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and
> > upgrade to 1.4.7
> > 
> > Hi Joe
> > 
> > Thanks for your advices.
> > I will look at meta-cgl.
> > 
> > Regards
> >  Bian
> > 
> > > -----Original Message-----
> > > From: Joe MacDonald [mailto:Joe_MacDonald@mentor.com]
> > > Sent: Tuesday, November 25, 2014 3:40 AM
> > > Cc: openembedded-devel@lists.openembedded.org
> > > Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from
> > > openembedded and upgrade to 1.4.7
> > >
> > > Hi Bian,
> > >
> > > [[oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and
> > > upgrade to 1.4.7] On 14.11.24 (Mon 14:45) Bian Naimeng wrote:
> > >
> > > > Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
> > > > ---
> > > >  meta-oe/recipes-support/corosync/corosync_1.4.7.bb | 31
> > > ++++++++++++++++++++++
> > > >  .../corosync/files/config-site.corosync            |  4 +++
> > > >  meta-oe/recipes-support/corosync/files/groff.patch | 12 +++++++++
> > > >  3 files changed, 47 insertions(+)
> > > >  create mode 100644
> > > > meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > > >  create mode 100644
> > > > meta-oe/recipes-support/corosync/files/config-site.corosync
> > > >  create mode 100644
> > > > meta-oe/recipes-support/corosync/files/groff.patch
> > >
> > > This probably belongs in meta-networking (unless there's strong
> > > opinion it belongs somewhere else).  Did you have a look at what has
> > > been done in meta-cgl (git://git.enea.com/linux/meta-cgl) with the
> > > recipe to see if there was anything useful there?  I know meta-cgl
> > > isn't very well publicized yet, but it is in the layer index.  If you
> > > haven't looked at what's there yet, it may be worth having a look to
> > > see if any of it can save you some time.
> > >
> > > For what it's worth, there does seem to be rather a lot more in
> > > meta-cgl and I think at least some of it still applies (eg. the volatiles
> > file).
> > >
> > > > diff --git a/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > > > b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > > > new file mode 100644
> > > > index 0000000..a3b8864
> > > > --- /dev/null
> > > > +++ b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > > > @@ -0,0 +1,31 @@
> > > > +SUMMARY = "The Corosync Cluster Engine and Application Programming
> > > Interfaces"
> > > > +DESCRIPTION = "This package contains the Corosync Cluster Engine
> > > > +Executive, several default ¥ APIs and libraries, default
> > > > +configuration
> > > files, and an init script."
> > > > +HOMEPAGE = "http://corosync.github.io/corosync/"
> > > > +
> > > > +inherit autotools pkgconfig
> > > > +
> > > > +SRC_URI =
> > > "http://build.clusterlabs.org/corosync/releases/${BPN}-${PV}.tar.gz ¥
> > > > +           file://config-site.corosync ¥
> > > > +           file://groff.patch ¥
> > > > +	   "
> > >
> > > Please remove the tab before space above.
> > >
> > > > +
> > > > +SRC_URI[md5sum] = "da9b2cf0b55f08ac4cf7cd82ac2f977a"
> > > > +SRC_URI[sha256sum] =
> > > "c1d005b2093e9a725abd1dfb2be936114b561c0b3145aca11f58c1a733a05af8"
> > > > +
> > > > +LICENSE = "BSD"
> > >
> > > I think this is actually a BSD-3-Clause license, isn't it?
> > >
> > > > +LIC_FILES_CHKSUM =
> > > "file://LICENSE;md5=25656171d1e4054c636a9893067f8c30"
> > > > +
> > > > +CONFIG_SITE = "${WORKDIR}/config-site.corosync"
> > > > +
> > > > +DEPENDS = "groff-native nss"
> > > > +
> > > > +EXTRA_OECONF += " --enable-nss "
> > > > +CFLAGS_append += " -fPIC "
> > > > +
> > > > +do_compile() {
> > > > +    DESCPATH="${STAGING_DATADIR_NATIVE}/groff/`groff -v | awk
> > > '{if(NR==1)print $4}'`/font"
> > > > +    oe_runmake DESCPATH=${DESCPATH} }
> > > > +
> > > > +FILES_${PN}-dbg += "${libexecdir}/lcrso/.debug"
> > > > diff --git
> > > > a/meta-oe/recipes-support/corosync/files/config-site.corosync
> > > > b/meta-oe/recipes-support/corosync/files/config-site.corosync
> > > > new file mode 100644
> > > > index 0000000..3472dec
> > > > --- /dev/null
> > > > +++ b/meta-oe/recipes-support/corosync/files/config-site.corosync
> > > > @@ -0,0 +1,4 @@
> > > > +ac_cv_func_fnmatch_works=yes
> > > > +ac_cv_func_malloc_0_nonnull=yes
> > > > +ac_cv_func_realloc_0_nonnull=yes
> > > > +
> > > > diff --git a/meta-oe/recipes-support/corosync/files/groff.patch
> > > > b/meta-oe/recipes-support/corosync/files/groff.patch
> > >
> > > Can you add a header to this patch please?
> > >
> > > Thanks.
> > >
> > > -J.
> > >
> > > > new file mode 100644
> > > > index 0000000..da1378a
> > > > --- /dev/null
> > > > +++ b/meta-oe/recipes-support/corosync/files/groff.patch
> > > > @@ -0,0 +1,12 @@
> > > > +diff -Nurp corosync-1.3.1.org/man/Makefile.am
> > > corosync-1.3.1/man/Makefile.am
> > > > +--- corosync-1.3.1.org/man/Makefile.am	2011-04-25
> > > 10:37:50.000000000 +0800
> > > > ++++ corosync-1.3.1/man/Makefile.am	2014-11-24 10:33:36.583426707
> > > +0800
> > > > +@@ -126,7 +126,7 @@ HTML_DOCS = $(dist_man_MANS:%=%.html)
> > > > +INDEX_HTML = index.html
> > > > +
> > > > + %.html: %
> > > > +-	$(GROFF) -mandoc -Thtml $^ > $@
> > > > ++	$(GROFF) -F $(DESCPATH) -mandoc -Thtml $^ > $@
> > > > +
> > > > + install-data-local:
> > > > + 	$(INSTALL) -d $(DESTDIR)/${docdir}/html
> > > > --
> > > > 1.9.1
> > > >
> > > --
> > > -Joe MacDonald.
> > > :wq
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 501 bytes --]

Re: [PATCH 6/6] [meta-oe] Port corosync from openembedded and upgrade to 1.4.7

[Alexandru Vaduva]

-----Original Message-----
From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Joe MacDonald
Sent: Wednesday, November 26, 2014 4:08 PM
To: Bian, Naimeng
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and upgrade to 1.4.7

[RE: [oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and upgrade to 1.4.7] On 14.11.26 (Wed 03:36) Bian, Naimeng wrote:

> > -----Original Message-----
> > From: openembedded-devel-bounces@lists.openembedded.org
> > [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf 
> > Of Alexandru Vaduva
> > Sent: Tuesday, November 25, 2014 6:19 PM
> > To: openembedded-devel@lists.openembedded.org; Joe MacDonald
> > Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from 
> > openembedded and upgrade to 1.4.7
> > 
> > It is my opinion that meta-cgl is the place for your patch being the 
> > fact that pacemaker and the rest of the HA cluster resources are available here.
> 
> Thanks.
> I confirmed that corosync-1.2.8 and pacemaker are available inside meta-cgl.
> 
> > Also I believe this patch should be available inside the open 
> > embedded repository.
> > 
> 
> Actually, I do not know what kinds of recipes meta-openembedded likes to merge.
> In another hand, what kinds of recipes are no good.
> (Of course the unmaintained one such as printproto is no good.)
> 
> If there are some rules, would you tell me what's that.
> Maybe it's helpful to a newcomer such as me. ^_^

I can't speak for everyone but in all honesty, where I do networking and CGL stuff I see a lot of things that go 'unmaintained' for years and are still perfectly functional and widely used.  Time since last commit isn't an immediate disqualifier in my view.  That said, as I think was mentioned with some of your other submissions, if you have a recipe for a package that hasn't been maintained in several years, you should expect to be asked "but why?"  There may be a very good answer to that that convinces a layer maintainer to integrate your recipe.  You just need to be prepared for the question.

For what it's worth, that can also apply to brand new packages.  :-)

> I got some points from the following document, but it's not detailed.
> http://www.openembedded.org/wiki/OpenEmbedded-Core#meta-openembedded
> 
> ----------------------------------------------------------------------
> ------------
> meta-openembedded
> 
>   For items shared amongst multiple layers that do not fit into 
> OE-Core or any other  existing layer, there is the meta-oe layer. This 
> exists in a repository, also called  meta-openembedded, which contains 
> a number of other more focused layers (meta-efl,  meta-gnome, etc.). 
> This layer will need to be managed carefully over time to avoid  it turning into just a newer version of OE-classic.
> ----------------------------------------------------------------------
> ------------

This last is the crux of the matter, I think.  I personally want to avoid collecting a bunch of recipes that aren't regularly used and fall out of date (either with the needs of the community or with the upstream).

> Maybe we should update this document, add some suggestions like following.
> ----------------------------------------------------------------------
> ------------
> Attention
>  Please avoid send a patch such as following.
>  1. have not been unmaintained by upstream long time  2. ... ...
> ----------------------------------------------------------------------
> ------------
> 
> > If it would be ok with you I would suggest to have two patches: one 
> > sent for the OpenEmbedded and one for the meta-cgl.
> > If the porting for meta-cgl would not be possible please let me know 
> > for assuring that the patch is ported inside meta-cgl.
> 
> I confirmed that corosync-1.2.8 is available inside meta-cgl now.
> I will send the patch for corosync-1.4.7 to meta-cgl later.

That is probably best.  I have no objection to it being in meta-networking, but I'm not sure it is broadly applicable and if Alex prefers to keep a corosync recipe in meta-cgl, I'm all for that.

> > Another extra reason for which I would prefer this patch to be also 
> > available inside meta-cgl would be the extra testing that will be 
> > done for it and the fact that corosync messaging layer will be used with pacemaker.
> >
> 
> Looks good.
> And the same question.  ^_^
> Would you tell me what kinds of recipes meta-cgl likes to merge.

Alex gave you a pointer, I would also say if you're just asking in general, you can have a look at what software packages are used by CGL registered distributions here:

http://www.linuxfoundation.org/collaborate/workgroups/cgl/registered-distributions

and the specs, linked from the same page, if you really want to dig into it.  The stated goal of meta-cgl is to provide a CGL layer for Yocto, so I'd hazard a guess that anything that gets it closer to that goal in a sensible fashion is welcome.

-J.

Thanks Joe, I forgot to also point the registered distributions, they are a good source of inspiration.
Also you are perfectly right with this affirmation. 

> 
> Regards
>  Bian
> 
> > 
> > Thank you,
> > Alex Vaduva
> > 
> > -----Original Message-----
> > From: openembedded-devel-bounces@lists.openembedded.org
> > [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf 
> > Of Bian, Naimeng
> > Sent: Tuesday, November 25, 2014 2:29 AM
> > To: Joe MacDonald
> > Cc: openembedded-devel@lists.openembedded.org
> > Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from 
> > openembedded and upgrade to 1.4.7
> > 
> > Hi Joe
> > 
> > Thanks for your advices.
> > I will look at meta-cgl.
> > 
> > Regards
> >  Bian
> > 
> > > -----Original Message-----
> > > From: Joe MacDonald [mailto:Joe_MacDonald@mentor.com]
> > > Sent: Tuesday, November 25, 2014 3:40 AM
> > > Cc: openembedded-devel@lists.openembedded.org
> > > Subject: Re: [oe] [PATCH 6/6] [meta-oe] Port corosync from 
> > > openembedded and upgrade to 1.4.7
> > >
> > > Hi Bian,
> > >
> > > [[oe] [PATCH 6/6] [meta-oe] Port corosync from openembedded and 
> > > upgrade to 1.4.7] On 14.11.24 (Mon 14:45) Bian Naimeng wrote:
> > >
> > > > Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
> > > > ---
> > > >  meta-oe/recipes-support/corosync/corosync_1.4.7.bb | 31
> > > ++++++++++++++++++++++
> > > >  .../corosync/files/config-site.corosync            |  4 +++
> > > >  meta-oe/recipes-support/corosync/files/groff.patch | 12 
> > > > +++++++++
> > > >  3 files changed, 47 insertions(+)  create mode 100644 
> > > > meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > > >  create mode 100644
> > > > meta-oe/recipes-support/corosync/files/config-site.corosync
> > > >  create mode 100644
> > > > meta-oe/recipes-support/corosync/files/groff.patch
> > >
> > > This probably belongs in meta-networking (unless there's strong 
> > > opinion it belongs somewhere else).  Did you have a look at what 
> > > has been done in meta-cgl (git://git.enea.com/linux/meta-cgl) with 
> > > the recipe to see if there was anything useful there?  I know 
> > > meta-cgl isn't very well publicized yet, but it is in the layer 
> > > index.  If you haven't looked at what's there yet, it may be worth 
> > > having a look to see if any of it can save you some time.
> > >
> > > For what it's worth, there does seem to be rather a lot more in 
> > > meta-cgl and I think at least some of it still applies (eg. the 
> > > volatiles
> > file).
> > >
> > > > diff --git a/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > > > b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > > > new file mode 100644
> > > > index 0000000..a3b8864
> > > > --- /dev/null
> > > > +++ b/meta-oe/recipes-support/corosync/corosync_1.4.7.bb
> > > > @@ -0,0 +1,31 @@
> > > > +SUMMARY = "The Corosync Cluster Engine and Application 
> > > > +Programming
> > > Interfaces"
> > > > +DESCRIPTION = "This package contains the Corosync Cluster 
> > > > +Engine Executive, several default ¥ APIs and libraries, default 
> > > > +configuration
> > > files, and an init script."
> > > > +HOMEPAGE = "http://corosync.github.io/corosync/"
> > > > +
> > > > +inherit autotools pkgconfig
> > > > +
> > > > +SRC_URI =
> > > "http://build.clusterlabs.org/corosync/releases/${BPN}-${PV}.tar.g
> > > z ¥
> > > > +           file://config-site.corosync ¥
> > > > +           file://groff.patch ¥
> > > > +	   "
> > >
> > > Please remove the tab before space above.
> > >
> > > > +
> > > > +SRC_URI[md5sum] = "da9b2cf0b55f08ac4cf7cd82ac2f977a"
> > > > +SRC_URI[sha256sum] =
> > > "c1d005b2093e9a725abd1dfb2be936114b561c0b3145aca11f58c1a733a05af8"
> > > > +
> > > > +LICENSE = "BSD"
> > >
> > > I think this is actually a BSD-3-Clause license, isn't it?
> > >
> > > > +LIC_FILES_CHKSUM =
> > > "file://LICENSE;md5=25656171d1e4054c636a9893067f8c30"
> > > > +
> > > > +CONFIG_SITE = "${WORKDIR}/config-site.corosync"
> > > > +
> > > > +DEPENDS = "groff-native nss"
> > > > +
> > > > +EXTRA_OECONF += " --enable-nss "
> > > > +CFLAGS_append += " -fPIC "
> > > > +
> > > > +do_compile() {
> > > > +    DESCPATH="${STAGING_DATADIR_NATIVE}/groff/`groff -v | awk
> > > '{if(NR==1)print $4}'`/font"
> > > > +    oe_runmake DESCPATH=${DESCPATH} }
> > > > +
> > > > +FILES_${PN}-dbg += "${libexecdir}/lcrso/.debug"
> > > > diff --git
> > > > a/meta-oe/recipes-support/corosync/files/config-site.corosync
> > > > b/meta-oe/recipes-support/corosync/files/config-site.corosync
> > > > new file mode 100644
> > > > index 0000000..3472dec
> > > > --- /dev/null
> > > > +++ b/meta-oe/recipes-support/corosync/files/config-site.corosyn
> > > > +++ c
> > > > @@ -0,0 +1,4 @@
> > > > +ac_cv_func_fnmatch_works=yes
> > > > +ac_cv_func_malloc_0_nonnull=yes 
> > > > +ac_cv_func_realloc_0_nonnull=yes
> > > > +
> > > > diff --git a/meta-oe/recipes-support/corosync/files/groff.patch
> > > > b/meta-oe/recipes-support/corosync/files/groff.patch
> > >
> > > Can you add a header to this patch please?
> > >
> > > Thanks.
> > >
> > > -J.
> > >
> > > > new file mode 100644
> > > > index 0000000..da1378a
> > > > --- /dev/null
> > > > +++ b/meta-oe/recipes-support/corosync/files/groff.patch
> > > > @@ -0,0 +1,12 @@
> > > > +diff -Nurp corosync-1.3.1.org/man/Makefile.am
> > > corosync-1.3.1/man/Makefile.am
> > > > +--- corosync-1.3.1.org/man/Makefile.am	2011-04-25
> > > 10:37:50.000000000 +0800
> > > > ++++ corosync-1.3.1/man/Makefile.am	2014-11-24 10:33:36.583426707
> > > +0800
> > > > +@@ -126,7 +126,7 @@ HTML_DOCS = $(dist_man_MANS:%=%.html) 
> > > > +INDEX_HTML = index.html
> > > > +
> > > > + %.html: %
> > > > +-	$(GROFF) -mandoc -Thtml $^ > $@
> > > > ++	$(GROFF) -F $(DESCPATH) -mandoc -Thtml $^ > $@
> > > > +
> > > > + install-data-local:
> > > > + 	$(INSTALL) -d $(DESTDIR)/${docdir}/html
> > > > --
> > > > 1.9.1
> > > >
> > > --
> > > -Joe MacDonald.
> > > :wq
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
-Joe MacDonald.
:wq