All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel.a@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Igor Mammedov <imammedo@redhat.com>,
	Zhu Guihua <zhugh.fnst@cn.fujitsu.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion
Date: Thu, 27 Nov 2014 16:49:56 +0200	[thread overview]
Message-ID: <1417099796.2807.41.camel@localhost.localdomain> (raw)
In-Reply-To: <CAFEAcA954hhRVhiWzUQ6OYi=kCbRHmAJPx_Cdj-6LyQ1hwQXXw@mail.gmail.com>

On Thu, 2014-11-27 at 14:13 +0000, Peter Maydell wrote:
> On 27 November 2014 at 11:41, Marcel Apfelbaum <marcel.a@redhat.com> wrote:
> > I was talking about something different:
> > A hot-pluggable device that was not hot-plugged is assumed to be hot-unpluggable.
> > This is not true for pci-2-pci device.
> >
> > But this is another issue and can wait for 2.3.
> > So you patch was *almost* correct for looking hotpluggable devices,
> > the only problem we have is with pci-2-pci bridge (, and maybe with others that I don't know).
> 
> So, to be clear, the effect of this is just that our autocompletion
> will suggest a completion to the command which will fail if actually
> executed, right? That doesn't sound very serious, so I would be happy
> to postpone it to 2.3.
Correct. But only if this patch is applied, before this patch is a QEMU
crash.

Please pull it to solve the crash and we will deal with the other issues on 2.3

Thanks,
Marcel
> 
> -- PMM

  reply	other threads:[~2014-11-27 14:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 11:50 [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del auto-completion Marcel Apfelbaum
2014-11-26 12:21 ` Igor Mammedov
2014-11-26 18:05 ` Luiz Capitulino
2014-11-26 19:09   ` Peter Maydell
2014-11-26 19:32   ` Marcel Apfelbaum
2014-11-27 11:11   ` Marcel Apfelbaum
2014-11-27 11:26     ` Marcel Apfelbaum
2014-11-27 11:35     ` Zhu Guihua
2014-11-27 11:41       ` Marcel Apfelbaum
2014-11-27 12:08         ` Zhu Guihua
2014-11-27 12:15           ` Marcel Apfelbaum
2014-11-28  1:23             ` Zhu Guihua
2014-11-27 12:38         ` Igor Mammedov
2014-11-27 13:48           ` Marcel Apfelbaum
2014-11-28  1:50             ` Zhu Guihua
2014-11-28  5:53               ` Marcel Apfelbaum
2014-11-28 14:33                 ` Igor Mammedov
2014-11-27 14:04         ` Luiz Capitulino
2014-11-27 14:13         ` Peter Maydell
2014-11-27 14:49           ` Marcel Apfelbaum [this message]
2014-11-27 15:53 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417099796.2807.41.camel@localhost.localdomain \
    --to=marcel.a@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zhugh.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.