From: Joe Perches <joe@perches.com>
To: "Peter Hüwe" <PeterHuewe@gmx.de>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
tpmdd-devel@lists.sourceforge.net,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
christophe.ricard@gmail.com, josh.triplett@intel.com,
linux-api@vger.kernel.org, Ashley Lai <ashley@ashleylai.com>,
linux-kernel@vger.kernel.org,
jason.gunthorpe@obsidianresearch.com,
trousers-tech@lists.sourceforge.net
Subject: Re: [tpmdd-devel] [PATCH v8 0/8] TPM 2.0 support
Date: Tue, 02 Dec 2014 15:48:35 -0800 [thread overview]
Message-ID: <1417564115.2902.8.camel@perches.com> (raw)
In-Reply-To: <201412030033.56705.PeterHuewe@gmx.de>
On Wed, 2014-12-03 at 00:33 +0100, Peter Hüwe wrote:
> Am Mittwoch, 3. Dezember 2014, 00:24:43 schrieb Aaro Koskinen:
> > On Wed, Dec 03, 2014 at 12:21:07AM +0100, Peter Hüwe wrote:
> > > --- a/drivers/char/tpm/tpm_i2c_nuvoton.c
> > > +++ b/drivers/char/tpm/tpm_i2c_nuvoton.c
> > > @@ -605,10 +605,8 @@ static int i2c_nuvoton_probe(struct i2c_client
> > > *client,
> > >
> > > return -ENODEV;
> > >
> > > rc = tpm_chip_register(chip);
> > >
> > > - if (rc)
> > > - return rc;
> > >
> > > - return 0;
> > > + return rc;
> >
> > Maybe just return tpm_chip_register(chip)?
>
> Even better.
The pattern:
foo = bar();
if (foo)
return foo;
return 0;
is fairly common.
There are a few hundred in the kernel.
$ grep-2.5.4 -nrP --include=*.[ch] "\b(\w+)\s*=\s*[^;]*;\s*if\s*\(\s*\1\s*\)\s*return\s*\1\s*;\s*return\s*0;" * | \
grep -oP '^.+:\d+:' | \
wc -l
308
next prev parent reply other threads:[~2014-12-02 23:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 22:31 [PATCH v8 0/8] TPM 2.0 support Jarkko Sakkinen
2014-12-02 22:31 ` Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 1/8] tpm: merge duplicate transmit_cmd() functions Jarkko Sakkinen
2014-12-02 22:31 ` Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 2/8] tpm: two-phase chip management functions Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 3/8] tpm: fix raciness of PPI interface lookup Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 4/8] tpm: rename chip->dev to chip->pdev Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 5/8] tpm: device class for tpm Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 6/8] tpm: TPM 2.0 baseline support Jarkko Sakkinen
2014-12-03 2:21 ` [tpmdd-devel] " Stefan Berger
2014-12-03 2:21 ` Stefan Berger
2014-12-03 2:28 ` Stefan Berger
2014-12-04 23:13 ` Peter Hüwe
2014-12-04 23:13 ` Peter Hüwe
2014-12-08 13:56 ` Jarkko Sakkinen
2014-12-08 13:56 ` Jarkko Sakkinen
2014-12-08 16:18 ` peterhuewe
2014-12-08 16:18 ` peterhuewe-Mmb7MZpHnFY
2014-12-02 22:31 ` [PATCH v8 7/8] tpm: TPM 2.0 CRB Interface Jarkko Sakkinen
2014-12-02 23:07 ` [tpmdd-devel] " Stefan Berger
2014-12-02 23:07 ` Stefan Berger
2014-12-02 23:10 ` Peter Hüwe
2014-12-02 22:31 ` [PATCH v8 8/8] tpm: TPM 2.0 FIFO Interface Jarkko Sakkinen
2014-12-02 22:55 ` [PATCH v8 0/8] TPM 2.0 support Peter Hüwe
2014-12-02 22:55 ` Peter Hüwe
2014-12-03 10:10 ` Jarkko Sakkinen
2014-12-03 10:10 ` Jarkko Sakkinen
2014-12-02 23:16 ` Peter Hüwe
2014-12-02 23:16 ` Peter Hüwe
2014-12-02 23:21 ` [tpmdd-devel] " Peter Hüwe
2014-12-02 23:21 ` Peter Hüwe
2014-12-02 23:24 ` Aaro Koskinen
2014-12-02 23:24 ` Aaro Koskinen
2014-12-02 23:33 ` Peter Hüwe
2014-12-02 23:33 ` Peter Hüwe
2014-12-02 23:48 ` Joe Perches [this message]
2014-12-03 0:03 ` Thomas Gleixner
2014-12-03 0:03 ` Thomas Gleixner
2014-12-04 5:52 ` Jarkko Sakkinen
2014-12-04 5:52 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417564115.2902.8.camel@perches.com \
--to=joe@perches.com \
--cc=PeterHuewe@gmx.de \
--cc=aaro.koskinen@iki.fi \
--cc=ashley@ashleylai.com \
--cc=christophe.ricard@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jason.gunthorpe@obsidianresearch.com \
--cc=josh.triplett@intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=trousers-tech@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.