From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Peter Huewe <peterhuewe@gmx.de>,
Ashley Lai <ashley@ashleylai.com>,
Marcel Selhorst <tpmdd@selhorst.net>
Cc: christophe.ricard@gmail.com, josh.triplett@intel.com,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
tpmdd-devel@lists.sourceforge.net,
jason.gunthorpe@obsidianresearch.com,
trousers-tech@lists.sourceforge.net
Subject: Re: [tpmdd-devel] [PATCH v8 7/8] tpm: TPM 2.0 CRB Interface
Date: Tue, 02 Dec 2014 18:07:16 -0500 [thread overview]
Message-ID: <547E4624.8060206@linux.vnet.ibm.com> (raw)
In-Reply-To: <1417559480-13757-8-git-send-email-jarkko.sakkinen@linux.intel.com>
On 12/02/2014 05:31 PM, Jarkko Sakkinen wrote:
> +struct acpi_tpm2 {
> + struct acpi_table_header hdr;
> + u16 platform_class;
> + u16 reserved;
> + u64 control_area_pa;
> + u32 start_method;
> +} __packed;
[...]
> + }
> +
> + if (buf->hdr.length != sizeof(struct acpi_tpm2)) {
This should be
if (buf->hdr.length < sizeof(struct acpi_tpm2)) {
since the ACPI TPM2 table may have a variable number of 'Platform
Specific Parameters' beyond the 'Start Method Field'. What we don't want
to have is less, but more is fine.
Stefan
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Berger <stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Jarkko Sakkinen
<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Peter Huewe <peterhuewe-Mmb7MZpHnFY@public.gmane.org>,
Ashley Lai <ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org>,
Marcel Selhorst <tpmdd-yWjUBOtONefk1uMJSBkQmQ@public.gmane.org>
Cc: christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
josh.triplett-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
jason.gunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org,
trousers-tech-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [tpmdd-devel] [PATCH v8 7/8] tpm: TPM 2.0 CRB Interface
Date: Tue, 02 Dec 2014 18:07:16 -0500 [thread overview]
Message-ID: <547E4624.8060206@linux.vnet.ibm.com> (raw)
In-Reply-To: <1417559480-13757-8-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
On 12/02/2014 05:31 PM, Jarkko Sakkinen wrote:
> +struct acpi_tpm2 {
> + struct acpi_table_header hdr;
> + u16 platform_class;
> + u16 reserved;
> + u64 control_area_pa;
> + u32 start_method;
> +} __packed;
[...]
> + }
> +
> + if (buf->hdr.length != sizeof(struct acpi_tpm2)) {
This should be
if (buf->hdr.length < sizeof(struct acpi_tpm2)) {
since the ACPI TPM2 table may have a variable number of 'Platform
Specific Parameters' beyond the 'Start Method Field'. What we don't want
to have is less, but more is fine.
Stefan
next prev parent reply other threads:[~2014-12-02 23:09 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 22:31 [PATCH v8 0/8] TPM 2.0 support Jarkko Sakkinen
2014-12-02 22:31 ` Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 1/8] tpm: merge duplicate transmit_cmd() functions Jarkko Sakkinen
2014-12-02 22:31 ` Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 2/8] tpm: two-phase chip management functions Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 3/8] tpm: fix raciness of PPI interface lookup Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 4/8] tpm: rename chip->dev to chip->pdev Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 5/8] tpm: device class for tpm Jarkko Sakkinen
2014-12-02 22:31 ` [PATCH v8 6/8] tpm: TPM 2.0 baseline support Jarkko Sakkinen
2014-12-03 2:21 ` [tpmdd-devel] " Stefan Berger
2014-12-03 2:21 ` Stefan Berger
2014-12-03 2:28 ` Stefan Berger
2014-12-04 23:13 ` Peter Hüwe
2014-12-04 23:13 ` Peter Hüwe
2014-12-08 13:56 ` Jarkko Sakkinen
2014-12-08 13:56 ` Jarkko Sakkinen
2014-12-08 16:18 ` peterhuewe
2014-12-08 16:18 ` peterhuewe-Mmb7MZpHnFY
2014-12-02 22:31 ` [PATCH v8 7/8] tpm: TPM 2.0 CRB Interface Jarkko Sakkinen
2014-12-02 23:07 ` Stefan Berger [this message]
2014-12-02 23:07 ` [tpmdd-devel] " Stefan Berger
2014-12-02 23:10 ` Peter Hüwe
2014-12-02 22:31 ` [PATCH v8 8/8] tpm: TPM 2.0 FIFO Interface Jarkko Sakkinen
2014-12-02 22:55 ` [PATCH v8 0/8] TPM 2.0 support Peter Hüwe
2014-12-02 22:55 ` Peter Hüwe
2014-12-03 10:10 ` Jarkko Sakkinen
2014-12-03 10:10 ` Jarkko Sakkinen
2014-12-02 23:16 ` Peter Hüwe
2014-12-02 23:16 ` Peter Hüwe
2014-12-02 23:21 ` [tpmdd-devel] " Peter Hüwe
2014-12-02 23:21 ` Peter Hüwe
2014-12-02 23:24 ` Aaro Koskinen
2014-12-02 23:24 ` Aaro Koskinen
2014-12-02 23:33 ` Peter Hüwe
2014-12-02 23:33 ` Peter Hüwe
2014-12-02 23:48 ` Joe Perches
2014-12-03 0:03 ` Thomas Gleixner
2014-12-03 0:03 ` Thomas Gleixner
2014-12-04 5:52 ` Jarkko Sakkinen
2014-12-04 5:52 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547E4624.8060206@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=ashley@ashleylai.com \
--cc=christophe.ricard@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jason.gunthorpe@obsidianresearch.com \
--cc=josh.triplett@intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
--cc=trousers-tech@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.