[PATCH 1/3] ARM: pxa: add regulator_has_full_constraints to corgi board file

[PATCH 1/3] ARM: pxa: add regulator_has_full_constraints to corgi board file

[Dmitry Eremin-Solenikov]

Add regulator_has_full_constraints() call to corgi board file to let
regulator core know that we do not have any additional regulators left.
This lets it substitute unprovided regulators with dummy ones.

This fixes the following warnings that can be seen on corgi if
regulators are enabled:

ads7846 spi1.0: unable to get regulator: -517
spi spi1.0: Driver ads7846 requests probe deferral
wm8731 0-001b: Failed to get supply 'AVDD': -517
wm8731 0-001b: Failed to request supplies: -517
wm8731 0-001b: ASoC: failed to probe component -517
corgi-audio corgi-audio: ASoC: failed to instantiate card -517

Cc: stable at vger.kernel.org
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 arch/arm/mach-pxa/corgi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/mach-pxa/corgi.c b/arch/arm/mach-pxa/corgi.c
index 06022b2..89f790d 100644
--- a/arch/arm/mach-pxa/corgi.c
+++ b/arch/arm/mach-pxa/corgi.c
@@ -26,6 +26,7 @@
 #include <linux/i2c.h>
 #include <linux/i2c/pxa-i2c.h>
 #include <linux/io.h>
+#include <linux/regulator/machine.h>
 #include <linux/spi/spi.h>
 #include <linux/spi/ads7846.h>
 #include <linux/spi/corgi_lcd.h>
@@ -752,6 +753,8 @@ static void __init corgi_init(void)
 		sharpsl_nand_partitions[1].size = 53 * 1024 * 1024;
 
 	platform_add_devices(devices, ARRAY_SIZE(devices));
+
+	regulator_has_full_constraints();
 }
 
 static void __init fixup_corgi(struct tag *tags, char **cmdline)
-- 
2.1.3

[PATCH 2/3] ARM: pxa: add regulator_has_full_constraints to poodle board file

[Dmitry Eremin-Solenikov]

Add regulator_has_full_constraints() call to poodle board file to let
regulator core know that we do not have any additional regulators left.
This lets it substitute unprovided regulators with dummy ones.

This fixes the following warnings that can be seen on poodle if
regulators are enabled:

ads7846 spi1.0: unable to get regulator: -517
spi spi1.0: Driver ads7846 requests probe deferral
wm8731 0-001b: Failed to get supply 'AVDD': -517
wm8731 0-001b: Failed to request supplies: -517
wm8731 0-001b: ASoC: failed to probe component -517

Cc: stable at vger.kernel.org
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 arch/arm/mach-pxa/poodle.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-pxa/poodle.c b/arch/arm/mach-pxa/poodle.c
index 1319916..e81d216 100644
--- a/arch/arm/mach-pxa/poodle.c
+++ b/arch/arm/mach-pxa/poodle.c
@@ -25,6 +25,7 @@
 #include <linux/gpio.h>
 #include <linux/i2c.h>
 #include <linux/i2c/pxa-i2c.h>
+#include <linux/regulator/machine.h>
 #include <linux/spi/spi.h>
 #include <linux/spi/ads7846.h>
 #include <linux/spi/pxa2xx_spi.h>
@@ -455,6 +456,7 @@ static void __init poodle_init(void)
 	pxa_set_i2c_info(NULL);
 	i2c_register_board_info(0, ARRAY_AND_SIZE(poodle_i2c_devices));
 	poodle_init_spi();
+	regulator_has_full_constraints();
 }
 
 static void __init fixup_poodle(struct tag *tags, char **cmdline)
-- 
2.1.3

[PATCH 3/3] ARM: pxa: add regulator_has_full_constraints to spitz board file

[Dmitry Eremin-Solenikov]

Add regulator_has_full_constraints() call to spitz board file to let
regulator core know that we do not have any additional regulators left.
This lets it substitute unprovided regulators with dummy ones.

This fixes the following warnings that can be seen on spitz if
regulators are enabled:

ads7846 spi2.0: unable to get regulator: -517
spi spi2.0: Driver ads7846 requests probe deferral

Cc: stable at vger.kernel.org
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 arch/arm/mach-pxa/spitz.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-pxa/spitz.c b/arch/arm/mach-pxa/spitz.c
index 840c3a4..f4f713b 100644
--- a/arch/arm/mach-pxa/spitz.c
+++ b/arch/arm/mach-pxa/spitz.c
@@ -970,6 +970,8 @@ static void __init spitz_init(void)
 	spitz_nor_init();
 	spitz_nand_init();
 	spitz_i2c_init();
+
+	regulator_has_full_constraints();
 }
 
 static void __init spitz_fixup(struct tag *tags, char **cmdline)
-- 
2.1.3

[PATCH 1/3] ARM: pxa: add regulator_has_full_constraints to corgi board file

[Robert Jarzmik]

Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> writes:

> Add regulator_has_full_constraints() call to corgi board file to let
> regulator core know that we do not have any additional regulators left.
> This lets it substitute unprovided regulators with dummy ones.
>
> This fixes the following warnings that can be seen on corgi if
> regulators are enabled:
>
> ads7846 spi1.0: unable to get regulator: -517
> spi spi1.0: Driver ads7846 requests probe deferral
> wm8731 0-001b: Failed to get supply 'AVDD': -517
> wm8731 0-001b: Failed to request supplies: -517
> wm8731 0-001b: ASoC: failed to probe component -517
> corgi-audio corgi-audio: ASoC: failed to instantiate card -517
>
> Cc: stable at vger.kernel.org
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
>  arch/arm/mach-pxa/corgi.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mach-pxa/corgi.c b/arch/arm/mach-pxa/corgi.c
> index 06022b2..89f790d 100644
> --- a/arch/arm/mach-pxa/corgi.c
> +++ b/arch/arm/mach-pxa/corgi.c
> @@ -26,6 +26,7 @@
>  #include <linux/i2c.h>
>  #include <linux/i2c/pxa-i2c.h>
>  #include <linux/io.h>
> +#include <linux/regulator/machine.h>
>  #include <linux/spi/spi.h>
>  #include <linux/spi/ads7846.h>
>  #include <linux/spi/corgi_lcd.h>
> @@ -752,6 +753,8 @@ static void __init corgi_init(void)
>  		sharpsl_nand_partitions[1].size = 53 * 1024 * 1024;
>  
>  	platform_add_devices(devices, ARRAY_SIZE(devices));
> +
> +	regulator_has_full_constraints();
>  }
>  
>  static void __init fixup_corgi(struct tag *tags, char **cmdline)

Added Mark for review, as I was thinking regulator_has_full_constraints() was to
be used to disable unused regulators, a bit like in the clock framework, rather
than provide a way to provide automatically dummy regulators.

If Mark acks, I'll take the serie.

-- 
Robert

[PATCH 1/3] ARM: pxa: add regulator_has_full_constraints to corgi board file

[Mark Brown]

On Thu, Dec 04, 2014 at 09:41:45PM +0100, Robert Jarzmik wrote:
> Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> writes:

> > +	regulator_has_full_constraints();

> Added Mark for review, as I was thinking regulator_has_full_constraints() was to
> be used to disable unused regulators, a bit like in the clock framework, rather
> than provide a way to provide automatically dummy regulators.

> If Mark acks, I'll take the serie.

It's both, it's telling the core that the board has told it about all
the regulator mappings it's ever going to tell it about.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141204/a6120d72/attachment.sig>

[PATCH 1/3] ARM: pxa: add regulator_has_full_constraints to corgi board file

[Robert Jarzmik]

Mark Brown <broonie@kernel.org> writes:

> On Thu, Dec 04, 2014 at 09:41:45PM +0100, Robert Jarzmik wrote:
>> Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> writes:
>
>> > +	regulator_has_full_constraints();
>
>> Added Mark for review, as I was thinking regulator_has_full_constraints() was to
>> be used to disable unused regulators, a bit like in the clock framework, rather
>> than provide a way to provide automatically dummy regulators.
>
>> If Mark acks, I'll take the serie.
>
> It's both, it's telling the core that the board has told it about all
> the regulator mappings it's ever going to tell it about.
OK, I'll take that as an Acked-by then.

Cheers.

-- 
Robert

[PATCH 1/3] ARM: pxa: add regulator_has_full_constraints to corgi board file

[Robert Jarzmik]

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> Mark Brown <broonie@kernel.org> writes:
> OK, I'll take that as an Acked-by then.
Queued the 3 of them in pxa/for-next, thanks.

Cheers.
-- 
Robert