All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cifs: Add Makefile
@ 2014-12-15 20:24 Vishal Verma
  2014-12-16  0:00 ` David Disseldorp
  0 siblings, 1 reply; 3+ messages in thread
From: Vishal Verma @ 2014-12-15 20:24 UTC (permalink / raw)
  To: fstests; +Cc: pshilovsky, Vishal Verma

tests/cifs lacked a Makefile, and this caused the %install section of
rpmbuild to fail. Add a boilerplate Makefile (from tests/ext4)

Signed-off-by: Vishal Verma <vishal.l.verma@linux.intel.com>
---
 tests/cifs/Makefile | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 tests/cifs/Makefile

diff --git a/tests/cifs/Makefile b/tests/cifs/Makefile
new file mode 100644
index 0000000..9176e5c
--- /dev/null
+++ b/tests/cifs/Makefile
@@ -0,0 +1,20 @@
+#
+# Copyright (c) 2003-2005 Silicon Graphics, Inc.  All Rights Reserved.
+#
+
+TOPDIR = ../..
+include $(TOPDIR)/include/builddefs
+
+CIFS_DIR = cifs
+TARGET_DIR = $(PKG_LIB_DIR)/$(TESTS_DIR)/$(CIFS_DIR)
+
+include $(BUILDRULES)
+
+install:
+	$(INSTALL) -m 755 -d $(TARGET_DIR)
+	$(INSTALL) -m 755 [0-9]?? $(TARGET_DIR)
+	$(INSTALL) -m 644 group $(TARGET_DIR)
+	$(INSTALL) -m 644 [0-9]??.* $(TARGET_DIR)
+
+# Nothing.
+install-dev install-lib:
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] cifs: Add Makefile
  2014-12-15 20:24 [PATCH] cifs: Add Makefile Vishal Verma
@ 2014-12-16  0:00 ` David Disseldorp
  2014-12-16  0:41   ` Vishal Verma
  0 siblings, 1 reply; 3+ messages in thread
From: David Disseldorp @ 2014-12-16  0:00 UTC (permalink / raw)
  To: Vishal Verma; +Cc: fstests, pshilovsky

On Mon, 15 Dec 2014 13:24:05 -0700
Vishal Verma <vishal.l.verma@linux.intel.com> wrote:

> tests/cifs lacked a Makefile, and this caused the %install section of
> rpmbuild to fail. Add a boilerplate Makefile (from tests/ext4)
> 
> Signed-off-by: Vishal Verma <vishal.l.verma@linux.intel.com>

This was my fault. The fix was already proposed with
Message-Id: <1418640210-16914-1-git-send-email-ddiss@suse.de> .
I'd be happy to see either change make it in.

Cheers, David

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] cifs: Add Makefile
  2014-12-16  0:00 ` David Disseldorp
@ 2014-12-16  0:41   ` Vishal Verma
  0 siblings, 0 replies; 3+ messages in thread
From: Vishal Verma @ 2014-12-16  0:41 UTC (permalink / raw)
  To: David Disseldorp; +Cc: fstests, pshilovsky

On Tue, 2014-12-16 at 01:00 +0100, David Disseldorp wrote:
> On Mon, 15 Dec 2014 13:24:05 -0700
> Vishal Verma <vishal.l.verma@linux.intel.com> wrote:
> 
> > tests/cifs lacked a Makefile, and this caused the %install section of
> > rpmbuild to fail. Add a boilerplate Makefile (from tests/ext4)
> > 
> > Signed-off-by: Vishal Verma <vishal.l.verma@linux.intel.com>
> 
> This was my fault. The fix was already proposed with
> Message-Id: <1418640210-16914-1-git-send-email-ddiss@suse.de> .
> I'd be happy to see either change make it in.
> 

Ah, I didn't notice your patch, it seemed to be threaded under a
different conversation. We can ignore this.

Thanks,
	-Vishal




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-12-16  0:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-15 20:24 [PATCH] cifs: Add Makefile Vishal Verma
2014-12-16  0:00 ` David Disseldorp
2014-12-16  0:41   ` Vishal Verma

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.