All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] samples/kobject: Use kstrtoint instead of sscanf
@ 2014-12-17 20:14 Rastislav Barlik
  0 siblings, 0 replies; 4+ messages in thread
From: Rastislav Barlik @ 2014-12-17 20:14 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-kernel, Rastislav Barlik

Use kstrtoint function instead of sscanf and check for return values.

Signed-off-by: Rastislav Barlik <barlik@zoho.com>
---
 samples/kobject/kobject-example.c | 14 +++++++++++---
 samples/kobject/kset-example.c    | 14 +++++++++++---
 2 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/samples/kobject/kobject-example.c b/samples/kobject/kobject-example.c
index 01562e0..063aaec 100644
--- a/samples/kobject/kobject-example.c
+++ b/samples/kobject/kobject-example.c
@@ -36,7 +36,12 @@ static ssize_t foo_show(struct kobject *kobj, struct kobj_attribute *attr,
 static ssize_t foo_store(struct kobject *kobj, struct kobj_attribute *attr,
 			 const char *buf, size_t count)
 {
-	sscanf(buf, "%du", &foo);
+	int ret;
+
+	ret = kstrtoint(buf, 10, &foo);
+	if (ret < 0)
+		return ret;
+
 	return count;
 }
 
@@ -63,9 +68,12 @@ static ssize_t b_show(struct kobject *kobj, struct kobj_attribute *attr,
 static ssize_t b_store(struct kobject *kobj, struct kobj_attribute *attr,
 		       const char *buf, size_t count)
 {
-	int var;
+	int var, ret;
+
+	ret = kstrtoint(buf, 10, &var);
+	if (ret < 0)
+		return ret;
 
-	sscanf(buf, "%du", &var);
 	if (strcmp(attr->attr.name, "baz") == 0)
 		baz = var;
 	else
diff --git a/samples/kobject/kset-example.c b/samples/kobject/kset-example.c
index ab5e447..e80ced3 100644
--- a/samples/kobject/kset-example.c
+++ b/samples/kobject/kset-example.c
@@ -120,7 +120,12 @@ static ssize_t foo_show(struct foo_obj *foo_obj, struct foo_attribute *attr,
 static ssize_t foo_store(struct foo_obj *foo_obj, struct foo_attribute *attr,
 			 const char *buf, size_t count)
 {
-	sscanf(buf, "%du", &foo_obj->foo);
+	int ret;
+
+	ret = kstrtoint(buf, 10, &foo_obj->foo);
+	if (ret < 0)
+		return ret;
+
 	return count;
 }
 
@@ -147,9 +152,12 @@ static ssize_t b_show(struct foo_obj *foo_obj, struct foo_attribute *attr,
 static ssize_t b_store(struct foo_obj *foo_obj, struct foo_attribute *attr,
 		       const char *buf, size_t count)
 {
-	int var;
+	int var, ret;
+
+	ret = kstrtoint(buf, 10, &var);
+	if (ret < 0)
+		return ret;
 
-	sscanf(buf, "%du", &var);
 	if (strcmp(attr->attr.name, "baz") == 0)
 		foo_obj->baz = var;
 	else
-- 
2.1.3



^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] samples/kobject: Use kstrtoint instead of sscanf
  2014-12-19  0:57 ` Rusty Russell
@ 2014-12-19  1:56   ` greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: greg KH @ 2014-12-19  1:56 UTC (permalink / raw)
  To: Rusty Russell; +Cc: Rastislav Barlik, linux-kernel

On Fri, Dec 19, 2014 at 11:27:37AM +1030, Rusty Russell wrote:
> Rastislav Barlik <barlik@zoho.com> writes:
> > Use kstrtoint function instead of sscanf and check for return values.
> >
> > Signed-off-by: Rastislav Barlik <barlik@zoho.com>
> 
> Hmm, this seems like Greg, not me.
> 
> Greg, I noticed this in samples/kobject/kobject-example.c:
> 
>  * Released under the GPL version 2 only.
> ...
> MODULE_LICENSE("GPL");
> 
> >From module.h:
> 
>  * The following license idents are currently accepted as indicating free
>  * software modules
>  *
>  *	"GPL"				[GNU Public License v2 or later]
>  *	"GPL v2"			[GNU Public License v2]

Thanks, I'll fix that up after 3.19-rc1 is out.

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] samples/kobject: Use kstrtoint instead of sscanf
  2014-12-16  8:31 Rastislav Barlik
@ 2014-12-19  0:57 ` Rusty Russell
  2014-12-19  1:56   ` greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Rusty Russell @ 2014-12-19  0:57 UTC (permalink / raw)
  To: Rastislav Barlik; +Cc: linux-kernel, Rastislav Barlik, greg KH

Rastislav Barlik <barlik@zoho.com> writes:
> Use kstrtoint function instead of sscanf and check for return values.
>
> Signed-off-by: Rastislav Barlik <barlik@zoho.com>

Hmm, this seems like Greg, not me.

Greg, I noticed this in samples/kobject/kobject-example.c:

 * Released under the GPL version 2 only.
...
MODULE_LICENSE("GPL");

>From module.h:

 * The following license idents are currently accepted as indicating free
 * software modules
 *
 *	"GPL"				[GNU Public License v2 or later]
 *	"GPL v2"			[GNU Public License v2]

Cheers,
Rusty.

> ---
>  samples/kobject/kobject-example.c | 14 +++++++++++---
>  samples/kobject/kset-example.c    | 14 +++++++++++---
>  2 files changed, 22 insertions(+), 6 deletions(-)
>
> diff --git a/samples/kobject/kobject-example.c b/samples/kobject/kobject-example.c
> index 01562e0..063aaec 100644
> --- a/samples/kobject/kobject-example.c
> +++ b/samples/kobject/kobject-example.c
> @@ -36,7 +36,12 @@ static ssize_t foo_show(struct kobject *kobj, struct kobj_attribute *attr,
>  static ssize_t foo_store(struct kobject *kobj, struct kobj_attribute *attr,
>  			 const char *buf, size_t count)
>  {
> -	sscanf(buf, "%du", &foo);
> +	int ret;
> +
> +	ret = kstrtoint(buf, 10, &foo);
> +	if (ret < 0)
> +		return ret;
> +
>  	return count;
>  }
>  
> @@ -63,9 +68,12 @@ static ssize_t b_show(struct kobject *kobj, struct kobj_attribute *attr,
>  static ssize_t b_store(struct kobject *kobj, struct kobj_attribute *attr,
>  		       const char *buf, size_t count)
>  {
> -	int var;
> +	int var, ret;
> +
> +	ret = kstrtoint(buf, 10, &var);
> +	if (ret < 0)
> +		return ret;
>  
> -	sscanf(buf, "%du", &var);
>  	if (strcmp(attr->attr.name, "baz") == 0)
>  		baz = var;
>  	else
> diff --git a/samples/kobject/kset-example.c b/samples/kobject/kset-example.c
> index ab5e447..e80ced3 100644
> --- a/samples/kobject/kset-example.c
> +++ b/samples/kobject/kset-example.c
> @@ -120,7 +120,12 @@ static ssize_t foo_show(struct foo_obj *foo_obj, struct foo_attribute *attr,
>  static ssize_t foo_store(struct foo_obj *foo_obj, struct foo_attribute *attr,
>  			 const char *buf, size_t count)
>  {
> -	sscanf(buf, "%du", &foo_obj->foo);
> +	int ret;
> +
> +	ret = kstrtoint(buf, 10, &foo_obj->foo);
> +	if (ret < 0)
> +		return ret;
> +
>  	return count;
>  }
>  
> @@ -147,9 +152,12 @@ static ssize_t b_show(struct foo_obj *foo_obj, struct foo_attribute *attr,
>  static ssize_t b_store(struct foo_obj *foo_obj, struct foo_attribute *attr,
>  		       const char *buf, size_t count)
>  {
> -	int var;
> +	int var, ret;
> +
> +	ret = kstrtoint(buf, 10, &var);
> +	if (ret < 0)
> +		return ret;
>  
> -	sscanf(buf, "%du", &var);
>  	if (strcmp(attr->attr.name, "baz") == 0)
>  		foo_obj->baz = var;
>  	else
> -- 
> 2.1.3

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] samples/kobject: Use kstrtoint instead of sscanf
@ 2014-12-16  8:31 Rastislav Barlik
  2014-12-19  0:57 ` Rusty Russell
  0 siblings, 1 reply; 4+ messages in thread
From: Rastislav Barlik @ 2014-12-16  8:31 UTC (permalink / raw)
  To: Rusty Russell; +Cc: linux-kernel, Rastislav Barlik

Use kstrtoint function instead of sscanf and check for return values.

Signed-off-by: Rastislav Barlik <barlik@zoho.com>
---
 samples/kobject/kobject-example.c | 14 +++++++++++---
 samples/kobject/kset-example.c    | 14 +++++++++++---
 2 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/samples/kobject/kobject-example.c b/samples/kobject/kobject-example.c
index 01562e0..063aaec 100644
--- a/samples/kobject/kobject-example.c
+++ b/samples/kobject/kobject-example.c
@@ -36,7 +36,12 @@ static ssize_t foo_show(struct kobject *kobj, struct kobj_attribute *attr,
 static ssize_t foo_store(struct kobject *kobj, struct kobj_attribute *attr,
 			 const char *buf, size_t count)
 {
-	sscanf(buf, "%du", &foo);
+	int ret;
+
+	ret = kstrtoint(buf, 10, &foo);
+	if (ret < 0)
+		return ret;
+
 	return count;
 }
 
@@ -63,9 +68,12 @@ static ssize_t b_show(struct kobject *kobj, struct kobj_attribute *attr,
 static ssize_t b_store(struct kobject *kobj, struct kobj_attribute *attr,
 		       const char *buf, size_t count)
 {
-	int var;
+	int var, ret;
+
+	ret = kstrtoint(buf, 10, &var);
+	if (ret < 0)
+		return ret;
 
-	sscanf(buf, "%du", &var);
 	if (strcmp(attr->attr.name, "baz") == 0)
 		baz = var;
 	else
diff --git a/samples/kobject/kset-example.c b/samples/kobject/kset-example.c
index ab5e447..e80ced3 100644
--- a/samples/kobject/kset-example.c
+++ b/samples/kobject/kset-example.c
@@ -120,7 +120,12 @@ static ssize_t foo_show(struct foo_obj *foo_obj, struct foo_attribute *attr,
 static ssize_t foo_store(struct foo_obj *foo_obj, struct foo_attribute *attr,
 			 const char *buf, size_t count)
 {
-	sscanf(buf, "%du", &foo_obj->foo);
+	int ret;
+
+	ret = kstrtoint(buf, 10, &foo_obj->foo);
+	if (ret < 0)
+		return ret;
+
 	return count;
 }
 
@@ -147,9 +152,12 @@ static ssize_t b_show(struct foo_obj *foo_obj, struct foo_attribute *attr,
 static ssize_t b_store(struct foo_obj *foo_obj, struct foo_attribute *attr,
 		       const char *buf, size_t count)
 {
-	int var;
+	int var, ret;
+
+	ret = kstrtoint(buf, 10, &var);
+	if (ret < 0)
+		return ret;
 
-	sscanf(buf, "%du", &var);
 	if (strcmp(attr->attr.name, "baz") == 0)
 		foo_obj->baz = var;
 	else
-- 
2.1.3



^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-19  1:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-17 20:14 [PATCH] samples/kobject: Use kstrtoint instead of sscanf Rastislav Barlik
  -- strict thread matches above, loose matches on Subject: below --
2014-12-16  8:31 Rastislav Barlik
2014-12-19  0:57 ` Rusty Russell
2014-12-19  1:56   ` greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.