Re: lttng-modules compatibility for 3.12 kernels

Re: lttng-modules compatibility for 3.12 kernels

[Mathieu Desnoyers]

----- Original Message -----
> From: "Otavio Salvador" <otavio@ossystems.com.br>
> To: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
> Cc: "Philippe Mangaud" <R49081@freescale.com>, "Daiane Angolini" <daiane.angolini@freescale.com>, "Fabio Estevam"
> <fabio.estevam@freescale.com>
> Sent: Saturday, October 26, 2013 10:05:23 PM
> Subject: Re: lttng-modules compatibility for 3.12 kernels
> 
> Hello Mathieu,
> 
> On Sat, Oct 26, 2013 at 5:43 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
> > I hope you don't mind I send the patches directly for you, as I don't
> > know where to send it ;-)
> >
> > We've been using Linux 3.12 in Freescale's ARM BSP for Yocto and it
> > includes lttng support. Philippe reported a build error after we
> > upgraded to 3.12 kernel and investigating it, it turns to be a very
> > easy fix.
> >
> > I am attaching both patches I will be sending for Yocto inclusion.
> >
> > Please review those and let me know if they need any adjustment to be
> > applied.
> 
> Fabio kindly reviewed the patchset and found I mistakenly used the
> wrong compare operator for the macro definition; hence the v2 is
> attached. I used the opportunity the rework the commit log a bit.

Hi Otavio,

Thanks for the patches !

I merged patch 0001 as is (lttng-statedump-impl: Fix lttng_list_interrupts for empty implementation) into lttng-modules master, stable-2.3, stable-2.2.

For patch 0002, I reworked it so it now introduces a wrapper/irq.h header. This will help us not crumble under the weight of version tracking ifdefs in the long run. I'm pulling them into lttng-modules master branch. Please let me know if they work fine for you! I'm currently traveling without fast internet connectivity, so testing on 3.12 rc is not easy for me at the moment, hence the importance of your feedback.

Thanks!

Mathieu


> 
> Thanks in advance,
> 
> Regards,
> 
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> 

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

Re: lttng-modules compatibility for 3.12 kernels

[Otavio Salvador]

Hello Mathieu,

On Mon, Oct 28, 2013 at 10:22 AM, Mathieu Desnoyers
<mathieu.desnoyers@efficios.com> wrote:
> Thanks for the patches !

You're welcome.

> I merged patch 0001 as is (lttng-statedump-impl: Fix lttng_list_interrupts for empty implementation) into lttng-modules master, stable-2.3, stable-2.2.

Great.

> For patch 0002, I reworked it so it now introduces a wrapper/irq.h header. This will help us not crumble under the weight of version tracking ifdefs in the long run. I'm pulling them into lttng-modules master branch. Please let me know if they work fine for you! I'm currently traveling without fast internet connectivity, so testing on 3.12 rc is not easy for me at the moment, hence the importance of your feedback.

Great. The patch works as intended.

I am going to send the next failure we need to fix with 3.12-rc6 to
the mailing list.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750