All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: lustre: lustre: obdclass: lprocfs_status.c:  Removed an unnecessary NULL check
@ 2014-12-21 18:30 Rickard Strandqvist
  0 siblings, 0 replies; 4+ messages in thread
From: Rickard Strandqvist @ 2014-12-21 18:30 UTC (permalink / raw)
  To: Oleg Drokin, Andreas Dilger
  Cc: Rickard Strandqvist, Greg Kroah-Hartman, Julia Lawall,
	Greg Donald, John L. Hammond, Andriy Skulysh, Fabian Frederick,
	James Simmons, HPDD-discuss, devel, linux-kernel

Removed an unnecessary NULL check.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/staging/lustre/lustre/obdclass/lprocfs_status.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
index 61e04af..637b576 100644
--- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
+++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
@@ -1882,7 +1882,7 @@ int lprocfs_write_frac_u64_helper(const char *buffer, unsigned long count,
 	if (pbuf == end)
 		return -EINVAL;
 
-	if (end != NULL && *end == '.') {
+	if (*end == '.') {
 		int i;
 		pbuf = end + 1;
 
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] staging: lustre: lustre: obdclass: lprocfs_status.c: Removed an unnecessary NULL check
  2014-12-18  0:11 ` Greg Kroah-Hartman
@ 2014-12-21 18:07   ` Rickard Strandqvist
  0 siblings, 0 replies; 4+ messages in thread
From: Rickard Strandqvist @ 2014-12-21 18:07 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Oleg Drokin, Andreas Dilger, devel, HPDD-discuss, Greg Donald,
	James Simmons, linux-kernel, Fabian Frederick, Julia Lawall,
	Andriy Skulysh, John L. Hammond

2014-12-18 1:11 GMT+01:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Wed, Dec 17, 2014 at 11:05:00PM +0100, Rickard Strandqvist wrote:
>> Removed an unnecessary NULL check. And clarified a switch statement.
>
> That's two different things, please only do one thing in a patch, so
> this would be 2 different patches.
>
> please fix up and resend as a series of patches.
>
> thanks,
>
> greg k-h



Ok, sorry new path on the way!

Kind regards
Rickard Strandqvist

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] staging: lustre: lustre: obdclass: lprocfs_status.c: Removed an unnecessary NULL check
  2014-12-17 22:05 Rickard Strandqvist
@ 2014-12-18  0:11 ` Greg Kroah-Hartman
  2014-12-21 18:07   ` Rickard Strandqvist
  0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2014-12-18  0:11 UTC (permalink / raw)
  To: Rickard Strandqvist
  Cc: Oleg Drokin, Andreas Dilger, devel, HPDD-discuss, Greg Donald,
	James Simmons, linux-kernel, Fabian Frederick, Julia Lawall,
	Andriy Skulysh, John L. Hammond

On Wed, Dec 17, 2014 at 11:05:00PM +0100, Rickard Strandqvist wrote:
> Removed an unnecessary NULL check. And clarified a switch statement.

That's two different things, please only do one thing in a patch, so
this would be 2 different patches.

please fix up and resend as a series of patches.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] staging: lustre: lustre: obdclass: lprocfs_status.c:  Removed an unnecessary NULL check
@ 2014-12-17 22:05 Rickard Strandqvist
  2014-12-18  0:11 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 4+ messages in thread
From: Rickard Strandqvist @ 2014-12-17 22:05 UTC (permalink / raw)
  To: Oleg Drokin, Andreas Dilger
  Cc: Rickard Strandqvist, Greg Kroah-Hartman, Julia Lawall,
	Greg Donald, John L. Hammond, Andriy Skulysh, Fabian Frederick,
	James Simmons, HPDD-discuss, devel, linux-kernel

Removed an unnecessary NULL check. And clarified a switch statement.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/staging/lustre/lustre/obdclass/lprocfs_status.c |   15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
index 61e04af..bf3353f 100644
--- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
+++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
@@ -45,6 +45,7 @@
 #include "../include/lprocfs_status.h"
 #include "../include/lustre/lustre_idl.h"
 #include <linux/seq_file.h>
+#include <linux/ctype.h>
 
 static const char * const obd_connect_names[] = {
 	"read_only",
@@ -1882,7 +1883,7 @@ int lprocfs_write_frac_u64_helper(const char *buffer, unsigned long count,
 	if (pbuf == end)
 		return -EINVAL;
 
-	if (end != NULL && *end == '.') {
+	if (*end == '.') {
 		int i;
 		pbuf = end + 1;
 
@@ -1897,16 +1898,16 @@ int lprocfs_write_frac_u64_helper(const char *buffer, unsigned long count,
 	}
 
 	units = 1;
-	switch (*end) {
-	case 'p': case 'P':
+	switch (tolower(*end)) {
+	case 'p':
 		units <<= 10;
-	case 't': case 'T':
+	case 't':
 		units <<= 10;
-	case 'g': case 'G':
+	case 'g':
 		units <<= 10;
-	case 'm': case 'M':
+	case 'm':
 		units <<= 10;
-	case 'k': case 'K':
+	case 'k':
 		units <<= 10;
 	}
 	/* Specified units override the multiplier */
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-21 18:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-21 18:30 [PATCH] staging: lustre: lustre: obdclass: lprocfs_status.c: Removed an unnecessary NULL check Rickard Strandqvist
  -- strict thread matches above, loose matches on Subject: below --
2014-12-17 22:05 Rickard Strandqvist
2014-12-18  0:11 ` Greg Kroah-Hartman
2014-12-21 18:07   ` Rickard Strandqvist

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.