* [PATCH] net: incorrect use of init_completion fixup
@ 2014-12-23 17:47 Nicholas Mc Guire
2014-12-26 22:08 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Mc Guire @ 2014-12-23 17:47 UTC (permalink / raw)
To: Rasesh Mody; +Cc: netdev, linux-kernel, Nicholas Mc Guire
The second init_completion call should be a reinit_completion here.
patch is against 3.18.0 linux-next
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
index 7d6aa8c..619083a 100644
--- a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
+++ b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
@@ -172,7 +172,7 @@ bnad_get_debug_drvinfo(struct bnad *bnad, void *buffer, u32 len)
/* Retrieve flash partition info */
fcomp.comp_status = 0;
- init_completion(&fcomp.comp);
+ reinit_completion(&fcomp.comp);
spin_lock_irqsave(&bnad->bna_lock, flags);
ret = bfa_nw_flash_get_attr(&bnad->bna.flash, &drvinfo->flash_attr,
bnad_cb_completion, &fcomp);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: incorrect use of init_completion fixup
2014-12-23 17:47 [PATCH] net: incorrect use of init_completion fixup Nicholas Mc Guire
@ 2014-12-26 22:08 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-12-26 22:08 UTC (permalink / raw)
To: der.herr; +Cc: rasesh.mody, netdev, linux-kernel
From: Nicholas Mc Guire <der.herr@hofr.at>
Date: Tue, 23 Dec 2014 18:47:50 +0100
> The second init_completion call should be a reinit_completion here.
>
> patch is against 3.18.0 linux-next
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-26 22:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-23 17:47 [PATCH] net: incorrect use of init_completion fixup Nicholas Mc Guire
2014-12-26 22:08 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.