From: Javier Martinez Canillas <javier.martinez@collabora.co.uk> To: Kukjin Kim <kgene.kim@samsung.com> Cc: Doug Anderson <dianders@chromium.org>, Kevin Hilman <khilman@linaro.org>, Olof Johansson <olof@lixom.net>, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas <javier.martinez@collabora.co.uk> Subject: [PATCH RESEND 1/4] ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow Date: Fri, 2 Jan 2015 16:24:14 +0100 [thread overview] Message-ID: <1420212257-22443-2-git-send-email-javier.martinez@collabora.co.uk> (raw) In-Reply-To: <1420212257-22443-1-git-send-email-javier.martinez@collabora.co.uk> The Exynos5250 Snow Chromebook has GPIO keys for power and lid so the SoC I/O pins have to be configured in external interrupt mode. Currently, this is working without setting the pinctrl lines but is better to set it explicitly instead of relying on the previous state of the I/O pins. The DTS snippets were taken from the downstream ChromeOS tree. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- arch/arm/boot/dts/exynos5250-snow.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index effaf2a..b9aeec4 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -33,6 +33,8 @@ gpio-keys { compatible = "gpio-keys"; + pinctrl-names = "default"; + pinctrl-0 = <&power_key_irq &lid_irq>; power { label = "Power"; @@ -540,6 +542,13 @@ }; &pinctrl_0 { + power_key_irq: power-key-irq { + samsung,pins = "gpx1-3"; + samsung,pin-function = <0xf>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + ec_irq: ec-irq { samsung,pins = "gpx1-6"; samsung,pin-function = <0>; @@ -575,6 +584,13 @@ samsung,pin-drv = <0>; }; + lid_irq: lid-irq { + samsung,pins = "gpx3-5"; + samsung,pin-function = <0xf>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + hdmi_hpd_irq: hdmi-hpd-irq { samsung,pins = "gpx3-7"; samsung,pin-function = <0>; -- 2.1.3
WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH RESEND 1/4] ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow Date: Fri, 2 Jan 2015 16:24:14 +0100 [thread overview] Message-ID: <1420212257-22443-2-git-send-email-javier.martinez@collabora.co.uk> (raw) In-Reply-To: <1420212257-22443-1-git-send-email-javier.martinez@collabora.co.uk> The Exynos5250 Snow Chromebook has GPIO keys for power and lid so the SoC I/O pins have to be configured in external interrupt mode. Currently, this is working without setting the pinctrl lines but is better to set it explicitly instead of relying on the previous state of the I/O pins. The DTS snippets were taken from the downstream ChromeOS tree. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- arch/arm/boot/dts/exynos5250-snow.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index effaf2a..b9aeec4 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -33,6 +33,8 @@ gpio-keys { compatible = "gpio-keys"; + pinctrl-names = "default"; + pinctrl-0 = <&power_key_irq &lid_irq>; power { label = "Power"; @@ -540,6 +542,13 @@ }; &pinctrl_0 { + power_key_irq: power-key-irq { + samsung,pins = "gpx1-3"; + samsung,pin-function = <0xf>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + ec_irq: ec-irq { samsung,pins = "gpx1-6"; samsung,pin-function = <0>; @@ -575,6 +584,13 @@ samsung,pin-drv = <0>; }; + lid_irq: lid-irq { + samsung,pins = "gpx3-5"; + samsung,pin-function = <0xf>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + hdmi_hpd_irq: hdmi-hpd-irq { samsung,pins = "gpx3-7"; samsung,pin-function = <0>; -- 2.1.3
next prev parent reply other threads:[~2015-01-02 15:25 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-02 15:24 [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS Javier Martinez Canillas 2015-01-02 15:24 ` Javier Martinez Canillas 2015-01-02 15:24 ` Javier Martinez Canillas [this message] 2015-01-02 15:24 ` [PATCH RESEND 1/4] ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow Javier Martinez Canillas 2015-01-14 15:17 ` Kukjin Kim 2015-01-14 15:17 ` Kukjin Kim 2015-01-14 15:37 ` Javier Martinez Canillas 2015-01-14 15:37 ` Javier Martinez Canillas 2015-01-02 15:24 ` [PATCH RESEND 2/4] ARM: dts: Add lid GPIO key device node for Peach boards Javier Martinez Canillas 2015-01-02 15:24 ` Javier Martinez Canillas 2015-01-02 15:24 ` [PATCH RESEND 3/4] ARM: dts: Set Peach boards USB WebCam regulators to always on Javier Martinez Canillas 2015-01-02 15:24 ` Javier Martinez Canillas 2015-01-02 15:24 ` [PATCH RESEND 4/4] ARM: dts: Configure regulators for suspend on exynos Peach boards Javier Martinez Canillas 2015-01-02 15:24 ` Javier Martinez Canillas 2015-01-12 10:41 ` [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS Javier Martinez Canillas 2015-01-12 10:41 ` Javier Martinez Canillas 2015-01-14 15:12 ` Kukjin Kim 2015-01-14 15:12 ` Kukjin Kim 2015-01-14 15:28 ` Kukjin Kim 2015-01-14 15:28 ` Kukjin Kim 2015-01-14 15:41 ` Javier Martinez Canillas 2015-01-14 15:41 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1420212257-22443-2-git-send-email-javier.martinez@collabora.co.uk \ --to=javier.martinez@collabora.co.uk \ --cc=dianders@chromium.org \ --cc=kgene.kim@samsung.com \ --cc=khilman@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=olof@lixom.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.