From: Ian Abbott <abbotti@mev.co.uk> To: <driverdev-devel@linuxdriverproject.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Ian Abbott <abbotti@mev.co.uk>, H Hartley Sweeten <hartleys@visionengravers.com>, <linux-kernel@vger.kernel.org> Subject: [PATCH 03/45] staging: comedi: adl_pci7x3x: rewrite comedi driver comment block Date: Mon, 5 Jan 2015 17:54:31 +0000 [thread overview] Message-ID: <1420480513-14765-4-git-send-email-abbotti@mev.co.uk> (raw) In-Reply-To: <1420480513-14765-1-git-send-email-abbotti@mev.co.uk> Rewrite the comedi "driver" comment block to conform to the usual format for comedi driver comment blocks and reformat it to use the usual block comment style. In particular, the "Devices:" line should be a comma-separated list where the first item is in the following format: [Manufacturer] BOARD-NAME (comedi-board-name) The "[Manufacturer]" and/or "(comedi-board-name)" parts may be omitted from following items, in which case the parts from the preceding item are used. The "Devices:" line may be continued continued over several lines by using one or more spaces at the start of each continuation line (not counting the space after the "*" in the block comment). The original comment indicated the number of input and output channels in each item on the "Devices:" line. Move this information into a separate paragraph moved from a block comment found elsewhere in the driver. Signed-off-by: Ian Abbott <abbotti@mev.co.uk> --- drivers/staging/comedi/drivers/adl_pci7x3x.c | 62 +++++++++++++--------------- 1 file changed, 29 insertions(+), 33 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_pci7x3x.c b/drivers/staging/comedi/drivers/adl_pci7x3x.c index fb8e5f5..618e641 100644 --- a/drivers/staging/comedi/drivers/adl_pci7x3x.c +++ b/drivers/staging/comedi/drivers/adl_pci7x3x.c @@ -22,27 +22,35 @@ */ /* -Driver: adl_pci7x3x -Description: 32/64-Channel Isolated Digital I/O Boards -Devices: (ADLink) PCI-7230 [adl_pci7230] - 16 input / 16 output - (ADLink) PCI-7233 [adl_pci7233] - 32 input - (ADLink) PCI-7234 [adl_pci7234] - 32 output - (ADLink) PCI-7432 [adl_pci7432] - 32 input / 32 output - (ADLink) PCI-7433 [adl_pci7433] - 64 input - (ADLink) PCI-7434 [adl_pci7434] - 64 output -Author: H Hartley Sweeten <hsweeten@visionengravers.com> -Updated: Thu, 02 Aug 2012 14:27:46 -0700 -Status: untested - -The PCI-7230, PCI-7432 and PCI-7433 boards also support external -interrupt signals on digital input channels 0 and 1. The PCI-7233 -has dual-interrupt sources for change-of-state (COS) on any 16 -digital input channels of LSB and for COS on any 16 digital input -lines of MSB. Interrupts are not currently supported by this -driver. - -Configuration Options: not applicable, uses comedi PCI auto config -*/ + * Driver: adl_pci7x3x + * Description: 32/64-Channel Isolated Digital I/O Boards + * Devices: [ADLink] PCI-7230 (adl_pci7230), PCI-7233 (adl_pci7233), + * PCI-7234 (adl_pci7234), PCI-7432 (adl_pci7432), PCI-7433 (adl_pci7433), + * PCI-7434 (adl_pci7434) + * Author: H Hartley Sweeten <hsweeten@visionengravers.com> + * Updated: Thu, 02 Aug 2012 14:27:46 -0700 + * Status: untested + * + * One or two subdevices are setup by this driver depending on + * the number of digital inputs and/or outputs provided by the + * board. Each subdevice has a maximum of 32 channels. + * + * PCI-7230 - 2 subdevices: 0 - 16 input, 1 - 16 output + * PCI-7233 - 1 subdevice: 0 - 32 input + * PCI-7234 - 1 subdevice: 0 - 32 output + * PCI-7432 - 2 subdevices: 0 - 32 input, 1 - 32 output + * PCI-7433 - 2 subdevices: 0 - 32 input, 1 - 32 input + * PCI-7434 - 2 subdevices: 0 - 32 output, 1 - 32 output + * + * The PCI-7230, PCI-7432 and PCI-7433 boards also support external + * interrupt signals on digital input channels 0 and 1. The PCI-7233 + * has dual-interrupt sources for change-of-state (COS) on any 16 + * digital input channels of LSB and for COS on any 16 digital input + * lines of MSB. Interrupts are not currently supported by this + * driver. + * + * Configuration Options: not applicable, uses comedi PCI auto config + */ #include <linux/module.h> #include <linux/pci.h> @@ -155,18 +163,6 @@ static int adl_pci7x3x_auto_attach(struct comedi_device *dev, return ret; dev->iobase = pci_resource_start(pcidev, 2); - /* - * One or two subdevices are setup by this driver depending on - * the number of digital inputs and/or outputs provided by the - * board. Each subdevice has a maximum of 32 channels. - * - * PCI-7230 - 2 subdevices: 0 - 16 input, 1 - 16 output - * PCI-7233 - 1 subdevice: 0 - 32 input - * PCI-7234 - 1 subdevice: 0 - 32 output - * PCI-7432 - 2 subdevices: 0 - 32 input, 1 - 32 output - * PCI-7433 - 2 subdevices: 0 - 32 input, 1 - 32 input - * PCI-7434 - 2 subdevices: 0 - 32 output, 1 - 32 output - */ ret = comedi_alloc_subdevices(dev, board->nsubdevs); if (ret) return ret; -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: Ian Abbott <abbotti@mev.co.uk> To: driverdev-devel@linuxdriverproject.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Ian Abbott <abbotti@mev.co.uk>, linux-kernel@vger.kernel.org Subject: [PATCH 03/45] staging: comedi: adl_pci7x3x: rewrite comedi driver comment block Date: Mon, 5 Jan 2015 17:54:31 +0000 [thread overview] Message-ID: <1420480513-14765-4-git-send-email-abbotti@mev.co.uk> (raw) In-Reply-To: <1420480513-14765-1-git-send-email-abbotti@mev.co.uk> Rewrite the comedi "driver" comment block to conform to the usual format for comedi driver comment blocks and reformat it to use the usual block comment style. In particular, the "Devices:" line should be a comma-separated list where the first item is in the following format: [Manufacturer] BOARD-NAME (comedi-board-name) The "[Manufacturer]" and/or "(comedi-board-name)" parts may be omitted from following items, in which case the parts from the preceding item are used. The "Devices:" line may be continued continued over several lines by using one or more spaces at the start of each continuation line (not counting the space after the "*" in the block comment). The original comment indicated the number of input and output channels in each item on the "Devices:" line. Move this information into a separate paragraph moved from a block comment found elsewhere in the driver. Signed-off-by: Ian Abbott <abbotti@mev.co.uk> Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com> --- drivers/staging/comedi/drivers/adl_pci7x3x.c | 62 +++++++++++++--------------- 1 file changed, 29 insertions(+), 33 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_pci7x3x.c b/drivers/staging/comedi/drivers/adl_pci7x3x.c index fb8e5f5..618e641 100644 --- a/drivers/staging/comedi/drivers/adl_pci7x3x.c +++ b/drivers/staging/comedi/drivers/adl_pci7x3x.c @@ -22,27 +22,35 @@ */ /* -Driver: adl_pci7x3x -Description: 32/64-Channel Isolated Digital I/O Boards -Devices: (ADLink) PCI-7230 [adl_pci7230] - 16 input / 16 output - (ADLink) PCI-7233 [adl_pci7233] - 32 input - (ADLink) PCI-7234 [adl_pci7234] - 32 output - (ADLink) PCI-7432 [adl_pci7432] - 32 input / 32 output - (ADLink) PCI-7433 [adl_pci7433] - 64 input - (ADLink) PCI-7434 [adl_pci7434] - 64 output -Author: H Hartley Sweeten <hsweeten@visionengravers.com> -Updated: Thu, 02 Aug 2012 14:27:46 -0700 -Status: untested - -The PCI-7230, PCI-7432 and PCI-7433 boards also support external -interrupt signals on digital input channels 0 and 1. The PCI-7233 -has dual-interrupt sources for change-of-state (COS) on any 16 -digital input channels of LSB and for COS on any 16 digital input -lines of MSB. Interrupts are not currently supported by this -driver. - -Configuration Options: not applicable, uses comedi PCI auto config -*/ + * Driver: adl_pci7x3x + * Description: 32/64-Channel Isolated Digital I/O Boards + * Devices: [ADLink] PCI-7230 (adl_pci7230), PCI-7233 (adl_pci7233), + * PCI-7234 (adl_pci7234), PCI-7432 (adl_pci7432), PCI-7433 (adl_pci7433), + * PCI-7434 (adl_pci7434) + * Author: H Hartley Sweeten <hsweeten@visionengravers.com> + * Updated: Thu, 02 Aug 2012 14:27:46 -0700 + * Status: untested + * + * One or two subdevices are setup by this driver depending on + * the number of digital inputs and/or outputs provided by the + * board. Each subdevice has a maximum of 32 channels. + * + * PCI-7230 - 2 subdevices: 0 - 16 input, 1 - 16 output + * PCI-7233 - 1 subdevice: 0 - 32 input + * PCI-7234 - 1 subdevice: 0 - 32 output + * PCI-7432 - 2 subdevices: 0 - 32 input, 1 - 32 output + * PCI-7433 - 2 subdevices: 0 - 32 input, 1 - 32 input + * PCI-7434 - 2 subdevices: 0 - 32 output, 1 - 32 output + * + * The PCI-7230, PCI-7432 and PCI-7433 boards also support external + * interrupt signals on digital input channels 0 and 1. The PCI-7233 + * has dual-interrupt sources for change-of-state (COS) on any 16 + * digital input channels of LSB and for COS on any 16 digital input + * lines of MSB. Interrupts are not currently supported by this + * driver. + * + * Configuration Options: not applicable, uses comedi PCI auto config + */ #include <linux/module.h> #include <linux/pci.h> @@ -155,18 +163,6 @@ static int adl_pci7x3x_auto_attach(struct comedi_device *dev, return ret; dev->iobase = pci_resource_start(pcidev, 2); - /* - * One or two subdevices are setup by this driver depending on - * the number of digital inputs and/or outputs provided by the - * board. Each subdevice has a maximum of 32 channels. - * - * PCI-7230 - 2 subdevices: 0 - 16 input, 1 - 16 output - * PCI-7233 - 1 subdevice: 0 - 32 input - * PCI-7234 - 1 subdevice: 0 - 32 output - * PCI-7432 - 2 subdevices: 0 - 32 input, 1 - 32 output - * PCI-7433 - 2 subdevices: 0 - 32 input, 1 - 32 input - * PCI-7434 - 2 subdevices: 0 - 32 output, 1 - 32 output - */ ret = comedi_alloc_subdevices(dev, board->nsubdevs); if (ret) return ret; -- 2.1.4 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2015-01-05 18:08 UTC|newest] Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-05 17:54 [PATCH 00/45] staging: comedi: fix up some driver comments Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 01/45] staging: comedi: 8255_pci: rewrite comedi driver comment block Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 02/45] staging: comedi: adl_pci6208: rewrite "Devices:" line Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` Ian Abbott [this message] 2015-01-05 17:54 ` [PATCH 03/45] staging: comedi: adl_pci7x3x: rewrite comedi driver comment block Ian Abbott 2015-01-05 17:54 ` [PATCH 04/45] staging: comedi: adl_pci8164: rewrite "Devices:" line Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 05/45] staging: comedi: adv_pci1723: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 06/45] staging: comedi: adv_pci1724: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 07/45] staging: comedi: c6xdigio: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 08/45] staging: comedi: cb_pcidda: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 09/45] staging: comedi: comedi_parport: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 10/45] staging: comedi: dac02: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 11/45] staging: comedi: das08: remove comedi driver comment block Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 12/45] staging: comedi: das08_isa: rewrite "Devices:" line Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 13/45] staging: comedi: das08_pci: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 14/45] staging: comedi: das16: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 15/45] staging: comedi: das6402: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 16/45] staging: comedi: dmm32at: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 17/45] staging: comedi: dt282x: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 18/45] staging: comedi: dyna_pci10xx: rewrite comedi driver comment block Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 19/45] staging: comedi: ii_pci20kc: rewrite "Devices:" line Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 20/45] staging: comedi: ke_counter: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 21/45] staging: comedi: me_daq: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 22/45] staging: comedi: mf6x4: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 23/45] staging: comedi: ni_6527: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 24/45] staging: comedi: ni_65xx: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 25/45] staging: comedi: ni_65xx: use board names on " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 26/45] staging: comedi: ni_at_ao: rewrite " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 27/45] staging: comedi: ni_labpc: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 28/45] staging: comedi: ni_labpc_pci: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 29/45] staging: comedi: ni_tio: change comedi "driver" comment to "module" Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 30/45] staging: comedi: ni_tiocmd: " Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:54 ` [PATCH 31/45] staging: comedi: pcl711: rewrite "Devices:" line Ian Abbott 2015-01-05 17:54 ` Ian Abbott 2015-01-05 17:55 ` [PATCH 32/45] staging: comedi: pcl724: " Ian Abbott 2015-01-05 17:55 ` Ian Abbott 2015-01-05 17:55 ` [PATCH 33/45] staging: comedi: pcl726: " Ian Abbott 2015-01-05 17:55 ` Ian Abbott 2015-01-05 17:55 ` [PATCH 34/45] staging: comedi: pcl730: " Ian Abbott 2015-01-05 17:55 ` Ian Abbott 2015-01-05 17:55 ` [PATCH 35/45] staging: comedi: pcmad: " Ian Abbott 2015-01-05 17:55 ` Ian Abbott 2015-01-05 17:55 ` [PATCH 36/45] staging: comedi: pcmda12: " Ian Abbott 2015-01-05 17:55 ` Ian Abbott 2015-01-05 17:55 ` [PATCH 37/45] staging: comedi: pcmmio: " Ian Abbott 2015-01-05 17:55 ` Ian Abbott 2015-01-05 17:55 ` [PATCH 38/45] staging: comedi: pcmuio: " Ian Abbott 2015-01-05 17:55 ` Ian Abbott 2015-01-05 17:55 ` [PATCH 39/45] staging: comedi: rtd520: " Ian Abbott 2015-01-05 17:55 ` Ian Abbott 2015-01-05 17:55 ` [PATCH 40/45] staging: comedi: rti800: " Ian Abbott 2015-01-05 17:55 ` Ian Abbott 2015-01-05 17:55 ` [PATCH 41/45] staging: comedi: rti802: " Ian Abbott 2015-01-05 17:55 ` Ian Abbott 2015-01-05 17:55 ` [PATCH 42/45] staging: comedi: usbdux: " Ian Abbott 2015-01-05 17:55 ` Ian Abbott 2015-01-05 17:55 ` [PATCH 43/45] staging: comedi: usbduxfast: " Ian Abbott 2015-01-05 17:55 ` Ian Abbott 2015-01-05 17:55 ` [PATCH 44/45] staging: comedi: usbduxsigma: " Ian Abbott 2015-01-05 17:55 ` Ian Abbott 2015-01-05 17:55 ` [PATCH 45/45] staging: comedi: vm80xx: rewrite comedi driver comment block Ian Abbott 2015-01-05 17:55 ` Ian Abbott 2015-01-05 18:55 ` [PATCH 00/45] staging: comedi: fix up some driver comments Hartley Sweeten 2015-01-05 18:55 ` Hartley Sweeten
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1420480513-14765-4-git-send-email-abbotti@mev.co.uk \ --to=abbotti@mev.co.uk \ --cc=driverdev-devel@linuxdriverproject.org \ --cc=gregkh@linuxfoundation.org \ --cc=hartleys@visionengravers.com \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.