* [PATCH] NVMe: Fix scsi mode select llbaa setting
@ 2015-01-10 0:20 Keith Busch
2015-01-12 19:04 ` Verma, Vishal L
0 siblings, 1 reply; 2+ messages in thread
From: Keith Busch @ 2015-01-10 0:20 UTC (permalink / raw)
It should be a logical bitwise AND, not conditional.
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
drivers/block/nvme-scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/nvme-scsi.c b/drivers/block/nvme-scsi.c
index 046ae33..63efe40 100644
--- a/drivers/block/nvme-scsi.c
+++ b/drivers/block/nvme-scsi.c
@@ -1600,7 +1600,7 @@ static inline void nvme_trans_modesel_get_bd_len(u8 *parm_list, u8 cdb10,
/* 10 Byte CDB */
*bd_len = (parm_list[MODE_SELECT_10_BD_OFFSET] << 8) +
parm_list[MODE_SELECT_10_BD_OFFSET + 1];
- *llbaa = parm_list[MODE_SELECT_10_LLBAA_OFFSET] &&
+ *llbaa = parm_list[MODE_SELECT_10_LLBAA_OFFSET] &
MODE_SELECT_10_LLBAA_MASK;
} else {
/* 6 Byte CDB */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] NVMe: Fix scsi mode select llbaa setting
2015-01-10 0:20 [PATCH] NVMe: Fix scsi mode select llbaa setting Keith Busch
@ 2015-01-12 19:04 ` Verma, Vishal L
0 siblings, 0 replies; 2+ messages in thread
From: Verma, Vishal L @ 2015-01-12 19:04 UTC (permalink / raw)
On Fri, 2015-01-09@17:20 -0700, Keith Busch wrote:
> It should be a logical bitwise AND, not conditional.
>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
> drivers/block/nvme-scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Vishal Verma <vishal.l.verma at linux.intel.com>
Thanks, good catch!
> diff --git a/drivers/block/nvme-scsi.c b/drivers/block/nvme-scsi.c
> index 046ae33..63efe40 100644
> --- a/drivers/block/nvme-scsi.c
> +++ b/drivers/block/nvme-scsi.c
> @@ -1600,7 +1600,7 @@ static inline void nvme_trans_modesel_get_bd_len(u8 *parm_list, u8 cdb10,
> /* 10 Byte CDB */
> *bd_len = (parm_list[MODE_SELECT_10_BD_OFFSET] << 8) +
> parm_list[MODE_SELECT_10_BD_OFFSET + 1];
> - *llbaa = parm_list[MODE_SELECT_10_LLBAA_OFFSET] &&
> + *llbaa = parm_list[MODE_SELECT_10_LLBAA_OFFSET] &
> MODE_SELECT_10_LLBAA_MASK;
> } else {
> /* 6 Byte CDB */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-12 19:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-10 0:20 [PATCH] NVMe: Fix scsi mode select llbaa setting Keith Busch
2015-01-12 19:04 ` Verma, Vishal L
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.