All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drivers: bus: check cci device tree node status
@ 2015-01-10  3:11 ` Abhilash Kesavan
  0 siblings, 0 replies; 6+ messages in thread
From: Abhilash Kesavan @ 2015-01-10  3:11 UTC (permalink / raw)
  To: kgene.kim, linux-arm-kernel, arm, arnd, khilman, olof
  Cc: linux-samsung-soc, kesavan.abhilash, sudeep.holla, nicolas.pitre,
	Punit.Agrawal, Will.Deacon, Mark.Rutland, k.kozlowski

The arm-cci driver completes the probe sequence even if the cci node is
marked as disabled. Add a check in the driver to honour the cci status
in the device tree.

Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Nicolas Pitre <nico@linaro.org>
Tested-by: Sudeep Holla <sudeep.holla@arm.com>
Tested-by: Kevin Hilman <khilman@linaro.org>
---
Changes:
	- Re-sending without the RFT tags

 drivers/bus/arm-cci.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index 860da40..0ce5e2d 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -1312,6 +1312,9 @@ static int cci_probe(void)
 	if (!np)
 		return -ENODEV;
 
+	if (!of_device_is_available(np))
+		return -ENODEV;
+
 	cci_config = of_match_node(arm_cci_matches, np)->data;
 	if (!cci_config)
 		return -ENODEV;
-- 
2.2.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 1/2] drivers: bus: check cci device tree node status
@ 2015-01-10  3:11 ` Abhilash Kesavan
  0 siblings, 0 replies; 6+ messages in thread
From: Abhilash Kesavan @ 2015-01-10  3:11 UTC (permalink / raw)
  To: linux-arm-kernel

The arm-cci driver completes the probe sequence even if the cci node is
marked as disabled. Add a check in the driver to honour the cci status
in the device tree.

Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Nicolas Pitre <nico@linaro.org>
Tested-by: Sudeep Holla <sudeep.holla@arm.com>
Tested-by: Kevin Hilman <khilman@linaro.org>
---
Changes:
	- Re-sending without the RFT tags

 drivers/bus/arm-cci.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index 860da40..0ce5e2d 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -1312,6 +1312,9 @@ static int cci_probe(void)
 	if (!np)
 		return -ENODEV;
 
+	if (!of_device_is_available(np))
+		return -ENODEV;
+
 	cci_config = of_match_node(arm_cci_matches, np)->data;
 	if (!cci_config)
 		return -ENODEV;
-- 
2.2.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] arm: dts: disable CCI on exynos420 based arndale-octa
  2015-01-10  3:11 ` Abhilash Kesavan
@ 2015-01-10  3:11   ` Abhilash Kesavan
  -1 siblings, 0 replies; 6+ messages in thread
From: Abhilash Kesavan @ 2015-01-10  3:11 UTC (permalink / raw)
  To: kgene.kim, linux-arm-kernel, arm, arnd, khilman, olof
  Cc: linux-samsung-soc, kesavan.abhilash, sudeep.holla, nicolas.pitre,
	Punit.Agrawal, Will.Deacon, Mark.Rutland, k.kozlowski

The arndale-octa board was giving "imprecise external aborts" during
boot-up with MCPM enabled. CCI enablement of the boot cluster was found
to be the cause of these aborts (possibly because the secure f/w was not
allowing it). Hence, disable CCI for the arndale-octa board.

Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested-by: Kevin Hilman <khilman@linaro.org>
Tested-by: Tyler Baker <tyler.baker@linaro.org>
---
 arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
 arch/arm/boot/dts/exynos5420.dtsi             | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
index aa7a7d7..db2c1c4 100644
--- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts
+++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
@@ -372,3 +372,7 @@
 &usbdrd_dwc3_1 {
 	dr_mode = "host";
 };
+
+&cci {
+	status = "disabled";
+};
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 517e50f..0a82ae7 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -120,7 +120,7 @@
 		};
 	};
 
-	cci@10d20000 {
+	cci: cci@10d20000 {
 		compatible = "arm,cci-400";
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
2.2.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] arm: dts: disable CCI on exynos420 based arndale-octa
@ 2015-01-10  3:11   ` Abhilash Kesavan
  0 siblings, 0 replies; 6+ messages in thread
From: Abhilash Kesavan @ 2015-01-10  3:11 UTC (permalink / raw)
  To: linux-arm-kernel

The arndale-octa board was giving "imprecise external aborts" during
boot-up with MCPM enabled. CCI enablement of the boot cluster was found
to be the cause of these aborts (possibly because the secure f/w was not
allowing it). Hence, disable CCI for the arndale-octa board.

Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested-by: Kevin Hilman <khilman@linaro.org>
Tested-by: Tyler Baker <tyler.baker@linaro.org>
---
 arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
 arch/arm/boot/dts/exynos5420.dtsi             | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
index aa7a7d7..db2c1c4 100644
--- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts
+++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
@@ -372,3 +372,7 @@
 &usbdrd_dwc3_1 {
 	dr_mode = "host";
 };
+
+&cci {
+	status = "disabled";
+};
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 517e50f..0a82ae7 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -120,7 +120,7 @@
 		};
 	};
 
-	cci at 10d20000 {
+	cci: cci at 10d20000 {
 		compatible = "arm,cci-400";
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
2.2.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm: dts: disable CCI on exynos420 based arndale-octa
  2015-01-10  3:11   ` Abhilash Kesavan
@ 2015-01-13  2:05     ` Olof Johansson
  -1 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2015-01-13  2:05 UTC (permalink / raw)
  To: Abhilash Kesavan
  Cc: kgene.kim, linux-arm-kernel, arm, arnd, khilman,
	linux-samsung-soc, kesavan.abhilash, sudeep.holla, nicolas.pitre,
	Punit.Agrawal, Will.Deacon, Mark.Rutland, k.kozlowski

On Sat, Jan 10, 2015 at 08:41:36AM +0530, Abhilash Kesavan wrote:
> The arndale-octa board was giving "imprecise external aborts" during
> boot-up with MCPM enabled. CCI enablement of the boot cluster was found
> to be the cause of these aborts (possibly because the secure f/w was not
> allowing it). Hence, disable CCI for the arndale-octa board.
> 
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Tested-by: Kevin Hilman <khilman@linaro.org>
> Tested-by: Tyler Baker <tyler.baker@linaro.org>

Applied 1-2 to fixes for 3.19.

Fixed two typos (arm->ARM in subject, and 420->5420).


Thanks,

-Olof

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 2/2] arm: dts: disable CCI on exynos420 based arndale-octa
@ 2015-01-13  2:05     ` Olof Johansson
  0 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2015-01-13  2:05 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, Jan 10, 2015 at 08:41:36AM +0530, Abhilash Kesavan wrote:
> The arndale-octa board was giving "imprecise external aborts" during
> boot-up with MCPM enabled. CCI enablement of the boot cluster was found
> to be the cause of these aborts (possibly because the secure f/w was not
> allowing it). Hence, disable CCI for the arndale-octa board.
> 
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Tested-by: Kevin Hilman <khilman@linaro.org>
> Tested-by: Tyler Baker <tyler.baker@linaro.org>

Applied 1-2 to fixes for 3.19.

Fixed two typos (arm->ARM in subject, and 420->5420).


Thanks,

-Olof

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-01-13  2:05 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-10  3:11 [PATCH 1/2] drivers: bus: check cci device tree node status Abhilash Kesavan
2015-01-10  3:11 ` Abhilash Kesavan
2015-01-10  3:11 ` [PATCH 2/2] arm: dts: disable CCI on exynos420 based arndale-octa Abhilash Kesavan
2015-01-10  3:11   ` Abhilash Kesavan
2015-01-13  2:05   ` Olof Johansson
2015-01-13  2:05     ` Olof Johansson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.