* [GIT PULL] EFI changes for next
@ 2015-01-05 19:28 Ricardo Neri
2015-01-06 13:04 ` Matt Fleming
0 siblings, 1 reply; 3+ messages in thread
From: Ricardo Neri @ 2015-01-05 19:28 UTC (permalink / raw)
To: Fleming, Matt
Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA, Peter Jones, Borislav Petkov
Hi Matt,
Please pull the following changes for next. This includes a change in
the help text of EFI firmware Kconfig to update the URL of efibootgr.
It also renames the efi_guid_unparse to reflect better the behavior of
the function.
Thanks and BR,
Ricardo
The following changes since commit
b7392d2247cfe6771f95d256374f1a8e6a6f48d6:
Linux 3.19-rc2 (2014-12-28 16:49:37 -0800)
are available in the git repository at:
https://github.com/ricardon/efi.git tags/rneri-efi-next
for you to fetch changes up to 2364a022398a7cda70494cf53b1b529bf88830b0:
efi: mv efi_guid_unparse -> efi_guid_to_str (2014-12-31 16:40:09
-0800)
----------------------------------------------------------------
Updates on EFI firmware Kconfig help text and a function rename
----------------------------------------------------------------
Borislav Petkov (1):
efi: mv efi_guid_unparse -> efi_guid_to_str
Peter Jones (1):
Update the URLs for efibootmgr.
block/partitions/efi.c | 2 +-
drivers/firmware/efi/Kconfig | 4 ++--
drivers/firmware/efi/efi.c | 4 ++--
drivers/firmware/efi/efivars.c | 6 +++---
fs/efivarfs/super.c | 2 +-
include/linux/efi.h | 2 +-
6 files changed, 10 insertions(+), 10 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GIT PULL] EFI changes for next
2015-01-05 19:28 [GIT PULL] EFI changes for next Ricardo Neri
@ 2015-01-06 13:04 ` Matt Fleming
[not found] ` <20150106130436.GJ3163-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Matt Fleming @ 2015-01-06 13:04 UTC (permalink / raw)
To: Ricardo Neri
Cc: Fleming, Matt, linux-efi-u79uwXL29TY76Z2rM5mHXA, Peter Jones,
Borislav Petkov
On Mon, 05 Jan, at 11:28:09AM, Ricardo Neri wrote:
> Hi Matt,
>
> Please pull the following changes for next. This includes a change in
> the help text of EFI firmware Kconfig to update the URL of efibootgr.
>
> It also renames the efi_guid_unparse to reflect better the behavior of
> the function.
>
> Thanks and BR,
> Ricardo
>
> The following changes since commit
> b7392d2247cfe6771f95d256374f1a8e6a6f48d6:
>
> Linux 3.19-rc2 (2014-12-28 16:49:37 -0800)
Is there a reason that you based the patches onto -rc2?
What I tend to do is try and apply the patches onto the existing EFI
'next' branch first. If they don't apply only then will I rebase 'next'
onto a more recent release tag.
This is a habit I picked up from the tip folks, and it keeps the history
much cleaner.
Both of the below commits apply cleanly on 'next' (which is based on
v3.18-rc2). Could you send me another pull request against 'next'?
Thanks!
> are available in the git repository at:
>
> https://github.com/ricardon/efi.git tags/rneri-efi-next
>
> for you to fetch changes up to 2364a022398a7cda70494cf53b1b529bf88830b0:
>
> efi: mv efi_guid_unparse -> efi_guid_to_str (2014-12-31 16:40:09
> -0800)
>
> ----------------------------------------------------------------
> Updates on EFI firmware Kconfig help text and a function rename
>
> ----------------------------------------------------------------
> Borislav Petkov (1):
> efi: mv efi_guid_unparse -> efi_guid_to_str
Borislav, you're renaming the function, not moving it. The rest of the
commit log is fine but how about rewording the title to,
"efi: Rename efi_guid_unparse to efi_guid_to_str"
I don't think you need to resubmit it, I'd usually fix this up when I
applied your patch, so Ricardo can do that before he resends his pull.
> Peter Jones (1):
> Update the URLs for efibootmgr.
This commit needs a subsystem prefix ("efi:"), and we should probably Cc
Matt Domsch too. Ricardo could you take care of this, unless Peter
objects?
--
Matt Fleming, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GIT PULL] EFI changes for next
[not found] ` <20150106130436.GJ3163-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
@ 2015-01-10 4:45 ` Ricardo Neri
0 siblings, 0 replies; 3+ messages in thread
From: Ricardo Neri @ 2015-01-10 4:45 UTC (permalink / raw)
To: Matt Fleming
Cc: Fleming, Matt, linux-efi-u79uwXL29TY76Z2rM5mHXA, Peter Jones,
Borislav Petkov
On Tue, 2015-01-06 at 13:04 +0000, Matt Fleming wrote:
> On Mon, 05 Jan, at 11:28:09AM, Ricardo Neri wrote:
> > Hi Matt,
> >
> > Please pull the following changes for next. This includes a change in
> > the help text of EFI firmware Kconfig to update the URL of efibootgr.
> >
> > It also renames the efi_guid_unparse to reflect better the behavior of
> > the function.
> >
> > Thanks and BR,
> > Ricardo
> >
> > The following changes since commit
> > b7392d2247cfe6771f95d256374f1a8e6a6f48d6:
> >
> > Linux 3.19-rc2 (2014-12-28 16:49:37 -0800)
>
> Is there a reason that you based the patches onto -rc2?
This is a mistake on my side, I wrongly assumed that you rebased next on
the most recent Linus' tree.
>
> What I tend to do is try and apply the patches onto the existing EFI
> 'next' branch first. If they don't apply only then will I rebase 'next'
> onto a more recent release tag.
>
> This is a habit I picked up from the tip folks, and it keeps the history
> much cleaner.
Thanks for the explanation!
>
> Both of the below commits apply cleanly on 'next' (which is based on
> v3.18-rc2). Could you send me another pull request against 'next'?
> Thanks!
>
> > are available in the git repository at:
> >
> > https://github.com/ricardon/efi.git tags/rneri-efi-next
> >
> > for you to fetch changes up to 2364a022398a7cda70494cf53b1b529bf88830b0:
> >
> > efi: mv efi_guid_unparse -> efi_guid_to_str (2014-12-31 16:40:09
> > -0800)
> >
> > ----------------------------------------------------------------
> > Updates on EFI firmware Kconfig help text and a function rename
> >
> > ----------------------------------------------------------------
> > Borislav Petkov (1):
> > efi: mv efi_guid_unparse -> efi_guid_to_str
>
> Borislav, you're renaming the function, not moving it. The rest of the
> commit log is fine but how about rewording the title to,
>
> "efi: Rename efi_guid_unparse to efi_guid_to_str"
I took care of this in v2 of my pull request.
>
> I don't think you need to resubmit it, I'd usually fix this up when I
> applied your patch, so Ricardo can do that before he resends his pull.
>
> > Peter Jones (1):
> > Update the URLs for efibootmgr.
>
> This commit needs a subsystem prefix ("efi:"), and we should probably Cc
> Matt Domsch too. Ricardo could you take care of this, unless Peter
> objects?
ditto.
Thanks and BR,
Ricardo
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-10 4:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-05 19:28 [GIT PULL] EFI changes for next Ricardo Neri
2015-01-06 13:04 ` Matt Fleming
[not found] ` <20150106130436.GJ3163-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2015-01-10 4:45 ` Ricardo Neri
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.