* Re: [PATCH] gpu:drm:Change calls to mdelay to msleep in the functions,send_pkg_prepare and send_pkg_done for the file,mdfld_dsi_pkg_sender.c
[not found] <1420950664-18875-1-git-send-email-xerofoify@gmail.com>
@ 2015-01-12 13:29 ` Alan Cox
0 siblings, 0 replies; 6+ messages in thread
From: Alan Cox @ 2015-01-12 13:29 UTC (permalink / raw)
To: Nicholas Krause
Cc: airlied, airlied, damien.lespiau, treding, dri-devel, linux-kernel
On Sat, 2015-01-10 at 23:31 -0500, Nicholas Krause wrote:
> Changes various calls in the functions,send_pkg_prepare and send_pkg_done
> for mdelay to msleep. These changes are needed due to use working with
> various sleep modes supported by this hardware and thus needing to sleep
> for a small duration instead of using the respectful delay function due
> to the need to sleep rather then busy loop the CPU(s) and waste CPU cycles
> on the system that could be used to handle other tasks.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
NAK
Like every other TODO you've been mucking with at random this one is
there for a reason.
We can't sleep at this point.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gpu:drm:Change calls to mdelay to msleep in the functions,send_pkg_prepare and send_pkg_done for the file,mdfld_dsi_pkg_sender.c
@ 2015-01-12 13:29 ` Alan Cox
0 siblings, 0 replies; 6+ messages in thread
From: Alan Cox @ 2015-01-12 13:29 UTC (permalink / raw)
To: Nicholas Krause; +Cc: linux-kernel, dri-devel, airlied, treding
On Sat, 2015-01-10 at 23:31 -0500, Nicholas Krause wrote:
> Changes various calls in the functions,send_pkg_prepare and send_pkg_done
> for mdelay to msleep. These changes are needed due to use working with
> various sleep modes supported by this hardware and thus needing to sleep
> for a small duration instead of using the respectful delay function due
> to the need to sleep rather then busy loop the CPU(s) and waste CPU cycles
> on the system that could be used to handle other tasks.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
NAK
Like every other TODO you've been mucking with at random this one is
there for a reason.
We can't sleep at this point.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gpu:drm:Change calls to mdelay to msleep in the functions,send_pkg_prepare and send_pkg_done for the file,mdfld_dsi_pkg_sender.c
2015-01-12 13:29 ` Alan Cox
@ 2015-01-12 16:12 ` Thierry Reding
-1 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2015-01-12 16:12 UTC (permalink / raw)
To: Alan Cox
Cc: Nicholas Krause, airlied, airlied, damien.lespiau, dri-devel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]
On Mon, Jan 12, 2015 at 01:29:27PM +0000, Alan Cox wrote:
> On Sat, 2015-01-10 at 23:31 -0500, Nicholas Krause wrote:
> > Changes various calls in the functions,send_pkg_prepare and send_pkg_done
> > for mdelay to msleep. These changes are needed due to use working with
> > various sleep modes supported by this hardware and thus needing to sleep
> > for a small duration instead of using the respectful delay function due
> > to the need to sleep rather then busy loop the CPU(s) and waste CPU cycles
> > on the system that could be used to handle other tasks.
> >
> > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>
> NAK
>
> Like every other TODO you've been mucking with at random this one is
> there for a reason.
>
> We can't sleep at this point.
From a quick look it seems like the only reason why we can't sleep is
because sender->lock is a spinlock. But it would seem that it could
simply be a mutex, in which case the delays could become sleeps.
Do you happen to remember if there were specific reasons to make this a
spinlock rather than a mutex?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gpu:drm:Change calls to mdelay to msleep in the functions,send_pkg_prepare and send_pkg_done for the file,mdfld_dsi_pkg_sender.c
@ 2015-01-12 16:12 ` Thierry Reding
0 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2015-01-12 16:12 UTC (permalink / raw)
To: Alan Cox
Cc: Nicholas Krause, airlied, airlied, damien.lespiau, dri-devel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]
On Mon, Jan 12, 2015 at 01:29:27PM +0000, Alan Cox wrote:
> On Sat, 2015-01-10 at 23:31 -0500, Nicholas Krause wrote:
> > Changes various calls in the functions,send_pkg_prepare and send_pkg_done
> > for mdelay to msleep. These changes are needed due to use working with
> > various sleep modes supported by this hardware and thus needing to sleep
> > for a small duration instead of using the respectful delay function due
> > to the need to sleep rather then busy loop the CPU(s) and waste CPU cycles
> > on the system that could be used to handle other tasks.
> >
> > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>
> NAK
>
> Like every other TODO you've been mucking with at random this one is
> there for a reason.
>
> We can't sleep at this point.
From a quick look it seems like the only reason why we can't sleep is
because sender->lock is a spinlock. But it would seem that it could
simply be a mutex, in which case the delays could become sleeps.
Do you happen to remember if there were specific reasons to make this a
spinlock rather than a mutex?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gpu:drm:Change calls to mdelay to msleep in the functions,send_pkg_prepare and send_pkg_done for the file,mdfld_dsi_pkg_sender.c
2015-01-12 16:12 ` Thierry Reding
@ 2015-01-12 16:14 ` Alan Cox
-1 siblings, 0 replies; 6+ messages in thread
From: Alan Cox @ 2015-01-12 16:14 UTC (permalink / raw)
To: Thierry Reding
Cc: Nicholas Krause, airlied, airlied, damien.lespiau, dri-devel,
linux-kernel
On Mon, 2015-01-12 at 17:12 +0100, Thierry Reding wrote:
> On Mon, Jan 12, 2015 at 01:29:27PM +0000, Alan Cox wrote:
> > On Sat, 2015-01-10 at 23:31 -0500, Nicholas Krause wrote:
> > > Changes various calls in the functions,send_pkg_prepare and send_pkg_done
> > > for mdelay to msleep. These changes are needed due to use working with
> > > various sleep modes supported by this hardware and thus needing to sleep
> > > for a small duration instead of using the respectful delay function due
> > > to the need to sleep rather then busy loop the CPU(s) and waste CPU cycles
> > > on the system that could be used to handle other tasks.
> > >
> > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> >
> > NAK
> >
> > Like every other TODO you've been mucking with at random this one is
> > there for a reason.
> >
> > We can't sleep at this point.
>
> From a quick look it seems like the only reason why we can't sleep is
> because sender->lock is a spinlock. But it would seem that it could
> simply be a mutex, in which case the delays could become sleeps.
>
> Do you happen to remember if there were specific reasons to make this a
> spinlock rather than a mutex?
I don't remember the full details and since I don't currently have a
test platform for it, and its obsolete I don't want to touch it.
If someone else does fine, but they need to verify it on real hardware.
Alan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gpu:drm:Change calls to mdelay to msleep in the functions,send_pkg_prepare and send_pkg_done for the file,mdfld_dsi_pkg_sender.c
@ 2015-01-12 16:14 ` Alan Cox
0 siblings, 0 replies; 6+ messages in thread
From: Alan Cox @ 2015-01-12 16:14 UTC (permalink / raw)
To: Thierry Reding; +Cc: Nicholas Krause, linux-kernel, dri-devel, airlied
On Mon, 2015-01-12 at 17:12 +0100, Thierry Reding wrote:
> On Mon, Jan 12, 2015 at 01:29:27PM +0000, Alan Cox wrote:
> > On Sat, 2015-01-10 at 23:31 -0500, Nicholas Krause wrote:
> > > Changes various calls in the functions,send_pkg_prepare and send_pkg_done
> > > for mdelay to msleep. These changes are needed due to use working with
> > > various sleep modes supported by this hardware and thus needing to sleep
> > > for a small duration instead of using the respectful delay function due
> > > to the need to sleep rather then busy loop the CPU(s) and waste CPU cycles
> > > on the system that could be used to handle other tasks.
> > >
> > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> >
> > NAK
> >
> > Like every other TODO you've been mucking with at random this one is
> > there for a reason.
> >
> > We can't sleep at this point.
>
> From a quick look it seems like the only reason why we can't sleep is
> because sender->lock is a spinlock. But it would seem that it could
> simply be a mutex, in which case the delays could become sleeps.
>
> Do you happen to remember if there were specific reasons to make this a
> spinlock rather than a mutex?
I don't remember the full details and since I don't currently have a
test platform for it, and its obsolete I don't want to touch it.
If someone else does fine, but they need to verify it on real hardware.
Alan
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-01-12 16:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1420950664-18875-1-git-send-email-xerofoify@gmail.com>
2015-01-12 13:29 ` [PATCH] gpu:drm:Change calls to mdelay to msleep in the functions,send_pkg_prepare and send_pkg_done for the file,mdfld_dsi_pkg_sender.c Alan Cox
2015-01-12 13:29 ` Alan Cox
2015-01-12 16:12 ` Thierry Reding
2015-01-12 16:12 ` Thierry Reding
2015-01-12 16:14 ` Alan Cox
2015-01-12 16:14 ` Alan Cox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.