All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Eddie Huang <eddie.huang@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	devicetree@vger.kernel.org,
	Vladimir Murzin <vladimir.murzin@arm.com>,
	srv_heupstream@mediatek.com, Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	yh.chen@mediatek.com, Howard Chen <ibanezchen@gmail.com>,
	Ashwin Chaugule <ashwin.chaugule@linaro.org>,
	linux-serial@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
	"Joe.C" <yingjoe.chen@mediatek.com>, Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH v2 1/4] tty: serial: Add 8250 earlycon to support noinit option
Date: Mon, 12 Jan 2015 16:08:38 +0000	[thread overview]
Message-ID: <1421078918.31978.32.camel@linux.intel.com> (raw)
In-Reply-To: <3712986.8SuKNvhKTk@wuerfel>

On Mon, 2015-01-12 at 16:35 +0100, Arnd Bergmann wrote:
> On Monday 12 January 2015 21:08:21 Eddie Huang wrote:
> > Add earlycon support not only baudrate option, but also add noinit option.
> > If use noinit option, 8250 earlycon will not init serial hardware and use
> > loader setting.
> > 
> > Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
> 
> I probably missed something in the previous discussion, but why is
> "noinit" not just the default? I believe that is how we handle early
> serial ports on PowerPC, and I see no downsides to it.

Most PC hardware at least needs the port initialised to use it. It won't
have been configured by the firmware in many cases.

Alan



WARNING: multiple messages have this Message-ID (diff)
From: alan@linux.intel.com (Alan Cox)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] tty: serial: Add 8250 earlycon to support noinit option
Date: Mon, 12 Jan 2015 16:08:38 +0000	[thread overview]
Message-ID: <1421078918.31978.32.camel@linux.intel.com> (raw)
In-Reply-To: <3712986.8SuKNvhKTk@wuerfel>

On Mon, 2015-01-12 at 16:35 +0100, Arnd Bergmann wrote:
> On Monday 12 January 2015 21:08:21 Eddie Huang wrote:
> > Add earlycon support not only baudrate option, but also add noinit option.
> > If use noinit option, 8250 earlycon will not init serial hardware and use
> > loader setting.
> > 
> > Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
> 
> I probably missed something in the previous discussion, but why is
> "noinit" not just the default? I believe that is how we handle early
> serial ports on PowerPC, and I see no downsides to it.

Most PC hardware at least needs the port initialised to use it. It won't
have been configured by the firmware in many cases.

Alan

  reply	other threads:[~2015-01-12 16:09 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12 13:08 [PATCH v2 0/4] tty: serial: Add earlycon support to MT8173 SoC Eddie Huang
2015-01-12 13:08 ` Eddie Huang
2015-01-12 13:08 ` [PATCH v2 1/4] tty: serial: Add 8250 earlycon to support noinit option Eddie Huang
2015-01-12 13:08   ` Eddie Huang
2015-01-12 15:35   ` Arnd Bergmann
2015-01-12 15:35     ` Arnd Bergmann
2015-01-12 16:08     ` Alan Cox [this message]
2015-01-12 16:08       ` Alan Cox
2015-01-13  1:05       ` Eddie Huang
2015-01-13  1:05         ` Eddie Huang
2015-02-01 16:27   ` Peter Hurley
2015-02-01 16:27     ` Peter Hurley
2015-02-01 16:27     ` Peter Hurley
2015-02-01 18:26     ` Peter Hurley
2015-02-01 18:26       ` Peter Hurley
2015-02-01 18:26       ` Peter Hurley
2015-02-02  3:16       ` Eddie Huang
2015-02-02  3:16         ` Eddie Huang
2015-02-02  3:45         ` Peter Hurley
2015-02-02  3:45           ` Peter Hurley
2015-02-02  4:28           ` Greg Kroah-Hartman
2015-02-02  4:28             ` Greg Kroah-Hartman
2015-02-02  5:15             ` Peter Hurley
2015-02-02  5:15               ` Peter Hurley
2015-02-02  5:24               ` Greg Kroah-Hartman
2015-02-02  5:24                 ` Greg Kroah-Hartman
2015-02-02  5:33                 ` Eddie Huang
2015-02-02  5:33                   ` Eddie Huang
2015-02-02  5:43                   ` Peter Hurley
2015-02-02  5:43                     ` Peter Hurley
2015-02-02  5:43                     ` Peter Hurley
2015-02-02 18:46                     ` Greg Kroah-Hartman
2015-02-02 18:46                       ` Greg Kroah-Hartman
2015-02-02  2:45     ` Eddie Huang
2015-02-02  2:45       ` Eddie Huang
2015-02-02  3:27       ` Peter Hurley
2015-02-02  3:27         ` Peter Hurley
2015-01-12 13:08 ` [PATCH v2 2/4] tty: serial: 8250_mtk: Add earlycon Eddie Huang
2015-01-12 13:08   ` Eddie Huang
2015-01-12 13:08 ` [PATCH v2 3/4] arm64: dts: Add mediatek MT8173 earlycon support Eddie Huang
2015-01-12 13:08   ` Eddie Huang
2015-01-12 13:08 ` [PATCH v2 4/4] Document: Modify 8250 earlycon kernel parameters Eddie Huang
2015-01-12 13:08   ` Eddie Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421078918.31978.32.camel@linux.intel.com \
    --to=alan@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=ashwin.chaugule@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=eddie.huang@mediatek.com \
    --cc=galak@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ibanezchen@gmail.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jslaby@suse.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=vladimir.murzin@arm.com \
    --cc=will.deacon@arm.com \
    --cc=yh.chen@mediatek.com \
    --cc=yingjoe.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.