All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: linux-fsdevel@vger.kernel.org
Cc: xfs@oss.sgi.com, cluster-devel@redhat.com,
	ocfs2-devel@oss.oracle.com, Jan Kara <jack@suse.cz>
Subject: [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces
Date: Fri, 16 Jan 2015 13:47:34 +0100	[thread overview]
Message-ID: <1421412471-4747-1-git-send-email-jack@suse.cz> (raw)

  Hello,

  this is another iteration of patches to unify VFS and XFS quota interfaces so
that XFS quotactls work for filesystems with VFS quotas and vice versa.  This
is useful so that userspace doesn't have to care that much about which
filesystem it is using at least when using basic quota functionality. In
particular we should be able to reuse project quota tests in xfstests for ext4.

The patches are based on quota cleanup series [1] and XFS cleanup series [2]
I've sent previously and based on 3.19-rc4 + for-next branch of XFS tree.  I
could further split this series into per-quotactl series but frankly I don't
think it will help reviewers in any way (the patches in the current series are
already ordered by quotactl).

I would like to get some review especially of the fs-specific parts of the
series - mostly for XFS where things aren't always trivial.

Some more details about the series below:

In this patch set I unify quotaon / quotaoff handling (Q_QUOTAON, Q_QUOTAOFF,
Q_XQUOTAON, Q_XQUOTAOFF calls), fix some bugs in the Q_XGETQUOTA, Q_XSETQLIM,
Q_GETQUOTA, Q_SETQUOTA calls done by Christoph some time ago, unify
Q_GETXSTATE, Q_GETXSTATV with Q_GETINFO, and also wire up Q_SETINFO to work
with XFS (and Q_XSETQLIM for id 0 to modify time limits for VFS quotas).
So after these patches xfs_quota can manipulate quotas for ext4 filesystem and
similarly quota-tools can be used to manipulate quotas for xfs filesystem.

I have also verified that xfstests pass fine both for xfs and ext4 so
hopefully I didn't introduce any regression in the current functionality (I
also did a couple of manual checks for timer setting etc).

All the comments to the first version of the series are hopefully addressed,
except for Dave's request to reduce number of copying of dquot information -
I have benchmarked that reducing number of copies from 3 to 2 brings just 2%
improvement in speed in my test setup and getting quota information isn't IMHO
so performance critical that it would be worth the complications of the code.

								Honza

[1] http://www.spinics.net/lists/linux-fsdevel/msg81903.html
[2] http://www.spinics.net/lists/xfs/msg31389.html


WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: linux-fsdevel@vger.kernel.org
Cc: cluster-devel@redhat.com, Jan Kara <jack@suse.cz>,
	ocfs2-devel@oss.oracle.com, xfs@oss.sgi.com
Subject: [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces
Date: Fri, 16 Jan 2015 13:47:34 +0100	[thread overview]
Message-ID: <1421412471-4747-1-git-send-email-jack@suse.cz> (raw)

  Hello,

  this is another iteration of patches to unify VFS and XFS quota interfaces so
that XFS quotactls work for filesystems with VFS quotas and vice versa.  This
is useful so that userspace doesn't have to care that much about which
filesystem it is using at least when using basic quota functionality. In
particular we should be able to reuse project quota tests in xfstests for ext4.

The patches are based on quota cleanup series [1] and XFS cleanup series [2]
I've sent previously and based on 3.19-rc4 + for-next branch of XFS tree.  I
could further split this series into per-quotactl series but frankly I don't
think it will help reviewers in any way (the patches in the current series are
already ordered by quotactl).

I would like to get some review especially of the fs-specific parts of the
series - mostly for XFS where things aren't always trivial.

Some more details about the series below:

In this patch set I unify quotaon / quotaoff handling (Q_QUOTAON, Q_QUOTAOFF,
Q_XQUOTAON, Q_XQUOTAOFF calls), fix some bugs in the Q_XGETQUOTA, Q_XSETQLIM,
Q_GETQUOTA, Q_SETQUOTA calls done by Christoph some time ago, unify
Q_GETXSTATE, Q_GETXSTATV with Q_GETINFO, and also wire up Q_SETINFO to work
with XFS (and Q_XSETQLIM for id 0 to modify time limits for VFS quotas).
So after these patches xfs_quota can manipulate quotas for ext4 filesystem and
similarly quota-tools can be used to manipulate quotas for xfs filesystem.

I have also verified that xfstests pass fine both for xfs and ext4 so
hopefully I didn't introduce any regression in the current functionality (I
also did a couple of manual checks for timer setting etc).

All the comments to the first version of the series are hopefully addressed,
except for Dave's request to reduce number of copying of dquot information -
I have benchmarked that reducing number of copies from 3 to 2 brings just 2%
improvement in speed in my test setup and getting quota information isn't IMHO
so performance critical that it would be worth the complications of the code.

								Honza

[1] http://www.spinics.net/lists/linux-fsdevel/msg81903.html
[2] http://www.spinics.net/lists/xfs/msg31389.html

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: linux-fsdevel@vger.kernel.org
Cc: xfs@oss.sgi.com, cluster-devel@redhat.com,
	ocfs2-devel@oss.oracle.com, Jan Kara <jack@suse.cz>
Subject: [Ocfs2-devel] [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces
Date: Fri, 16 Jan 2015 13:47:34 +0100	[thread overview]
Message-ID: <1421412471-4747-1-git-send-email-jack@suse.cz> (raw)

  Hello,

  this is another iteration of patches to unify VFS and XFS quota interfaces so
that XFS quotactls work for filesystems with VFS quotas and vice versa.  This
is useful so that userspace doesn't have to care that much about which
filesystem it is using at least when using basic quota functionality. In
particular we should be able to reuse project quota tests in xfstests for ext4.

The patches are based on quota cleanup series [1] and XFS cleanup series [2]
I've sent previously and based on 3.19-rc4 + for-next branch of XFS tree.  I
could further split this series into per-quotactl series but frankly I don't
think it will help reviewers in any way (the patches in the current series are
already ordered by quotactl).

I would like to get some review especially of the fs-specific parts of the
series - mostly for XFS where things aren't always trivial.

Some more details about the series below:

In this patch set I unify quotaon / quotaoff handling (Q_QUOTAON, Q_QUOTAOFF,
Q_XQUOTAON, Q_XQUOTAOFF calls), fix some bugs in the Q_XGETQUOTA, Q_XSETQLIM,
Q_GETQUOTA, Q_SETQUOTA calls done by Christoph some time ago, unify
Q_GETXSTATE, Q_GETXSTATV with Q_GETINFO, and also wire up Q_SETINFO to work
with XFS (and Q_XSETQLIM for id 0 to modify time limits for VFS quotas).
So after these patches xfs_quota can manipulate quotas for ext4 filesystem and
similarly quota-tools can be used to manipulate quotas for xfs filesystem.

I have also verified that xfstests pass fine both for xfs and ext4 so
hopefully I didn't introduce any regression in the current functionality (I
also did a couple of manual checks for timer setting etc).

All the comments to the first version of the series are hopefully addressed,
except for Dave's request to reduce number of copying of dquot information -
I have benchmarked that reducing number of copies from 3 to 2 brings just 2%
improvement in speed in my test setup and getting quota information isn't IMHO
so performance critical that it would be worth the complications of the code.

								Honza

[1] http://www.spinics.net/lists/linux-fsdevel/msg81903.html
[2] http://www.spinics.net/lists/xfs/msg31389.html

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces
Date: Fri, 16 Jan 2015 13:47:34 +0100	[thread overview]
Message-ID: <1421412471-4747-1-git-send-email-jack@suse.cz> (raw)

  Hello,

  this is another iteration of patches to unify VFS and XFS quota interfaces so
that XFS quotactls work for filesystems with VFS quotas and vice versa.  This
is useful so that userspace doesn't have to care that much about which
filesystem it is using at least when using basic quota functionality. In
particular we should be able to reuse project quota tests in xfstests for ext4.

The patches are based on quota cleanup series [1] and XFS cleanup series [2]
I've sent previously and based on 3.19-rc4 + for-next branch of XFS tree.  I
could further split this series into per-quotactl series but frankly I don't
think it will help reviewers in any way (the patches in the current series are
already ordered by quotactl).

I would like to get some review especially of the fs-specific parts of the
series - mostly for XFS where things aren't always trivial.

Some more details about the series below:

In this patch set I unify quotaon / quotaoff handling (Q_QUOTAON, Q_QUOTAOFF,
Q_XQUOTAON, Q_XQUOTAOFF calls), fix some bugs in the Q_XGETQUOTA, Q_XSETQLIM,
Q_GETQUOTA, Q_SETQUOTA calls done by Christoph some time ago, unify
Q_GETXSTATE, Q_GETXSTATV with Q_GETINFO, and also wire up Q_SETINFO to work
with XFS (and Q_XSETQLIM for id 0 to modify time limits for VFS quotas).
So after these patches xfs_quota can manipulate quotas for ext4 filesystem and
similarly quota-tools can be used to manipulate quotas for xfs filesystem.

I have also verified that xfstests pass fine both for xfs and ext4 so
hopefully I didn't introduce any regression in the current functionality (I
also did a couple of manual checks for timer setting etc).

All the comments to the first version of the series are hopefully addressed,
except for Dave's request to reduce number of copying of dquot information -
I have benchmarked that reducing number of copies from 3 to 2 brings just 2%
improvement in speed in my test setup and getting quota information isn't IMHO
so performance critical that it would be worth the complications of the code.

								Honza

[1] http://www.spinics.net/lists/linux-fsdevel/msg81903.html
[2] http://www.spinics.net/lists/xfs/msg31389.html



             reply	other threads:[~2015-01-16 12:48 UTC|newest]

Thread overview: 150+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16 12:47 Jan Kara [this message]
2015-01-16 12:47 ` [Cluster-devel] [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces Jan Kara
2015-01-16 12:47 ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` Jan Kara
2015-01-16 12:47 ` [PATCH 01/17] quota: Split ->set_xstate callback into two Jan Kara
2015-01-16 12:47   ` [Cluster-devel] " Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47   ` Jan Kara
2015-01-19  9:00   ` Christoph Hellwig
2015-01-19  9:00     ` [Cluster-devel] " Christoph Hellwig
2015-01-19  9:00     ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19  9:00     ` Christoph Hellwig
2015-01-16 12:47 ` [PATCH 02/17] quota: Wire up ->quota_{enable,disable} callbacks into Q_QUOTA{ON,OFF} Jan Kara
2015-01-16 12:47   ` [Cluster-devel] [PATCH 02/17] quota: Wire up ->quota_{enable, disable} callbacks into Q_QUOTA{ON, OFF} Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47   ` Jan Kara
2015-01-19  9:01   ` [PATCH 02/17] quota: Wire up ->quota_{enable,disable} callbacks into Q_QUOTA{ON,OFF} Christoph Hellwig
2015-01-19  9:01     ` [Cluster-devel] [PATCH 02/17] quota: Wire up ->quota_{enable, disable} callbacks into Q_QUOTA{ON, OFF} Christoph Hellwig
2015-01-19  9:01     ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19  9:01     ` [PATCH 02/17] quota: Wire up ->quota_{enable,disable} callbacks into Q_QUOTA{ON,OFF} Christoph Hellwig
2015-01-20 17:01     ` Jan Kara
2015-01-20 17:01       ` [Cluster-devel] [PATCH 02/17] quota: Wire up ->quota_{enable, disable} callbacks into Q_QUOTA{ON, OFF} Jan Kara
2015-01-20 17:01       ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` [PATCH 03/17] quota: Add ->quota_{enable, disable} callbacks for VFS quotas Jan Kara
2015-01-16 12:47   ` [Cluster-devel] " Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-19  9:02   ` [PATCH 03/17] quota: Add ->quota_{enable,disable} " Christoph Hellwig
2015-01-19  9:02     ` [Cluster-devel] [PATCH 03/17] quota: Add ->quota_{enable, disable} " Christoph Hellwig
2015-01-19  9:02     ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19  9:02     ` [PATCH 03/17] quota: Add ->quota_{enable,disable} " Christoph Hellwig
2015-01-20 17:08     ` Jan Kara
2015-01-20 17:08       ` [Cluster-devel] [PATCH 03/17] quota: Add ->quota_{enable, disable} " Jan Kara
2015-01-20 17:08       ` [Ocfs2-devel] " Jan Kara
2015-01-20 17:08       ` [PATCH 03/17] quota: Add ->quota_{enable,disable} " Jan Kara
2015-01-16 12:47 ` [PATCH 04/17] ext4: Use generic helpers for quotaon and quotaoff Jan Kara
2015-01-16 12:47   ` [Cluster-devel] " Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-19  9:03   ` Christoph Hellwig
2015-01-19  9:03     ` [Cluster-devel] " Christoph Hellwig
2015-01-19  9:03     ` [Ocfs2-devel] " Christoph Hellwig
2015-01-16 12:47 ` [PATCH 05/17] ocfs2: " Jan Kara
2015-01-16 12:47   ` [Cluster-devel] " Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47   ` Jan Kara
2015-01-19  9:03   ` Christoph Hellwig
2015-01-19  9:03     ` [Cluster-devel] " Christoph Hellwig
2015-01-19  9:03     ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19  9:03     ` Christoph Hellwig
2015-01-20 17:13     ` Jan Kara
2015-01-20 17:13       ` [Cluster-devel] " Jan Kara
2015-01-20 17:13       ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47 ` [PATCH 06/17] quota: Remove quota_on_meta callback Jan Kara
2015-01-16 12:47   ` [Cluster-devel] " Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47   ` Jan Kara
2015-01-19  9:04   ` Christoph Hellwig
2015-01-19  9:04     ` [Cluster-devel] " Christoph Hellwig
2015-01-19  9:04     ` [Ocfs2-devel] " Christoph Hellwig
2015-01-16 12:47 ` [PATCH 07/17] quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units Jan Kara
2015-01-16 12:47   ` [Cluster-devel] " Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47   ` Jan Kara
2015-01-19  9:07   ` Christoph Hellwig
2015-01-19  9:07     ` [Cluster-devel] " Christoph Hellwig
2015-01-19  9:07     ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19  9:07     ` Christoph Hellwig
2015-01-20 16:53     ` Jan Kara
2015-01-20 16:53       ` [Cluster-devel] " Jan Kara
2015-01-20 16:53       ` [Ocfs2-devel] " Jan Kara
2015-01-20 16:53       ` Jan Kara
2015-01-16 12:47 ` [PATCH 08/17] quota: Store maximum space limit in bytes Jan Kara
2015-01-16 12:47   ` [Cluster-devel] " Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47   ` Jan Kara
2015-01-19  9:07   ` Christoph Hellwig
2015-01-19  9:07     ` [Cluster-devel] " Christoph Hellwig
2015-01-19  9:07     ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19  9:07     ` Christoph Hellwig
2015-01-16 12:47 ` [PATCH 09/17] quota: Make Q_XQUOTASYNC support VFS quota syncing Jan Kara
2015-01-16 12:47   ` [Cluster-devel] " Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47   ` Jan Kara
2015-01-19  9:09   ` Christoph Hellwig
2015-01-19  9:09     ` [Cluster-devel] " Christoph Hellwig
2015-01-19  9:09     ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19  9:09     ` Christoph Hellwig
2015-01-20 17:16     ` Jan Kara
2015-01-20 17:16       ` [Cluster-devel] " Jan Kara
2015-01-20 17:16       ` [Ocfs2-devel] " Jan Kara
2015-01-20 17:16       ` Jan Kara
2015-01-16 12:47 ` [PATCH 10/17] quota: Make VFS quotas use new interface for getting quota info Jan Kara
2015-01-16 12:47   ` [Cluster-devel] " Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47   ` Jan Kara
2015-01-19  9:10   ` Christoph Hellwig
2015-01-19  9:10     ` [Cluster-devel] " Christoph Hellwig
2015-01-19  9:10     ` [Ocfs2-devel] " Christoph Hellwig
2015-01-16 12:47 ` [PATCH 11/17] quota: Wire up Q_GETXSTATE and Q_GETXSTATV calls to work with ->get_state Jan Kara
2015-01-16 12:47   ` [Cluster-devel] " Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47   ` Jan Kara
2015-01-19  9:11   ` Christoph Hellwig
2015-01-19  9:11     ` [Cluster-devel] " Christoph Hellwig
2015-01-19  9:11     ` [Ocfs2-devel] " Christoph Hellwig
2015-01-16 12:47 ` [PATCH 12/17] xfs: Convert to using ->get_state callback Jan Kara
2015-01-16 12:47   ` [Cluster-devel] " Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47   ` Jan Kara
2015-01-19  9:38   ` Christoph Hellwig
2015-01-19  9:38     ` [Cluster-devel] " Christoph Hellwig
2015-01-19  9:38     ` [Ocfs2-devel] " Christoph Hellwig
2015-01-20 17:33     ` Jan Kara
2015-01-20 17:33       ` [Cluster-devel] " Jan Kara
2015-01-20 17:33       ` [Ocfs2-devel] " Jan Kara
2015-01-20 17:33       ` Jan Kara
2015-01-16 12:47 ` [PATCH 13/17] gfs2: " Jan Kara
2015-01-16 12:47   ` [Cluster-devel] " Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47   ` Jan Kara
2015-01-16 12:47 ` [PATCH 14/17] quota: Remove ->get_xstate and ->get_xstatev callbacks Jan Kara
2015-01-16 12:47   ` [Cluster-devel] " Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47   ` Jan Kara
2015-01-19  9:38   ` Christoph Hellwig
2015-01-19  9:38     ` [Cluster-devel] " Christoph Hellwig
2015-01-19  9:38     ` [Ocfs2-devel] " Christoph Hellwig
2015-01-19  9:38     ` Christoph Hellwig
2015-01-16 12:47 ` [PATCH 15/17] quota: Make ->set_info use structure with neccesary info to VFS and XFS Jan Kara
2015-01-16 12:47   ` [Cluster-devel] " Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47   ` Jan Kara
2015-01-16 12:47 ` [PATCH 16/17] xfs: Add support for Q_SETINFO Jan Kara
2015-01-16 12:47   ` [Cluster-devel] " Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47   ` Jan Kara
2015-01-16 12:47 ` [PATCH 17/17] quota: Hook up Q_XSETQLIM for id 0 to ->set_info Jan Kara
2015-01-16 12:47   ` [Cluster-devel] " Jan Kara
2015-01-16 12:47   ` [Ocfs2-devel] " Jan Kara
2015-01-16 12:47   ` Jan Kara
2015-01-21 21:38 ` [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces Dave Chinner
2015-01-21 21:38   ` [Cluster-devel] " Dave Chinner
2015-01-21 21:38   ` [Ocfs2-devel] " Dave Chinner
2015-01-21 21:38   ` Dave Chinner
2015-01-21 22:23   ` Jan Kara
2015-01-21 22:23     ` [Cluster-devel] " Jan Kara
2015-01-21 22:23     ` [Ocfs2-devel] " Jan Kara
2015-01-21 22:23     ` Jan Kara
2015-01-21 23:10     ` Dave Chinner
2015-01-21 23:10       ` [Cluster-devel] " Dave Chinner
2015-01-21 23:10       ` [Ocfs2-devel] " Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421412471-4747-1-git-send-email-jack@suse.cz \
    --to=jack@suse.cz \
    --cc=cluster-devel@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.