All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylvain Rochet <sylvain.rochet@finsecur.com>
To: Andrew Victor <linux@maxim.org.za>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	boris.brezillon@free-electrons.com, voice.shen@atmel.com,
	alexandre.belloni@free-electrons.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Sylvain Rochet <sylvain.rochet@finsecur.com>
Subject: [PATCH] AT91: DT: Watchdog, remove property idle halt by default
Date: Sat, 17 Jan 2015 22:49:56 +0100	[thread overview]
Message-ID: <1421531396-20188-1-git-send-email-sylvain.rochet@finsecur.com> (raw)

The behavior changed when watchdog properties were added to DT, it makes
the watchdog not counting when CPU is in idle state, therefore the
watchdog reset time depend on mean CPU usage and will not reset at all
if the CPU stop working while it is in idle state, which is a very weird
behavior.

Apply principle of least surprise on at91sam9260-wdt by removing idle
halt flag by default.

Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
---
 arch/arm/boot/dts/at91sam9x5.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
index bbb3ba6..ce61f91 100644
--- a/arch/arm/boot/dts/at91sam9x5.dtsi
+++ b/arch/arm/boot/dts/at91sam9x5.dtsi
@@ -1125,7 +1125,6 @@
 				atmel,watchdog-type = "hardware";
 				atmel,reset-type = "all";
 				atmel,dbg-halt;
-				atmel,idle-halt;
 				status = "disabled";
 			};
 
-- 
2.1.4

WARNING: multiple messages have this Message-ID (diff)
From: sylvain.rochet@finsecur.com (Sylvain Rochet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] AT91: DT: Watchdog, remove property idle halt by default
Date: Sat, 17 Jan 2015 22:49:56 +0100	[thread overview]
Message-ID: <1421531396-20188-1-git-send-email-sylvain.rochet@finsecur.com> (raw)

The behavior changed when watchdog properties were added to DT, it makes
the watchdog not counting when CPU is in idle state, therefore the
watchdog reset time depend on mean CPU usage and will not reset at all
if the CPU stop working while it is in idle state, which is a very weird
behavior.

Apply principle of least surprise on at91sam9260-wdt by removing idle
halt flag by default.

Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
---
 arch/arm/boot/dts/at91sam9x5.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
index bbb3ba6..ce61f91 100644
--- a/arch/arm/boot/dts/at91sam9x5.dtsi
+++ b/arch/arm/boot/dts/at91sam9x5.dtsi
@@ -1125,7 +1125,6 @@
 				atmel,watchdog-type = "hardware";
 				atmel,reset-type = "all";
 				atmel,dbg-halt;
-				atmel,idle-halt;
 				status = "disabled";
 			};
 
-- 
2.1.4

             reply	other threads:[~2015-01-17 21:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-17 21:49 Sylvain Rochet [this message]
2015-01-17 21:49 ` [PATCH] AT91: DT: Watchdog, remove property idle halt by default Sylvain Rochet
     [not found] ` <1421531396-20188-1-git-send-email-sylvain.rochet-ETtyaVkrhkNWk0Htik3J/w@public.gmane.org>
2015-01-18  8:08   ` Boris Brezillon
2015-01-18  8:08     ` Boris Brezillon
2015-01-18 13:26     ` [PATCHv2 0/2] dts: AT91 " Sylvain Rochet
2015-01-18 13:26       ` Sylvain Rochet
     [not found]       ` <1421587611-32708-1-git-send-email-sylvain.rochet-ETtyaVkrhkNWk0Htik3J/w@public.gmane.org>
2015-01-18 13:26         ` [PATCHv2 1/2] dts: Documentation: AT91 Watchdog, explain what atmel,idle-halt property really do Sylvain Rochet
2015-01-18 13:26           ` [PATCHv2 1/2] dts: Documentation: AT91 Watchdog, explain what atmel, idle-halt " Sylvain Rochet
     [not found]           ` <1421587611-32708-2-git-send-email-sylvain.rochet-ETtyaVkrhkNWk0Htik3J/w@public.gmane.org>
2015-01-22 18:14             ` [PATCHv2 1/2] dts: Documentation: AT91 Watchdog, explain what atmel,idle-halt " Boris Brezillon
2015-01-22 18:14               ` Boris Brezillon
2015-01-18 13:26         ` [PATCHv2 2/2] dts: AT91 Watchdog, remove property idle halt by default Sylvain Rochet
2015-01-18 13:26           ` Sylvain Rochet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421531396-20188-1-git-send-email-sylvain.rochet@finsecur.com \
    --to=sylvain.rochet@finsecur.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@maxim.org.za \
    --cc=nicolas.ferre@atmel.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=voice.shen@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.