From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: stefano.stabellini@citrix.com,
Julien Grall <julien.grall@linaro.org>,
tim@xen.org, ian.campbell@citrix.com
Subject: [PATCH 09/10] xen/arm: vgic-v2: Take the lock when writing into GICD_CTLR
Date: Mon, 19 Jan 2015 16:29:16 +0000 [thread overview]
Message-ID: <1421684957-29884-10-git-send-email-julien.grall@linaro.org> (raw)
In-Reply-To: <1421684957-29884-1-git-send-email-julien.grall@linaro.org>
This register is shared between every vCPUs and the lock was already
taken for read.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
This patch should be backported to Xen 4.4 and Xen 4.5.
Although, it won't apply directly for Xen 4.4.
---
xen/arch/arm/vgic-v2.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
index 8c6ca72..3e5371f 100644
--- a/xen/arch/arm/vgic-v2.c
+++ b/xen/arch/arm/vgic-v2.c
@@ -281,7 +281,10 @@ static int vgic_v2_distr_mmio_write(struct vcpu *v, mmio_info_t *info)
case GICD_CTLR:
if ( dabt.size != DABT_WORD ) goto bad_width;
/* Ignore all but the enable bit */
+ vgic_lock(v);
v->domain->arch.vgic.ctlr = (*r) & GICD_CTL_ENABLE;
+ vgic_unlock(v);
+
return 1;
/* R/O -- write ignored */
--
2.1.4
next prev parent reply other threads:[~2015-01-19 16:30 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 16:29 [PATCH 00/10] xen/arm: Bug fixes for the vGIC Julien Grall
2015-01-19 16:29 ` [PATCH 01/10] xen/arm: vgic-v3: Correctly set GICD_TYPER.IDbits Julien Grall
2015-01-20 15:34 ` Ian Campbell
2015-01-20 17:16 ` Julien Grall
2015-01-20 15:43 ` Ian Campbell
2015-01-19 16:29 ` [PATCH 02/10] xen/arm: vgic-v3: Correctly set GICD_TYPER.CPUNumber Julien Grall
2015-01-20 15:43 ` Ian Campbell
2015-01-19 16:29 ` [PATCH 03/10] xen/arm: vgic-v3: Correctly handle GICD_CTLR Julien Grall
2015-01-20 15:51 ` Ian Campbell
2015-01-20 17:17 ` Julien Grall
2015-01-19 16:29 ` [PATCH 04/10] xen/arm: vgic-v3: Don't check the size when we ignore the write/read as zero Julien Grall
2015-01-20 15:57 ` Ian Campbell
2015-01-20 17:41 ` Julien Grall
2015-01-20 17:57 ` Ian Campbell
2015-01-20 18:50 ` Julien Grall
2015-01-21 12:11 ` Ian Campbell
2015-01-21 12:28 ` Julien Grall
2015-01-21 12:36 ` Ian Campbell
2015-01-21 12:45 ` Julien Grall
2015-01-21 12:50 ` Ian Campbell
2015-01-20 18:04 ` Julien Grall
2015-01-19 16:29 ` [PATCH 05/10] xen/arm: vgic-v3: Document the current restrictions Julien Grall
2015-01-20 16:00 ` Ian Campbell
2015-01-20 17:49 ` Julien Grall
2015-01-21 12:16 ` Ian Campbell
2015-01-21 12:33 ` Julien Grall
2015-01-21 12:48 ` Ian Campbell
2015-01-21 13:19 ` Julien Grall
2015-01-22 15:19 ` Julien Grall
2015-01-19 16:29 ` [PATCH 06/10] xen/arm: vgic-v3: Print the domain/vcpu in each message Julien Grall
2015-01-20 16:05 ` Ian Campbell
2015-01-20 17:50 ` Julien Grall
2015-01-19 16:29 ` [PATCH 07/10] xen/arm: vgic-v2: Correctly set GICD_TYPER.CPUNumber Julien Grall
2015-01-20 16:06 ` Ian Campbell
2015-01-19 16:29 ` [PATCH 08/10] xen/arm: vgic-v2: Don't check the size when we ignore the write/read a zero Julien Grall
2015-01-20 16:08 ` Ian Campbell
2015-01-19 16:29 ` Julien Grall [this message]
2015-01-20 16:09 ` [PATCH 09/10] xen/arm: vgic-v2: Take the lock when writing into GICD_CTLR Ian Campbell
2015-01-19 16:29 ` [PATCH 10/10] xen/arm: vgic-v2: Print the domain/vcpu in each message Julien Grall
2015-01-20 16:09 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421684957-29884-10-git-send-email-julien.grall@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.