* [PATCH] vhost: Add -lfuse into the LDFLAGS list
@ 2015-01-20 20:49 Neil Horman
[not found] ` <1421786998-5814-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Neil Horman @ 2015-01-20 20:49 UTC (permalink / raw)
To: dev-VfR2kkLFssw; +Cc: fbl-H+wXaHxf7aLQT0dZR+AlfA
the vhost library relies on libfuse, and thats included when we do a normal
shared object build, but when we specify combined libs, its gets left out. Add
it back in
Signed-off-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
---
mk/rte.app.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index e1a0dbf..86d9865 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -127,6 +127,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
LDLIBS += -lpcap
endif
+ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y)
+LDLIBS += -lfuse
+endif
+
LDLIBS += --start-group
ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] vhost: Add -lfuse into the LDFLAGS list
[not found] ` <1421786998-5814-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
@ 2015-01-20 22:24 ` Flavio Leitner
2015-01-26 21:03 ` Thomas Monjalon
2015-01-27 14:39 ` [PATCH v2] " Neil Horman
2 siblings, 0 replies; 5+ messages in thread
From: Flavio Leitner @ 2015-01-20 22:24 UTC (permalink / raw)
To: dev-VfR2kkLFssw
On Tuesday, January 20, 2015 03:49:58 PM Neil Horman wrote:
> the vhost library relies on libfuse, and thats included when we do a normal
> shared object build, but when we specify combined libs, its gets left out. Add
> it back in
>
> Signed-off-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Fixes the build issue here.
Reported-by: Flavio Leitner <fbl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Tested-by: Flavio Leitner <fbl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Thanks Neil!
fbl
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] vhost: Add -lfuse into the LDFLAGS list
[not found] ` <1421786998-5814-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2015-01-20 22:24 ` Flavio Leitner
@ 2015-01-26 21:03 ` Thomas Monjalon
2015-01-27 14:39 ` [PATCH v2] " Neil Horman
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2015-01-26 21:03 UTC (permalink / raw)
To: Neil Horman; +Cc: dev-VfR2kkLFssw, fbl-H+wXaHxf7aLQT0dZR+AlfA
2015-01-20 15:49, Neil Horman:
> the vhost library relies on libfuse, and thats included when we do a normal
> shared object build, but when we specify combined libs, its gets left out. Add
> it back in
>
> Signed-off-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
> ---
> mk/rte.app.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> +ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y)
> +LDLIBS += -lfuse
> +endif
There was already a line for -lfuse below in the file.
You are adding it in a place where it applies to every cases,
so you should remove the old special case.
Thanks
--
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] vhost: Add -lfuse into the LDFLAGS list
[not found] ` <1421786998-5814-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2015-01-20 22:24 ` Flavio Leitner
2015-01-26 21:03 ` Thomas Monjalon
@ 2015-01-27 14:39 ` Neil Horman
[not found] ` <1422369594-25960-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2 siblings, 1 reply; 5+ messages in thread
From: Neil Horman @ 2015-01-27 14:39 UTC (permalink / raw)
To: dev-VfR2kkLFssw; +Cc: fbl-H+wXaHxf7aLQT0dZR+AlfA
the vhost library relies on libfuse, and thats included when we do a normal
shared object build, but when we specify combined libs, its gets left out. Add
it back in
Signed-off-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
---
Change notes:
v2) Removed normal shared object inclusion of libfuse since its always included
now
---
mk/rte.app.mk | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index 9c8b06a..4294d9a 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -131,6 +131,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
LDLIBS += -lpcap
endif
+ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y)
+LDLIBS += -lfuse
+endif
+
LDLIBS += --start-group
ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
@@ -197,7 +201,6 @@ endif
ifeq ($(CONFIG_RTE_LIBRTE_VHOST), y)
LDLIBS += -lrte_vhost
-LDLIBS += -lfuse
endif
ifeq ($(CONFIG_RTE_LIBRTE_ENIC_PMD),y)
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] vhost: Add -lfuse into the LDFLAGS list
[not found] ` <1422369594-25960-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
@ 2015-01-27 16:02 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2015-01-27 16:02 UTC (permalink / raw)
To: Neil Horman; +Cc: dev-VfR2kkLFssw, fbl-H+wXaHxf7aLQT0dZR+AlfA
2015-01-27 09:39, Neil Horman:
> the vhost library relies on libfuse, and thats included when we do a normal
> shared object build, but when we specify combined libs, its gets left out. Add
> it back in
>
> Signed-off-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
>
> ---
> Change notes:
> v2) Removed normal shared object inclusion of libfuse since its always included
> now
Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Applied
Thanks
--
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-27 16:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-20 20:49 [PATCH] vhost: Add -lfuse into the LDFLAGS list Neil Horman
[not found] ` <1421786998-5814-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2015-01-20 22:24 ` Flavio Leitner
2015-01-26 21:03 ` Thomas Monjalon
2015-01-27 14:39 ` [PATCH v2] " Neil Horman
[not found] ` <1422369594-25960-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2015-01-27 16:02 ` Thomas Monjalon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.