* [PATCH v1 0/2] line over 80 character warnings.
@ 2015-01-23 19:11 jitendra kumar khasdev
2015-01-23 19:11 ` [PATCH v1 1/2] Staging: comedi: fix line over 80 characters warning jitendra kumar khasdev
2015-01-23 19:11 ` [PATCH v1 2/2] " jitendra kumar khasdev
0 siblings, 2 replies; 6+ messages in thread
From: jitendra kumar khasdev @ 2015-01-23 19:11 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel, jitendra kumar khasdev
In these two files jr3_pci.c, jr3_pci.h, 80 character warnings are reduced.
jitendra kumar khasdev (2):
Staging: comedi: fix line over 80 characters warning
Staging: comedi: fix line over 80 characters warning
drivers/staging/comedi/drivers/jr3_pci.c | 3 ++-
drivers/staging/comedi/drivers/jr3_pci.h | 5 +++--
2 files changed, 5 insertions(+), 3 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 1/2] Staging: comedi: fix line over 80 characters warning
2015-01-23 19:11 [PATCH v1 0/2] line over 80 character warnings jitendra kumar khasdev
@ 2015-01-23 19:11 ` jitendra kumar khasdev
2015-01-26 11:19 ` Ian Abbott
2015-01-23 19:11 ` [PATCH v1 2/2] " jitendra kumar khasdev
1 sibling, 1 reply; 6+ messages in thread
From: jitendra kumar khasdev @ 2015-01-23 19:11 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel, jitendra kumar khasdev
This is patch to file jr3_pci.h that fix up warning line
over 80 character which is found by checkpatch tool.
Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
drivers/staging/comedi/drivers/jr3_pci.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/jr3_pci.h b/drivers/staging/comedi/drivers/jr3_pci.h
index 20478ae..356811d 100644
--- a/drivers/staging/comedi/drivers/jr3_pci.h
+++ b/drivers/staging/comedi/drivers/jr3_pci.h
@@ -261,8 +261,9 @@ struct intern_transform {
} link[8];
};
-/* JR3 force/torque sensor data definition. For more information see sensor and */
-/* hardware manuals. */
+/* JR3 force/torque sensor data definition. For more information see sensor
+ * and hardware manuals.
+ */
struct jr3_channel {
/* Raw_channels is the area used to store the raw data coming from */
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1 1/2] Staging: comedi: fix line over 80 characters warning
2015-01-23 19:11 ` [PATCH v1 1/2] Staging: comedi: fix line over 80 characters warning jitendra kumar khasdev
@ 2015-01-26 11:19 ` Ian Abbott
0 siblings, 0 replies; 6+ messages in thread
From: Ian Abbott @ 2015-01-26 11:19 UTC (permalink / raw)
To: jitendra kumar khasdev, hsweeten, gregkh; +Cc: devel, linux-kernel
On 23/01/15 19:11, jitendra kumar khasdev wrote:
> This is patch to file jr3_pci.h that fix up warning line
> over 80 character which is found by checkpatch tool.
>
> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
> ---
> drivers/staging/comedi/drivers/jr3_pci.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/jr3_pci.h b/drivers/staging/comedi/drivers/jr3_pci.h
> index 20478ae..356811d 100644
> --- a/drivers/staging/comedi/drivers/jr3_pci.h
> +++ b/drivers/staging/comedi/drivers/jr3_pci.h
> @@ -261,8 +261,9 @@ struct intern_transform {
> } link[8];
> };
>
> -/* JR3 force/torque sensor data definition. For more information see sensor and */
> -/* hardware manuals. */
> +/* JR3 force/torque sensor data definition. For more information see sensor
> + * and hardware manuals.
> + */
The usual block comment style is like this:
/*
* Blah blah
* blah.
*/
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 2/2] Staging: comedi: fix line over 80 characters warning
2015-01-23 19:11 [PATCH v1 0/2] line over 80 character warnings jitendra kumar khasdev
2015-01-23 19:11 ` [PATCH v1 1/2] Staging: comedi: fix line over 80 characters warning jitendra kumar khasdev
@ 2015-01-23 19:11 ` jitendra kumar khasdev
2015-01-24 2:29 ` Greg KH
2015-01-26 11:20 ` Ian Abbott
1 sibling, 2 replies; 6+ messages in thread
From: jitendra kumar khasdev @ 2015-01-23 19:11 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel, jitendra kumar khasdev
This is patch to file jr3_pci.c that fix up warning line
over 80 character which is found by checkpatch tool. Made change into signature
of struct jr3_pci_poll_delay jr3_pci_poll_subdevice function by giving a newline
so that 80 character line over warning to be reduced.
Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
drivers/staging/comedi/drivers/jr3_pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c
index 81fab2d..1de843d 100644
--- a/drivers/staging/comedi/drivers/jr3_pci.c
+++ b/drivers/staging/comedi/drivers/jr3_pci.c
@@ -449,7 +449,8 @@ static int jr3_download_firmware(struct comedi_device *dev,
return 0;
}
-static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice *s)
+static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice
+ *s)
{
struct jr3_pci_subdev_private *spriv = s->private;
struct jr3_pci_poll_delay result = poll_delay_min_max(1000, 2000);
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1 2/2] Staging: comedi: fix line over 80 characters warning
2015-01-23 19:11 ` [PATCH v1 2/2] " jitendra kumar khasdev
@ 2015-01-24 2:29 ` Greg KH
2015-01-26 11:20 ` Ian Abbott
1 sibling, 0 replies; 6+ messages in thread
From: Greg KH @ 2015-01-24 2:29 UTC (permalink / raw)
To: jitendra kumar khasdev; +Cc: abbotti, hsweeten, devel, linux-kernel
On Sat, Jan 24, 2015 at 12:41:20AM +0530, jitendra kumar khasdev wrote:
> This is patch to file jr3_pci.c that fix up warning line
> over 80 character which is found by checkpatch tool. Made change into signature
> of struct jr3_pci_poll_delay jr3_pci_poll_subdevice function by giving a newline
> so that 80 character line over warning to be reduced.
The irony of not properly line-wrapping your changelog comment for a
patch that you are fixing up proper line size is huge :)
>
> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
> ---
> drivers/staging/comedi/drivers/jr3_pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c
> index 81fab2d..1de843d 100644
> --- a/drivers/staging/comedi/drivers/jr3_pci.c
> +++ b/drivers/staging/comedi/drivers/jr3_pci.c
> @@ -449,7 +449,8 @@ static int jr3_download_firmware(struct comedi_device *dev,
> return 0;
> }
>
> -static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice *s)
> +static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice
> + *s)
Be reasonable, this is now looks worse than the code did before, just
leave this as-is, coding style is a guideline, not hard rules.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] Staging: comedi: fix line over 80 characters warning
2015-01-23 19:11 ` [PATCH v1 2/2] " jitendra kumar khasdev
2015-01-24 2:29 ` Greg KH
@ 2015-01-26 11:20 ` Ian Abbott
1 sibling, 0 replies; 6+ messages in thread
From: Ian Abbott @ 2015-01-26 11:20 UTC (permalink / raw)
To: jitendra kumar khasdev, hsweeten, gregkh; +Cc: devel, linux-kernel
On 23/01/15 19:11, jitendra kumar khasdev wrote:
> This is patch to file jr3_pci.c that fix up warning line
> over 80 character which is found by checkpatch tool. Made change into signature
> of struct jr3_pci_poll_delay jr3_pci_poll_subdevice function by giving a newline
> so that 80 character line over warning to be reduced.
>
> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
> ---
> drivers/staging/comedi/drivers/jr3_pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c
> index 81fab2d..1de843d 100644
> --- a/drivers/staging/comedi/drivers/jr3_pci.c
> +++ b/drivers/staging/comedi/drivers/jr3_pci.c
> @@ -449,7 +449,8 @@ static int jr3_download_firmware(struct comedi_device *dev,
> return 0;
> }
>
> -static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice *s)
> +static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice
> + *s)
I think it looks better wrapped like this:
static struct jr3_pci_poll_delay
jr3_pci_poll_subdevice(struct comedi_subdevice *s)
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-01-26 11:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-23 19:11 [PATCH v1 0/2] line over 80 character warnings jitendra kumar khasdev
2015-01-23 19:11 ` [PATCH v1 1/2] Staging: comedi: fix line over 80 characters warning jitendra kumar khasdev
2015-01-26 11:19 ` Ian Abbott
2015-01-23 19:11 ` [PATCH v1 2/2] " jitendra kumar khasdev
2015-01-24 2:29 ` Greg KH
2015-01-26 11:20 ` Ian Abbott
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.