* [PATCH] tracing: Remove newline from trace_printk warning banner
@ 2015-01-27 16:17 Borislav Petkov
2015-01-27 17:05 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Borislav Petkov @ 2015-01-27 16:17 UTC (permalink / raw)
To: Steven Rostedt; +Cc: LKML
From: Borislav Petkov <bp@suse.de>
Remove the output-confusing newline below:
[ 0.191328]
**********************************************************
[ 0.191493] ** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **
[ 0.191586] ** **
...
Signed-off-by: Borislav Petkov <bp@suse.de>
---
kernel/trace/trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 4a9079b9f082..7a04946ffb06 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2036,7 +2036,7 @@ void trace_printk_init_buffers(void)
/* trace_printk() is for debug use only. Don't use it in production. */
- pr_warning("\n**********************************************************\n");
+ pr_warning("**********************************************************\n");
pr_warning("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n");
pr_warning("** **\n");
pr_warning("** trace_printk() being used. Allocating extra memory. **\n");
--
2.2.0.33.gc18b867
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tracing: Remove newline from trace_printk warning banner
2015-01-27 16:17 [PATCH] tracing: Remove newline from trace_printk warning banner Borislav Petkov
@ 2015-01-27 17:05 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2015-01-27 17:05 UTC (permalink / raw)
To: Borislav Petkov; +Cc: LKML
On Tue, 27 Jan 2015 17:17:20 +0100
Borislav Petkov <bp@alien8.de> wrote:
> From: Borislav Petkov <bp@suse.de>
>
> Remove the output-confusing newline below:
>
> [ 0.191328]
> **********************************************************
> [ 0.191493] ** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **
> [ 0.191586] ** **
> ...
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
> kernel/trace/trace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 4a9079b9f082..7a04946ffb06 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -2036,7 +2036,7 @@ void trace_printk_init_buffers(void)
>
> /* trace_printk() is for debug use only. Don't use it in production. */
>
> - pr_warning("\n**********************************************************\n");
> + pr_warning("**********************************************************\n");
Actually, could you just move the \n to another pr_warning. Because
this can print on console text that makes it look weird too:
login: [ 0.191328] **********************************************************
[ 0.191493] ** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **
[ 0.191586] ** **
-- Steve
> pr_warning("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n");
> pr_warning("** **\n");
> pr_warning("** trace_printk() being used. Allocating extra memory. **\n");
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-27 17:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-27 16:17 [PATCH] tracing: Remove newline from trace_printk warning banner Borislav Petkov
2015-01-27 17:05 ` Steven Rostedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.