All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm: bridge/dw_hdmi: Fix return error path
@ 2015-01-27 12:54 Fabio Estevam
  2015-01-27 15:17 ` Philipp Zabel
  0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2015-01-27 12:54 UTC (permalink / raw)
  To: airlied; +Cc: Fabio Estevam, andy.yan, dri-devel

If devm_request_threaded_irq() fails we should jump to 'err_iahb' label that 
will disable the clocks that were previously enabled.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/gpu/drm/bridge/dw_hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
index ed3dfe7..cd6a706 100644
--- a/drivers/gpu/drm/bridge/dw_hdmi.c
+++ b/drivers/gpu/drm/bridge/dw_hdmi.c
@@ -1642,7 +1642,7 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
 					dw_hdmi_irq, IRQF_SHARED,
 					dev_name(dev), hdmi);
 	if (ret)
-		return ret;
+		goto err_iahb;
 
 	/*
 	 * To prevent overflows in HDMI_IH_FC_STAT2, set the clk regenerator
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm: bridge/dw_hdmi: Fix return error path
  2015-01-27 12:54 [PATCH] drm: bridge/dw_hdmi: Fix return error path Fabio Estevam
@ 2015-01-27 15:17 ` Philipp Zabel
  2015-01-28  8:00   ` Thierry Reding
  0 siblings, 1 reply; 4+ messages in thread
From: Philipp Zabel @ 2015-01-27 15:17 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: andy.yan, dri-devel

Hi Fabio,

Am Dienstag, den 27.01.2015, 10:54 -0200 schrieb Fabio Estevam:
> If devm_request_threaded_irq() fails we should jump to 'err_iahb' label that 
> will disable the clocks that were previously enabled.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/gpu/drm/bridge/dw_hdmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
> index ed3dfe7..cd6a706 100644
> --- a/drivers/gpu/drm/bridge/dw_hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
> @@ -1642,7 +1642,7 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
>  					dw_hdmi_irq, IRQF_SHARED,
>  					dev_name(dev), hdmi);
>  	if (ret)
> -		return ret;
> +		goto err_iahb;
>  
>  	/*
>  	 * To prevent overflows in HDMI_IH_FC_STAT2, set the clk regenerator

Thanks for the fix. I have applied this to my tree since I've introduced
the bug in there.

regards
Philipp

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm: bridge/dw_hdmi: Fix return error path
  2015-01-27 15:17 ` Philipp Zabel
@ 2015-01-28  8:00   ` Thierry Reding
  2015-01-28  8:45     ` Philipp Zabel
  0 siblings, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2015-01-28  8:00 UTC (permalink / raw)
  To: Philipp Zabel; +Cc: Fabio Estevam, andy.yan, dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 1208 bytes --]

On Tue, Jan 27, 2015 at 04:17:51PM +0100, Philipp Zabel wrote:
> Hi Fabio,
> 
> Am Dienstag, den 27.01.2015, 10:54 -0200 schrieb Fabio Estevam:
> > If devm_request_threaded_irq() fails we should jump to 'err_iahb' label that 
> > will disable the clocks that were previously enabled.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> >  drivers/gpu/drm/bridge/dw_hdmi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
> > index ed3dfe7..cd6a706 100644
> > --- a/drivers/gpu/drm/bridge/dw_hdmi.c
> > +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
> > @@ -1642,7 +1642,7 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
> >  					dw_hdmi_irq, IRQF_SHARED,
> >  					dev_name(dev), hdmi);
> >  	if (ret)
> > -		return ret;
> > +		goto err_iahb;
> >  
> >  	/*
> >  	 * To prevent overflows in HDMI_IH_FC_STAT2, set the clk regenerator
> 
> Thanks for the fix. I have applied this to my tree since I've introduced
> the bug in there.

I'm currently redoing the drm/{panel,bridge} pull request anyway, so I
could apply this while at it.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm: bridge/dw_hdmi: Fix return error path
  2015-01-28  8:00   ` Thierry Reding
@ 2015-01-28  8:45     ` Philipp Zabel
  0 siblings, 0 replies; 4+ messages in thread
From: Philipp Zabel @ 2015-01-28  8:45 UTC (permalink / raw)
  To: Thierry Reding; +Cc: Fabio Estevam, andy.yan, dri-devel

Hi Thierry,

Am Mittwoch, den 28.01.2015, 09:00 +0100 schrieb Thierry Reding:
> On Tue, Jan 27, 2015 at 04:17:51PM +0100, Philipp Zabel wrote:
> > Hi Fabio,
> > 
> > Am Dienstag, den 27.01.2015, 10:54 -0200 schrieb Fabio Estevam:
> > > If devm_request_threaded_irq() fails we should jump to 'err_iahb' label that 
> > > will disable the clocks that were previously enabled.
> > > 
> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > > ---
> > >  drivers/gpu/drm/bridge/dw_hdmi.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
> > > index ed3dfe7..cd6a706 100644
> > > --- a/drivers/gpu/drm/bridge/dw_hdmi.c
> > > +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
> > > @@ -1642,7 +1642,7 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
> > >  					dw_hdmi_irq, IRQF_SHARED,
> > >  					dev_name(dev), hdmi);
> > >  	if (ret)
> > > -		return ret;
> > > +		goto err_iahb;
> > >  
> > >  	/*
> > >  	 * To prevent overflows in HDMI_IH_FC_STAT2, set the clk regenerator
> > 
> > Thanks for the fix. I have applied this to my tree since I've introduced
> > the bug in there.
> 
> I'm currently redoing the drm/{panel,bridge} pull request anyway, so I
> could apply this while at it.

Thanks, I have a few fixes for the last pull anyway:
    git://git.pengutronix.de/git/pza/linux.git tags/imx-drm-next-2015-01-28

I can remove this patch from the branch if you'll take it, let me know
what you prefer. Just in case:

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-28  8:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-27 12:54 [PATCH] drm: bridge/dw_hdmi: Fix return error path Fabio Estevam
2015-01-27 15:17 ` Philipp Zabel
2015-01-28  8:00   ` Thierry Reding
2015-01-28  8:45     ` Philipp Zabel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.