* Re: [PATCH] staging: comedi: drivers: mite: Removed variables that is never used
2015-01-28 22:36 [PATCH] staging: comedi: drivers: mite: Removed variables that is never used Rickard Strandqvist
@ 2015-01-28 22:36 ` Julia Lawall
2015-01-29 14:39 ` Ian Abbott
1 sibling, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2015-01-28 22:36 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman, Julia Lawall,
Heena Sirwani, devel, linux-kernel
On Wed, 28 Jan 2015, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
The variable is lkar.
julia
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/comedi/drivers/mite.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c
> index ffc9e61..8d2903b 100644
> --- a/drivers/staging/comedi/drivers/mite.c
> +++ b/drivers/staging/comedi/drivers/mite.c
> @@ -494,9 +494,8 @@ EXPORT_SYMBOL_GPL(mite_bytes_read_from_memory_ub);
> unsigned mite_dma_tcr(struct mite_channel *mite_chan)
> {
> struct mite_struct *mite = mite_chan->mite;
> - int lkar;
>
> - lkar = readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel));
> + readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel));
> return readl(mite->mite_io_addr + MITE_TCR(mite_chan->channel));
> }
> EXPORT_SYMBOL_GPL(mite_dma_tcr);
> --
> 1.7.10.4
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] staging: comedi: drivers: mite: Removed variables that is never used
@ 2015-01-28 22:36 Rickard Strandqvist
2015-01-28 22:36 ` Julia Lawall
2015-01-29 14:39 ` Ian Abbott
0 siblings, 2 replies; 4+ messages in thread
From: Rickard Strandqvist @ 2015-01-28 22:36 UTC (permalink / raw)
To: Ian Abbott, H Hartley Sweeten
Cc: Rickard Strandqvist, Greg Kroah-Hartman, Julia Lawall,
Heena Sirwani, devel, linux-kernel
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/staging/comedi/drivers/mite.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c
index ffc9e61..8d2903b 100644
--- a/drivers/staging/comedi/drivers/mite.c
+++ b/drivers/staging/comedi/drivers/mite.c
@@ -494,9 +494,8 @@ EXPORT_SYMBOL_GPL(mite_bytes_read_from_memory_ub);
unsigned mite_dma_tcr(struct mite_channel *mite_chan)
{
struct mite_struct *mite = mite_chan->mite;
- int lkar;
- lkar = readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel));
+ readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel));
return readl(mite->mite_io_addr + MITE_TCR(mite_chan->channel));
}
EXPORT_SYMBOL_GPL(mite_dma_tcr);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: comedi: drivers: mite: Removed variables that is never used
2015-01-28 22:36 [PATCH] staging: comedi: drivers: mite: Removed variables that is never used Rickard Strandqvist
2015-01-28 22:36 ` Julia Lawall
@ 2015-01-29 14:39 ` Ian Abbott
2015-01-29 22:18 ` Rickard Strandqvist
1 sibling, 1 reply; 4+ messages in thread
From: Ian Abbott @ 2015-01-29 14:39 UTC (permalink / raw)
To: Rickard Strandqvist, H Hartley Sweeten
Cc: Greg Kroah-Hartman, Julia Lawall, Heena Sirwani, devel, linux-kernel
On 28/01/15 22:36, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/comedi/drivers/mite.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c
> index ffc9e61..8d2903b 100644
> --- a/drivers/staging/comedi/drivers/mite.c
> +++ b/drivers/staging/comedi/drivers/mite.c
> @@ -494,9 +494,8 @@ EXPORT_SYMBOL_GPL(mite_bytes_read_from_memory_ub);
> unsigned mite_dma_tcr(struct mite_channel *mite_chan)
> {
> struct mite_struct *mite = mite_chan->mite;
> - int lkar;
>
> - lkar = readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel));
> + readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel));
> return readl(mite->mite_io_addr + MITE_TCR(mite_chan->channel));
> }
> EXPORT_SYMBOL_GPL(mite_dma_tcr);
>
Reading the MITE_LKAR(channel) register won't have any side-effects, so
that call to readl() can be removed altogether. In previous versions of
the driver, the value of lkar was only used in debugging messages.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: comedi: drivers: mite: Removed variables that is never used
2015-01-29 14:39 ` Ian Abbott
@ 2015-01-29 22:18 ` Rickard Strandqvist
0 siblings, 0 replies; 4+ messages in thread
From: Rickard Strandqvist @ 2015-01-29 22:18 UTC (permalink / raw)
To: Ian Abbott
Cc: H Hartley Sweeten, Greg Kroah-Hartman, Julia Lawall,
Heena Sirwani, devel, Linux Kernel Mailing List
2015-01-29 15:39 GMT+01:00 Ian Abbott <abbotti@mev.co.uk>:
> On 28/01/15 22:36, Rickard Strandqvist wrote:
>>
>> Variable ar assigned a value that is never used.
>> I have also removed all the code that thereby serves no purpose.
>>
>> This was found using a static code analysis program called cppcheck
>>
>> Signed-off-by: Rickard Strandqvist
>> <rickard_strandqvist@spectrumdigital.se>
>> ---
>> drivers/staging/comedi/drivers/mite.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/mite.c
>> b/drivers/staging/comedi/drivers/mite.c
>> index ffc9e61..8d2903b 100644
>> --- a/drivers/staging/comedi/drivers/mite.c
>> +++ b/drivers/staging/comedi/drivers/mite.c
>> @@ -494,9 +494,8 @@ EXPORT_SYMBOL_GPL(mite_bytes_read_from_memory_ub);
>> unsigned mite_dma_tcr(struct mite_channel *mite_chan)
>> {
>> struct mite_struct *mite = mite_chan->mite;
>> - int lkar;
>>
>> - lkar = readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel));
>> + readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel));
>> return readl(mite->mite_io_addr + MITE_TCR(mite_chan->channel));
>> }
>> EXPORT_SYMBOL_GPL(mite_dma_tcr);
>>
>
> Reading the MITE_LKAR(channel) register won't have any side-effects, so that
> call to readl() can be removed altogether. In previous versions of the
> driver, the value of lkar was only used in debugging messages.
>
> --
> -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
> -=( Web: http://www.mev.co.uk/ )=-
Hi
Ok good, new patch on the way!
Kind regards
Rickard Strandqvist
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-29 22:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-28 22:36 [PATCH] staging: comedi: drivers: mite: Removed variables that is never used Rickard Strandqvist
2015-01-28 22:36 ` Julia Lawall
2015-01-29 14:39 ` Ian Abbott
2015-01-29 22:18 ` Rickard Strandqvist
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.