* [PATCH] drm/bridge: dw_hdmi: Return the real error on drm_bridge_attach() failure
@ 2015-01-29 10:48 Fabio Estevam
2015-01-29 11:16 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2015-01-29 10:48 UTC (permalink / raw)
To: airlied; +Cc: Fabio Estevam, treding, dri-devel
From: Fabio Estevam <fabio.estevam@freescale.com>
drm_bridge_attach() may return different errors on failure, not just -EINVAL, so
it is better to propagate the real error instead.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/gpu/drm/bridge/dw_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
index cd6a706..fcae66a 100644
--- a/drivers/gpu/drm/bridge/dw_hdmi.c
+++ b/drivers/gpu/drm/bridge/dw_hdmi.c
@@ -1528,7 +1528,7 @@ static int dw_hdmi_register(struct drm_device *drm, struct dw_hdmi *hdmi)
ret = drm_bridge_attach(drm, bridge);
if (ret) {
DRM_ERROR("Failed to initialize bridge with drm\n");
- return -EINVAL;
+ return ret;
}
encoder->bridge = bridge;
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/bridge: dw_hdmi: Return the real error on drm_bridge_attach() failure
2015-01-29 10:48 [PATCH] drm/bridge: dw_hdmi: Return the real error on drm_bridge_attach() failure Fabio Estevam
@ 2015-01-29 11:16 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2015-01-29 11:16 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, treding, dri-devel
Am Donnerstag, den 29.01.2015, 08:48 -0200 schrieb Fabio Estevam:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> drm_bridge_attach() may return different errors on failure, not just -EINVAL, so
> it is better to propagate the real error instead.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/gpu/drm/bridge/dw_hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
> index cd6a706..fcae66a 100644
> --- a/drivers/gpu/drm/bridge/dw_hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
> @@ -1528,7 +1528,7 @@ static int dw_hdmi_register(struct drm_device *drm, struct dw_hdmi *hdmi)
> ret = drm_bridge_attach(drm, bridge);
> if (ret) {
> DRM_ERROR("Failed to initialize bridge with drm\n");
> - return -EINVAL;
> + return ret;
> }
>
> encoder->bridge = bridge;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-29 11:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-29 10:48 [PATCH] drm/bridge: dw_hdmi: Return the real error on drm_bridge_attach() failure Fabio Estevam
2015-01-29 11:16 ` Philipp Zabel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.