[PATCH] examples/vhost: fix segfault when link_vmdq fails

[PATCH] examples/vhost: fix segfault when link_vmdq fails

[Huawei Xie]

Signed-off-by: Huawei Xie <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 examples/vhost/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 04f0118..3a35359 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -1308,8 +1308,8 @@ switch_worker(__attribute__((unused)) void *arg)
 				/* If this is the first received packet we need to learn the MAC and setup VMDQ */
 				if (unlikely(vdev->ready == DEVICE_MAC_LEARNING) && tx_count) {
 					if (vdev->remove || (link_vmdq(vdev, pkts_burst[0]) == -1)) {
-						while (tx_count--)
-							rte_pktmbuf_free(pkts_burst[tx_count]);
+						while (tx_count)
+							rte_pktmbuf_free(pkts_burst[--tx_count]);
 					}
 				}
 				while (tx_count)
-- 
1.8.1.4

Re: [PATCH] examples/vhost: fix segfault when link_vmdq fails

[Ouyang, Changchun]

> -----Original Message-----
> From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Huawei Xie
> Sent: Friday, January 30, 2015 3:14 PM
> To: dev-VfR2kkLFssw@public.gmane.org
> Subject: [dpdk-dev] [PATCH] examples/vhost: fix segfault when link_vmdq
> fails
> 
> Signed-off-by: Huawei Xie <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Acked-by: Changchun Ouyang <changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

> ---
>  examples/vhost/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c index
> 04f0118..3a35359 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -1308,8 +1308,8 @@ switch_worker(__attribute__((unused)) void *arg)
>  				/* If this is the first received packet we need
> to learn the MAC and setup VMDQ */
>  				if (unlikely(vdev->ready ==
> DEVICE_MAC_LEARNING) && tx_count) {
>  					if (vdev->remove ||
> (link_vmdq(vdev, pkts_burst[0]) == -1)) {
> -						while (tx_count--)
> -
> 	rte_pktmbuf_free(pkts_burst[tx_count]);
> +						while (tx_count)
> +
> 	rte_pktmbuf_free(pkts_burst[--tx_count]);
>  					}
>  				}
>  				while (tx_count)
> --
> 1.8.1.4

Re: [PATCH] examples/vhost: fix segfault when link_vmdq fails

[Thomas Monjalon]

> > Signed-off-by: Huawei Xie <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> Acked-by: Changchun Ouyang <changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Applied

Thanks
-- 
Thomas