From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 2/7] ath10k: implement chanctx API
Date: Fri, 30 Jan 2015 14:31:10 +0100 [thread overview]
Message-ID: <1422624670.1919.21.camel@sipsolutions.net> (raw)
In-Reply-To: <CA+BoTQnkqzHNWTFSc9VB4_itCK_+jC6HC8GmdMKiyrhu-Sz9Cg@mail.gmail.com> (sfid-20150130_142217_389536_71E3C7E4)
On Fri, 2015-01-30 at 14:22 +0100, Michal Kazior wrote:
> You'd probably have to add quite a few mutex_lock(iflist_mtx) around
> drv_*() calls (not directly but somewhere at their call trees) to
> guarantee driver can use lock-free iterate() version (which doesn't
> exist yet). This could be tricky.
Well, I was thinking you'd only use it in some places now - but it does
seem a bit difficult to maintain.
We've not typically had to worry about using the synchronous versions
much since we mostly just need a single interface so we just pass it out
and use it there, or so.
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH v2 2/7] ath10k: implement chanctx API
Date: Fri, 30 Jan 2015 14:31:10 +0100 [thread overview]
Message-ID: <1422624670.1919.21.camel@sipsolutions.net> (raw)
In-Reply-To: <CA+BoTQnkqzHNWTFSc9VB4_itCK_+jC6HC8GmdMKiyrhu-Sz9Cg@mail.gmail.com> (sfid-20150130_142217_389536_71E3C7E4)
On Fri, 2015-01-30 at 14:22 +0100, Michal Kazior wrote:
> You'd probably have to add quite a few mutex_lock(iflist_mtx) around
> drv_*() calls (not directly but somewhere at their call trees) to
> guarantee driver can use lock-free iterate() version (which doesn't
> exist yet). This could be tricky.
Well, I was thinking you'd only use it in some places now - but it does
seem a bit difficult to maintain.
We've not typically had to worry about using the synchronous versions
much since we mostly just need a single interface so we just pass it out
and use it there, or so.
johannes
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2015-01-30 13:31 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 8:41 [PATCH 0/7] ath10k: add multi-channel support Michal Kazior
2015-01-30 8:41 ` Michal Kazior
2015-01-30 8:41 ` [PATCH 1/7] ath10k: allow empty ssid vdev config Michal Kazior
2015-01-30 8:41 ` Michal Kazior
2015-01-30 8:41 ` [PATCH 2/7] ath10k: implement chanctx API Michal Kazior
2015-01-30 8:41 ` Michal Kazior
2015-01-30 10:44 ` Michal Kazior
2015-01-30 10:44 ` Michal Kazior
2015-01-30 8:41 ` [PATCH 3/7] ath10k: implement adaptive qcs command Michal Kazior
2015-01-30 8:41 ` Michal Kazior
2015-01-30 8:41 ` [PATCH 4/7] ath10k: protect ar->arvifs linking with data_lock Michal Kazior
2015-01-30 8:41 ` Michal Kazior
2015-01-30 8:41 ` [PATCH 5/7] ath10k: rework tx queue locking Michal Kazior
2015-01-30 8:41 ` Michal Kazior
2015-01-30 8:41 ` [PATCH 6/7] ath10k: implement tx pause wmi event Michal Kazior
2015-01-30 8:41 ` Michal Kazior
2015-01-30 8:41 ` [PATCH 7/7] ath10k: enable multi-channel on supported devices Michal Kazior
2015-01-30 8:41 ` Michal Kazior
2015-01-30 12:31 ` [PATCH v2 0/7] ath10k: add multi-channel support Michal Kazior
2015-01-30 12:31 ` Michal Kazior
2015-01-30 12:31 ` [PATCH v2 1/7] ath10k: allow empty ssid vdev config Michal Kazior
2015-01-30 12:31 ` Michal Kazior
2015-01-30 12:31 ` [PATCH v2 2/7] ath10k: implement chanctx API Michal Kazior
2015-01-30 12:31 ` Michal Kazior
2015-01-30 12:45 ` Johannes Berg
2015-01-30 12:45 ` Johannes Berg
2015-01-30 13:02 ` Michal Kazior
2015-01-30 13:02 ` Michal Kazior
2015-01-30 13:04 ` Johannes Berg
2015-01-30 13:04 ` Johannes Berg
2015-01-30 13:22 ` Michal Kazior
2015-01-30 13:22 ` Michal Kazior
2015-01-30 13:31 ` Johannes Berg [this message]
2015-01-30 13:31 ` Johannes Berg
2015-01-30 13:47 ` Michal Kazior
2015-01-30 13:47 ` Michal Kazior
2015-01-30 14:06 ` Johannes Berg
2015-01-30 14:06 ` Johannes Berg
2015-01-30 12:58 ` Johannes Berg
2015-01-30 12:58 ` Johannes Berg
2015-01-30 13:06 ` Michal Kazior
2015-01-30 13:06 ` Michal Kazior
2015-01-30 13:10 ` Johannes Berg
2015-01-30 13:10 ` Johannes Berg
2015-01-30 14:01 ` Michal Kazior
2015-01-30 14:01 ` Michal Kazior
2015-01-30 14:10 ` Johannes Berg
2015-01-30 14:10 ` Johannes Berg
2015-01-30 12:31 ` [PATCH v2 3/7] ath10k: implement adaptive qcs command Michal Kazior
2015-01-30 12:31 ` Michal Kazior
2015-01-30 12:31 ` [PATCH v2 4/7] ath10k: protect ar->arvifs linking with data_lock Michal Kazior
2015-01-30 12:31 ` Michal Kazior
2015-01-30 12:31 ` [PATCH v2 5/7] ath10k: rework tx queue locking Michal Kazior
2015-01-30 12:31 ` Michal Kazior
2015-01-30 12:31 ` [PATCH v2 6/7] ath10k: implement tx pause wmi event Michal Kazior
2015-01-30 12:31 ` Michal Kazior
2015-01-30 12:31 ` [PATCH v2 7/7] ath10k: enable multi-channel on supported devices Michal Kazior
2015-01-30 12:31 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422624670.1919.21.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.