All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] jffs2:Remove no longer needed fix me comment for the function, jffs2_do_readpage_nolock
@ 2015-01-31 19:11 Nicholas Krause
  0 siblings, 0 replies; only message in thread
From: Nicholas Krause @ 2015-01-31 19:11 UTC (permalink / raw)
  To: dwmw2; +Cc: linux-mtd, linux-kernel

This fix me comment is no longer needed due to kmap not being able to fail and always
returning a address mapped in high memory as required for this function. There for
this fix me can now be removed as kmap always succeeds and there is no reason to
check if it fails.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 fs/jffs2/file.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/jffs2/file.c b/fs/jffs2/file.c
index 64989ca..84a2f7b 100644
--- a/fs/jffs2/file.c
+++ b/fs/jffs2/file.c
@@ -94,7 +94,6 @@ static int jffs2_do_readpage_nolock (struct inode *inode, struct page *pg)
 	BUG_ON(!PageLocked(pg));
 
 	pg_buf = kmap(pg);
-	/* FIXME: Can kmap fail? */
 
 	ret = jffs2_read_inode_range(c, f, pg_buf, pg->index << PAGE_CACHE_SHIFT, PAGE_CACHE_SIZE);
 
-- 
2.1.0

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-01-31 19:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-31 19:11 [PATCH] jffs2:Remove no longer needed fix me comment for the function, jffs2_do_readpage_nolock Nicholas Krause

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.