* [PATCH] android/build: Create a target for hciconfig.
@ 2015-02-02 7:19 Ian Coolidge
2015-02-02 7:49 ` Marcel Holtmann
0 siblings, 1 reply; 5+ messages in thread
From: Ian Coolidge @ 2015-02-02 7:19 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Ian Coolidge
---
android/Android.mk | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/android/Android.mk b/android/Android.mk
index c1a9eff..bf7e510 100644
--- a/android/Android.mk
+++ b/android/Android.mk
@@ -539,6 +539,39 @@ LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/bluez/configure.ac
include $(BUILD_EXECUTABLE)
#
+# hciconfig
+#
+
+include $(CLEAR_VARS)
+
+LOCAL_SRC_FILES:= \
+ bluez/lib/bluetooth.c \
+ bluez/lib/hci.c \
+ bluez/tools/csr.c \
+ bluez/tools/csr_h4.c \
+ bluez/tools/hciconfig.c
+
+LOCAL_C_INCLUDES := \
+ $(LOCAL_PATH)/bluez \
+ $(LOCAL_PATH)/bluez/lib \
+ $(LOCAL_PATH)/bluez/tools \
+ $(LOCAL_PATH)/bluez/src \
+ $(LOCAL_PATH)/bluez/src/shared \
+
+LOCAL_CFLAGS := $(BLUEZ_COMMON_CFLAGS)
+
+LOCAL_STATIC_LIBRARIES := \
+ bluetooth-headers \
+
+LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
+LOCAL_MODULE_TAGS := debug
+LOCAL_MODULE := hciconfig
+
+LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/bluez/configure.ac
+
+include $(BUILD_EXECUTABLE)
+
+#
# l2ping
#
--
2.2.0.rc0.207.ga3a616c
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] android/build: Create a target for hciconfig.
2015-02-02 7:19 [PATCH] android/build: Create a target for hciconfig Ian Coolidge
@ 2015-02-02 7:49 ` Marcel Holtmann
2015-02-02 8:25 ` [PATCH v2] " Ian Coolidge
0 siblings, 1 reply; 5+ messages in thread
From: Marcel Holtmann @ 2015-02-02 7:49 UTC (permalink / raw)
To: Ian Coolidge; +Cc: linux-bluetooth
Hi Ian,
> ---
> android/Android.mk | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/android/Android.mk b/android/Android.mk
> index c1a9eff..bf7e510 100644
> --- a/android/Android.mk
> +++ b/android/Android.mk
> @@ -539,6 +539,39 @@ LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/bluez/configure.ac
> include $(BUILD_EXECUTABLE)
>
> #
> +# hciconfig
> +#
> +
> +include $(CLEAR_VARS)
> +
> +LOCAL_SRC_FILES:= \
> + bluez/lib/bluetooth.c \
> + bluez/lib/hci.c \
> + bluez/tools/csr.c \
> + bluez/tools/csr_h4.c \
are you sure about this csr_h4.c file? I do not think that it is needed.
> + bluez/tools/hciconfig.c
Also could you re-order these similar to hcitool.
> +LOCAL_C_INCLUDES := \
> + $(LOCAL_PATH)/bluez \
> + $(LOCAL_PATH)/bluez/lib \
> + $(LOCAL_PATH)/bluez/tools \
> + $(LOCAL_PATH)/bluez/src \
> + $(LOCAL_PATH)/bluez/src/shared \
The entry for hcitool gets away with just $(LOCAL_PATH)/bluez and I assume that is enough here as well.
> +
> +LOCAL_CFLAGS := $(BLUEZ_COMMON_CFLAGS)
> +
> +LOCAL_STATIC_LIBRARIES := \
> + bluetooth-headers \
> +
> +LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
> +LOCAL_MODULE_TAGS := debug
> +LOCAL_MODULE := hciconfig
> +
> +LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/bluez/configure.ac
> +
> +include $(BUILD_EXECUTABLE)
> +
Everything else looks just fine. On a side note, we never included the command so far since mostly everything can be done with btmgmt. Especially when it comes to qualification. Then again, I have no objections to include hciconfig since that command is more widely know as it seems.
Regards
Marcel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] android/build: Create a target for hciconfig.
2015-02-02 7:49 ` Marcel Holtmann
@ 2015-02-02 8:25 ` Ian Coolidge
2015-02-02 8:25 ` [PATCH] " Ian Coolidge
0 siblings, 1 reply; 5+ messages in thread
From: Ian Coolidge @ 2015-02-02 8:25 UTC (permalink / raw)
To: linux-bluetooth
Changes:
- Remove unnecessary source and includes.
- Reorder source dependencies for similarity.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] android/build: Create a target for hciconfig.
2015-02-02 8:25 ` [PATCH v2] " Ian Coolidge
@ 2015-02-02 8:25 ` Ian Coolidge
2015-02-03 9:53 ` Szymon Janc
0 siblings, 1 reply; 5+ messages in thread
From: Ian Coolidge @ 2015-02-02 8:25 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Ian Coolidge
---
android/Android.mk | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/android/Android.mk b/android/Android.mk
index c1a9eff..ff71089 100644
--- a/android/Android.mk
+++ b/android/Android.mk
@@ -539,6 +539,34 @@ LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/bluez/configure.ac
include $(BUILD_EXECUTABLE)
#
+# hciconfig
+#
+
+include $(CLEAR_VARS)
+
+LOCAL_SRC_FILES:= \
+ bluez/tools/hciconfig.c \
+ bluez/tools/csr.c \
+ bluez/lib/bluetooth.c \
+ bluez/lib/hci.c \
+
+LOCAL_C_INCLUDES := \
+ $(LOCAL_PATH)/bluez \
+
+LOCAL_CFLAGS := $(BLUEZ_COMMON_CFLAGS)
+
+LOCAL_STATIC_LIBRARIES := \
+ bluetooth-headers \
+
+LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
+LOCAL_MODULE_TAGS := debug
+LOCAL_MODULE := hciconfig
+
+LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/bluez/configure.ac
+
+include $(BUILD_EXECUTABLE)
+
+#
# l2ping
#
--
2.2.0.rc0.207.ga3a616c
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] android/build: Create a target for hciconfig.
2015-02-02 8:25 ` [PATCH] " Ian Coolidge
@ 2015-02-03 9:53 ` Szymon Janc
0 siblings, 0 replies; 5+ messages in thread
From: Szymon Janc @ 2015-02-03 9:53 UTC (permalink / raw)
To: Ian Coolidge; +Cc: linux-bluetooth
Hi Ian,
On Monday 02 of February 2015 00:25:29 Ian Coolidge wrote:
> ---
> android/Android.mk | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/android/Android.mk b/android/Android.mk
> index c1a9eff..ff71089 100644
> --- a/android/Android.mk
> +++ b/android/Android.mk
> @@ -539,6 +539,34 @@ LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/bluez/configure.ac
> include $(BUILD_EXECUTABLE)
>
> #
> +# hciconfig
> +#
> +
> +include $(CLEAR_VARS)
> +
> +LOCAL_SRC_FILES:= \
> + bluez/tools/hciconfig.c \
> + bluez/tools/csr.c \
> + bluez/lib/bluetooth.c \
> + bluez/lib/hci.c \
> +
> +LOCAL_C_INCLUDES := \
> + $(LOCAL_PATH)/bluez \
> +
> +LOCAL_CFLAGS := $(BLUEZ_COMMON_CFLAGS)
> +
> +LOCAL_STATIC_LIBRARIES := \
> + bluetooth-headers \
> +
> +LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
> +LOCAL_MODULE_TAGS := debug
> +LOCAL_MODULE := hciconfig
> +
> +LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/bluez/configure.ac
> +
> +include $(BUILD_EXECUTABLE)
> +
> +#
> # l2ping
> #
>
Applied, thanks.
--
Best regards,
Szymon Janc
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-03 9:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-02 7:19 [PATCH] android/build: Create a target for hciconfig Ian Coolidge
2015-02-02 7:49 ` Marcel Holtmann
2015-02-02 8:25 ` [PATCH v2] " Ian Coolidge
2015-02-02 8:25 ` [PATCH] " Ian Coolidge
2015-02-03 9:53 ` Szymon Janc
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.