[PATCH OSSTEST] ts-xen-build-prep: install nasm

[PATCH OSSTEST] ts-xen-build-prep: install nasm

[Wei Liu]

OVMF requires nasm to build.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
---
 ts-xen-build-prep | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ts-xen-build-prep b/ts-xen-build-prep
index a7d0d03..24a8b25 100755
--- a/ts-xen-build-prep
+++ b/ts-xen-build-prep
@@ -178,7 +178,7 @@ sub prep () {
                                autoconf automake libtool xsltproc
                                libxml2-utils libxml2-dev libnl-dev
                                libdevmapper-dev w3c-dtd-xhtml libxml-xpath-perl
-			       ccache));
+                               ccache nasm));
 
     target_cmd_root($ho, "chmod -R a+r /usr/share/git-core/templates");
     # workaround for Debian #595728
-- 
1.9.1

Re: [PATCH OSSTEST] ts-xen-build-prep: install nasm

[Ian Campbell]

On Sat, 2015-01-31 at 22:51 +0000, Wei Liu wrote:
> OVMF requires nasm to build.

I suppose this is a new requirement added by the mainline branch we just
added?
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> ---
>  ts-xen-build-prep | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ts-xen-build-prep b/ts-xen-build-prep
> index a7d0d03..24a8b25 100755
> --- a/ts-xen-build-prep
> +++ b/ts-xen-build-prep
> @@ -178,7 +178,7 @@ sub prep () {
>                                 autoconf automake libtool xsltproc
>                                 libxml2-utils libxml2-dev libnl-dev
>                                 libdevmapper-dev w3c-dtd-xhtml libxml-xpath-perl
> -			       ccache));
> +                               ccache nasm));
>  
>      target_cmd_root($ho, "chmod -R a+r /usr/share/git-core/templates");
>      # workaround for Debian #595728

Re: [PATCH OSSTEST] ts-xen-build-prep: install nasm

[Wei Liu]

Ian Campbell <Ian.Campbell@citrix.com> writes:

> On Sat, 2015-01-31 at 22:51 +0000, Wei Liu wrote:
>> OVMF requires nasm to build.
>
> I suppose this is a new requirement added by the mainline branch we just
> added?
>>

Yes. The log in the latest two failed runs suggests so.

I also tested building latest OVMF HEAD it does require nasm to build.

Wei.

>> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>> ---
>>  ts-xen-build-prep | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/ts-xen-build-prep b/ts-xen-build-prep
>> index a7d0d03..24a8b25 100755
>> --- a/ts-xen-build-prep
>> +++ b/ts-xen-build-prep
>> @@ -178,7 +178,7 @@ sub prep () {
>>                                 autoconf automake libtool xsltproc
>>                                 libxml2-utils libxml2-dev libnl-dev
>>                                 libdevmapper-dev w3c-dtd-xhtml libxml-xpath-perl
>> -			       ccache));
>> +                               ccache nasm));
>>  
>>      target_cmd_root($ho, "chmod -R a+r /usr/share/git-core/templates");
>>      # workaround for Debian #595728

Re: [PATCH OSSTEST] ts-xen-build-prep: install nasm

[Ian Campbell]

On Mon, 2015-02-02 at 10:38 +0000, Wei Liu wrote:
> Ian Campbell <Ian.Campbell@citrix.com> writes:
> 
> > On Sat, 2015-01-31 at 22:51 +0000, Wei Liu wrote:
> >> OVMF requires nasm to build.
> >
> > I suppose this is a new requirement added by the mainline branch we just
> > added?
> >>
> 
> Yes. The log in the latest two failed runs suggests so.
> 
> I also tested building latest OVMF HEAD it does require nasm to build.

Thanks, applied to pretest after discussion with Ian J.

Ian.