All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] powerpc/fsl: add power_off support for fsl platform
@ 2015-02-04  6:47 Dongsheng Wang
  2015-02-25  2:29 ` Scott Wood
  0 siblings, 1 reply; 3+ messages in thread
From: Dongsheng Wang @ 2015-02-04  6:47 UTC (permalink / raw)
  To: scottwood; +Cc: linuxppc-dev, hongtao.jia, Wang Dongsheng, jason.jin

From: Wang Dongsheng <dongsheng.wang@freescale.com>

QIXIS System Logic FPGA support to manage system power. So we
through QIXIS to power off freescale SOC.

Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>

diff --git a/arch/powerpc/platforms/85xx/corenet_generic.c b/arch/powerpc/platforms/85xx/corenet_generic.c
index 1f309cc..e1a1eb5 100644
--- a/arch/powerpc/platforms/85xx/corenet_generic.c
+++ b/arch/powerpc/platforms/85xx/corenet_generic.c
@@ -81,6 +81,8 @@ void __init corenet_gen_setup_arch(void)
 	pr_info("%s board\n", ppc_md.name);
 
 	mpc85xx_qe_init();
+
+	ppc_md_fixup();
 }
 
 static const struct of_device_id of_device_ids[] = {
diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c
index 99269c0..6de9f1b 100644
--- a/arch/powerpc/sysdev/fsl_soc.c
+++ b/arch/powerpc/sysdev/fsl_soc.c
@@ -215,6 +215,54 @@ void fsl_rstcr_restart(char *cmd)
 }
 #endif
 
+#define QIXIS_PWR_CTL2		0x21
+#define QIXIS_PWR_CTL2_PWR	0x80
+static void fsl_power_off(void)
+{
+	struct device_node *pixis_node;
+	void __iomem *pixis;
+	u32 pwroff_offset, value;
+
+	pixis_node = of_find_compatible_node(NULL, NULL, "fsl,fpga-qixis");
+	if (!pixis_node) {
+		pr_err("%s: Missing pixis node\n", __func__);
+		return;
+	}
+
+	pwroff_offset = QIXIS_PWR_CTL2;
+	value = QIXIS_PWR_CTL2_PWR;
+
+	pixis = of_iomap(pixis_node, 0);
+	of_node_put(pixis_node);
+	if (!pixis) {
+		pr_err("%s: Could not map pixis registers\n", __func__);
+		return;
+	}
+
+	local_irq_disable();
+
+	setbits8(pixis + pwroff_offset, value);
+
+	iounmap(pixis);
+
+	while (1)
+		;
+}
+
+void ppc_md_fixup(void)
+{
+	struct device_node *np;
+
+	np = of_find_compatible_node(NULL, NULL, "fsl,fpga-qixis");
+	if (!np)
+		return;
+
+	of_node_put(np);
+
+	pm_power_off = fsl_power_off;
+	ppc_md.halt = fsl_power_off;
+}
+
 #if defined(CONFIG_FB_FSL_DIU) || defined(CONFIG_FB_FSL_DIU_MODULE)
 struct platform_diu_data_ops diu_ops;
 EXPORT_SYMBOL(diu_ops);
diff --git a/arch/powerpc/sysdev/fsl_soc.h b/arch/powerpc/sysdev/fsl_soc.h
index 4c5a19e..ca90e24 100644
--- a/arch/powerpc/sysdev/fsl_soc.h
+++ b/arch/powerpc/sysdev/fsl_soc.h
@@ -21,6 +21,8 @@ struct device_node;
 
 extern void fsl_rstcr_restart(char *cmd);
 
+void ppc_md_fixup(void);
+
 /* The different ports that the DIU can be connected to */
 enum fsl_diu_monitor_port {
 	FSL_DIU_PORT_DVI,	/* DVI */
-- 
2.1.0.27.g96db324

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] powerpc/fsl: add power_off support for fsl platform
  2015-02-04  6:47 [PATCH] powerpc/fsl: add power_off support for fsl platform Dongsheng Wang
@ 2015-02-25  2:29 ` Scott Wood
  2015-02-26  7:54   ` Dongsheng.Wang
  0 siblings, 1 reply; 3+ messages in thread
From: Scott Wood @ 2015-02-25  2:29 UTC (permalink / raw)
  To: Dongsheng Wang; +Cc: linuxppc-dev, hongtao.jia, jason.jin

On Wed, 2015-02-04 at 14:47 +0800, Dongsheng Wang wrote:
> +void ppc_md_fixup(void)
> +{

This name is way too generic (though it's moot since you shouldn't use
ppc_md for this).

> +	struct device_node *np;
> +
> +	np = of_find_compatible_node(NULL, NULL, "fsl,fpga-qixis");
> +	if (!np)
> +		return;
> +
> +	of_node_put(np);
> +
> +	pm_power_off = fsl_power_off;
> +	ppc_md.halt = fsl_power_off;
> +}

Please implement this as a drivers/power/reset driver, and consider
basing on top of
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/293089.html

-Scott

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] powerpc/fsl: add power_off support for fsl platform
  2015-02-25  2:29 ` Scott Wood
@ 2015-02-26  7:54   ` Dongsheng.Wang
  0 siblings, 0 replies; 3+ messages in thread
From: Dongsheng.Wang @ 2015-02-26  7:54 UTC (permalink / raw)
  To: Scott Wood; +Cc: linuxppc-dev, Hongtao Jia, Jason.Jin

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogV2VkbmVzZGF5LCBGZWJydWFyeSAyNSwgMjAxNSAxMDozMCBBTQ0KPiBUbzog
V2FuZyBEb25nc2hlbmctQjQwNTM0DQo+IENjOiBKaW4gWmhlbmd4aW9uZy1SNjQxODg7IExpIFlh
bmctTGVvLVI1ODQ3MjsgSmlhIEhvbmd0YW8tQjM4OTUxOyBsaW51eHBwYy0NCj4gZGV2QGxpc3Rz
Lm96bGFicy5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSF0gcG93ZXJwYy9mc2w6IGFkZCBwb3dl
cl9vZmYgc3VwcG9ydCBmb3IgZnNsIHBsYXRmb3JtDQo+IA0KPiBPbiBXZWQsIDIwMTUtMDItMDQg
YXQgMTQ6NDcgKzA4MDAsIERvbmdzaGVuZyBXYW5nIHdyb3RlOg0KPiA+ICt2b2lkIHBwY19tZF9m
aXh1cCh2b2lkKQ0KPiA+ICt7DQo+IA0KPiBUaGlzIG5hbWUgaXMgd2F5IHRvbyBnZW5lcmljICh0
aG91Z2ggaXQncyBtb290IHNpbmNlIHlvdSBzaG91bGRuJ3QgdXNlIHBwY19tZA0KPiBmb3IgdGhp
cykuDQo+IA0KDQpBZ3JlZS4NCg0KPiA+ICsJc3RydWN0IGRldmljZV9ub2RlICpucDsNCj4gPiAr
DQo+ID4gKwlucCA9IG9mX2ZpbmRfY29tcGF0aWJsZV9ub2RlKE5VTEwsIE5VTEwsICJmc2wsZnBn
YS1xaXhpcyIpOw0KPiA+ICsJaWYgKCFucCkNCj4gPiArCQlyZXR1cm47DQo+ID4gKw0KPiA+ICsJ
b2Zfbm9kZV9wdXQobnApOw0KPiA+ICsNCj4gPiArCXBtX3Bvd2VyX29mZiA9IGZzbF9wb3dlcl9v
ZmY7DQo+ID4gKwlwcGNfbWQuaGFsdCA9IGZzbF9wb3dlcl9vZmY7DQo+ID4gK30NCj4gDQo+IFBs
ZWFzZSBpbXBsZW1lbnQgdGhpcyBhcyBhIGRyaXZlcnMvcG93ZXIvcmVzZXQgZHJpdmVyLCBhbmQg
Y29uc2lkZXIgYmFzaW5nIG9uDQo+IHRvcCBvZiBodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9w
aXBlcm1haWwvbGludXgtYXJtLWtlcm5lbC8yMDE0LQ0KPiBPY3RvYmVyLzI5MzA4OS5odG1sDQo+
IA0KDQpUaGFua3MuDQoNClJlZ2FyZHMsDQotRG9uZ3NoZW5nDQo=

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-26  8:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-04  6:47 [PATCH] powerpc/fsl: add power_off support for fsl platform Dongsheng Wang
2015-02-25  2:29 ` Scott Wood
2015-02-26  7:54   ` Dongsheng.Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.