* [PATCH] cxl: Add missing return statement after handling AFU errror
@ 2015-02-04 8:10 ` Ian Munsie
0 siblings, 0 replies; 2+ messages in thread
From: Ian Munsie @ 2015-02-04 8:10 UTC (permalink / raw)
To: mpe
Cc: benh, mikey, linux-kernel, linuxppc-dev, Aneesh Kumar K.V,
Ryan Grimm, Vaibhav Jain, Philippe Bergheaud, Ian Munsie
From: Ian Munsie <imunsie@au1.ibm.com>
We were missing a return statement in the PSL interrupt handler in the
case of an AFU error, which would trigger an "Unhandled CXL PSL IRQ"
warning. We do actually handle these type of errors (by notifying
userspace), so add the missing return IRQ_HANDLED so we don't throw
unecessary warnings.
Signed-off-by: Ian Munsie <imunsie@au1.ibm.com>
---
drivers/misc/cxl/irq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c
index ef52af7..2a2e58a 100644
--- a/drivers/misc/cxl/irq.c
+++ b/drivers/misc/cxl/irq.c
@@ -170,6 +170,7 @@ static irqreturn_t cxl_irq(int irq, void *data, struct cxl_irq_info *irq_info)
}
cxl_ack_irq(ctx, CXL_PSL_TFC_An_A, 0);
+ return IRQ_HANDLED;
}
if (dsisr & CXL_PSL_DSISR_An_OC)
pr_devel("CXL interrupt: OS Context Warning\n");
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] cxl: Add missing return statement after handling AFU errror
@ 2015-02-04 8:10 ` Ian Munsie
0 siblings, 0 replies; 2+ messages in thread
From: Ian Munsie @ 2015-02-04 8:10 UTC (permalink / raw)
To: mpe
Cc: mikey, Vaibhav Jain, linux-kernel, Ryan Grimm, linuxppc-dev,
Aneesh Kumar K.V, Philippe Bergheaud, Ian Munsie
From: Ian Munsie <imunsie@au1.ibm.com>
We were missing a return statement in the PSL interrupt handler in the
case of an AFU error, which would trigger an "Unhandled CXL PSL IRQ"
warning. We do actually handle these type of errors (by notifying
userspace), so add the missing return IRQ_HANDLED so we don't throw
unecessary warnings.
Signed-off-by: Ian Munsie <imunsie@au1.ibm.com>
---
drivers/misc/cxl/irq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c
index ef52af7..2a2e58a 100644
--- a/drivers/misc/cxl/irq.c
+++ b/drivers/misc/cxl/irq.c
@@ -170,6 +170,7 @@ static irqreturn_t cxl_irq(int irq, void *data, struct cxl_irq_info *irq_info)
}
cxl_ack_irq(ctx, CXL_PSL_TFC_An_A, 0);
+ return IRQ_HANDLED;
}
if (dsisr & CXL_PSL_DSISR_An_OC)
pr_devel("CXL interrupt: OS Context Warning\n");
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-04 8:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-04 8:10 [PATCH] cxl: Add missing return statement after handling AFU errror Ian Munsie
2015-02-04 8:10 ` Ian Munsie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.