All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rootfs.py: ignore "NOTE:" when catching warnings
@ 2015-02-06 20:59 Ricardo Neri
  2015-02-06 20:59 ` [PATCH] runqemu: Add option for BIOS binary filename Ricardo Neri
  0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Neri @ 2015-02-06 20:59 UTC (permalink / raw)
  To: Richard Purdie, Saul Wold, openembedded-core

The script looks for any warn|Warn pattern in the log. However,
it may happen that the warn|Warn pattern appears as part of the name
of the objects described in the NOTE lines of the log. Thus, to avoid
false positives, ignore the line if it contains the word "NOTE:"

Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
---
 meta/lib/oe/rootfs.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/lib/oe/rootfs.py b/meta/lib/oe/rootfs.py
index f42a2ae..dd7aa44 100644
--- a/meta/lib/oe/rootfs.py
+++ b/meta/lib/oe/rootfs.py
@@ -359,7 +359,7 @@ class RpmRootfs(Rootfs):
         log_path = self.d.expand("${T}/log.do_rootfs")
         with open(log_path, 'r') as log:
             for line in log.read().split('\n'):
-                if 'log_check' in line:
+                if 'log_check' or 'NOTE:' in line:
                     continue
 
                 m = r.search(line)
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] runqemu: Add option for BIOS binary filename
  2015-02-06 20:59 [PATCH] rootfs.py: ignore "NOTE:" when catching warnings Ricardo Neri
@ 2015-02-06 20:59 ` Ricardo Neri
  0 siblings, 0 replies; 2+ messages in thread
From: Ricardo Neri @ 2015-02-06 20:59 UTC (permalink / raw)
  To: Richard Purdie, Saul Wold, openembedded-core

If we intend to use a custom BIOS binary file, it would be good to be
able to specify the name of the binary via the -bios option of qemu. The
name of the custom binary could be different from the default name used
by qemu. For instance, it was bios.bin in qemu 1.5.0 and changed to
bios-256k.bin for 2.1.0.

Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
---
 scripts/runqemu | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/runqemu b/scripts/runqemu
index da35bb8..3d75319 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -153,6 +153,9 @@ while true; do
 	"biosdir="*)
             CUSTOMBIOSDIR="${arg##biosdir=}"
 	    ;;
+        "biosfilename="*)
+            SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -bios ${arg##biosfilename=}"
+            ;;
         "qemuparams="*)
             SCRIPT_QEMU_EXTRA_OPT="${arg##qemuparams=}"
 
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-02-06 21:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-06 20:59 [PATCH] rootfs.py: ignore "NOTE:" when catching warnings Ricardo Neri
2015-02-06 20:59 ` [PATCH] runqemu: Add option for BIOS binary filename Ricardo Neri

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.