* [PATCH] staging: lustre: lnet: lnet: lip-ptl:fix sparse warning of static declaration
@ 2015-02-09 16:15 Mohammad Jamal
2015-02-09 16:29 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Mohammad Jamal @ 2015-02-09 16:15 UTC (permalink / raw)
To: oleg.drokin, andreas.dilger, gregkh, sudipm.mukherjee, joe,
devel, HPDD-discuss, linux-kernel
Cc: Mohammad Jamal
This patch adds a static keyword to variable portal_rotor to
suppress the sparse warning of static declaration
Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
---
drivers/staging/lustre/lnet/lnet/lib-ptl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-ptl.c b/drivers/staging/lustre/lnet/lnet/lib-ptl.c
index 19ed696..6652036 100644
--- a/drivers/staging/lustre/lnet/lnet/lib-ptl.c
+++ b/drivers/staging/lustre/lnet/lnet/lib-ptl.c
@@ -39,7 +39,7 @@
#include "../../include/linux/lnet/lib-lnet.h"
/* NB: add /proc interfaces in upcoming patches */
-int portal_rotor = LNET_PTL_ROTOR_HASH_RT;
+static int portal_rotor = LNET_PTL_ROTOR_HASH_RT;
module_param(portal_rotor, int, 0644);
MODULE_PARM_DESC(portal_rotor, "redirect PUTs to different cpu-partitions");
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: lustre: lnet: lnet: lip-ptl:fix sparse warning of static declaration
2015-02-09 16:15 [PATCH] staging: lustre: lnet: lnet: lip-ptl:fix sparse warning of static declaration Mohammad Jamal
@ 2015-02-09 16:29 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2015-02-09 16:29 UTC (permalink / raw)
To: Mohammad Jamal
Cc: oleg.drokin, andreas.dilger, gregkh, sudipm.mukherjee, devel,
HPDD-discuss, linux-kernel
On Mon, 2015-02-09 at 21:45 +0530, Mohammad Jamal wrote:
> This patch adds a static keyword to variable portal_rotor to
> suppress the sparse warning of static declaration
Do please compile the subsystem before sending patches.
> diff --git a/drivers/staging/lustre/lnet/lnet/lib-ptl.c b/drivers/staging/lustre/lnet/lnet/lib-ptl.c
[]
> @@ -39,7 +39,7 @@
> #include "../../include/linux/lnet/lib-lnet.h"
>
> /* NB: add /proc interfaces in upcoming patches */
> -int portal_rotor = LNET_PTL_ROTOR_HASH_RT;
> +static int portal_rotor = LNET_PTL_ROTOR_HASH_RT;
> module_param(portal_rotor, int, 0644);
> MODULE_PARM_DESC(portal_rotor, "redirect PUTs to different cpu-partitions");
$ git grep -w portal_rotor
...
drivers/staging/lustre/lnet/lnet/router_proc.c:extern int portal_rotor;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-09 16:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-09 16:15 [PATCH] staging: lustre: lnet: lnet: lip-ptl:fix sparse warning of static declaration Mohammad Jamal
2015-02-09 16:29 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.