From: Robert ABEL <rabel@cit-ec.uni-bielefeld.de>
To: khilman@deeprootsystems.com, tony@atomide.com,
linux@arm.linux.org.uk, linux-omap@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Robert ABEL <rabel@cit-ec.uni-bielefeld.de>
Subject: [PATCH 0/4] ARM OMAP2+ GPMC: various fixes and bus children
Date: Mon, 16 Feb 2015 16:48:57 +0100 [thread overview]
Message-ID: <1424101741-24152-1-git-send-email-rabel@cit-ec.uni-bielefeld.de> (raw)
I found a few more bugs in the GPMC driver. The first three patches should be self-explanatory:
*debug output was unaligned --> align it
*GPMCFCLKDIVIDER is used in all use cases --> always program it
*WAITMONITORINGTIME was computed in FCLK ticks instead of CLK ticks --> compute in CLK ticks
The last patch adds bus children to the GPMC. Currently, the GPMC driver
only supports direct children, which means one child with unique settings per CS region.
This patch adds explicit code inside the GPMC driver to probe for busses and
instantiate their children. (As opposed to adding the GPMC to of_default_bus_match_table
so it would be matched when the DT is first populated.)
GPMC properties apply to busses as well as direct children and map to whole CS regions.
Example:
&gpmc {
ranges = </* CS0 */ 0 /* offset (broken) */ 0x0000 /* OCP address */ 0x1000000 /* size */ 0x1000000>;
my_bus: nor@0,0x0000 { /* CS0; offset 0x0000 */
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <1>;
ranges = </* address */ 0x0000 /* parent address */ 0 0x0000 /* size */ 0x1000000>;
reg = </* parent address */0 0x0000 /* size */ 0x1000000>;
bank-width = <2>; /* GPMC_DEVWIDTH_16BIT */
gpmc,sync-read;
gpmc,sync-write;
gpmc,sync-clk-ps = ...;
... etc. ...
reg-io-width = <2>;
my_subdev0: subdev@0x0000 { /* address 0x0000 */
compatible = "my,driver0";
reg = </* parent address */ 0x0000 /* size */ 0x0800000>;
};
... etc. ...
my_subdevN: subdev@0x8000 { /* address 0x8000 */
compatible = "my,driverN";
reg = </* parent address */ 0x0000 /* size */ 0x0800000>;
};
};
};
Robert ABEL (4):
ARM OMAP2+ GPMC: fix debug output alignment
ARM OMAP2+ GPMC: always program GPMCFCLKDIVIDER
ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug
ARM OMAP2+ GPMC: add bus children
arch/arm/mach-omap2/gpmc.c | 105 ++++++++++++++++++++++++++++++++++-----------
1 file changed, 81 insertions(+), 24 deletions(-)
--
2.3.0
next reply other threads:[~2015-02-16 15:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 15:48 Robert ABEL [this message]
2015-02-16 15:48 ` [PATCH 1/4] ARM OMAP2+ GPMC: fix debug output alignment Robert ABEL
2015-02-16 15:48 ` [PATCH 2/4] ARM OMAP2+ GPMC: always program GPMCFCLKDIVIDER Robert ABEL
2015-02-16 15:49 ` [PATCH 3/4] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug Robert ABEL
2015-02-16 15:49 ` [PATCH 4/4] ARM OMAP2+ GPMC: add bus children Robert ABEL
2015-02-17 9:41 ` Roger Quadros
2015-02-17 9:41 ` Roger Quadros
2015-02-17 13:57 ` Robert Abel
2015-02-17 14:15 ` Roger Quadros
2015-02-17 14:15 ` Roger Quadros
2015-02-17 9:27 ` [PATCH 3/4] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug Roger Quadros
2015-02-17 9:27 ` Roger Quadros
2015-02-17 13:48 ` Robert Abel
2015-02-17 13:56 ` Roger Quadros
2015-02-17 13:56 ` Roger Quadros
2015-02-16 17:10 ` [PATCH 2/4] ARM OMAP2+ GPMC: always program GPMCFCLKDIVIDER Tony Lindgren
2015-02-16 20:09 ` Robert Abel
2015-02-17 8:12 ` Roger Quadros
2015-02-17 8:12 ` Roger Quadros
2015-02-17 13:47 ` Robert Abel
[not found] ` <CAMdRc4F9B0ft-ExgQ1vHqwXMiONwWKn3FPCRDyHsjgGe1Dn_1w@mail.gmail.com>
2015-02-17 13:52 ` Roger Quadros
2015-02-17 13:52 ` Roger Quadros
2015-02-17 14:06 ` Robert Abel
2015-02-17 14:25 ` Roger Quadros
2015-02-17 14:25 ` Roger Quadros
2015-02-23 21:38 ` Robert Abel
2015-02-23 22:03 ` Tony Lindgren
2015-02-24 11:53 ` Roger Quadros
2015-02-24 11:53 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424101741-24152-1-git-send-email-rabel@cit-ec.uni-bielefeld.de \
--to=rabel@cit-ec.uni-bielefeld.de \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.