Re: [PATCH 4/4] ARM OMAP2+ GPMC: add bus children

From: Robert Abel <rabel@cit-ec.uni-bielefeld.de>
To: Roger Quadros <rogerq@ti.com>
Cc: khilman@deeprootsystems.com, Tony Lindgren <tony@atomide.com>,
	linux@arm.linux.org.uk, linux-omap@vger.kernel.org,
	Linux Kernel Maling List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] ARM OMAP2+ GPMC: add bus children
Date: Tue, 17 Feb 2015 14:57:18 +0100	[thread overview]
Message-ID: <CAMdRc4FXv1sgAJEOO410Z9YT1gdYUyfzfo__fn2gFaaRKa2jAA@mail.gmail.com> (raw)
In-Reply-To: <54E30CD6.6020905@ti.com>

Hi Roger,

On Tue, Feb 17, 2015 at 10:41 AM, Roger Quadros <rogerq@ti.com> wrote:>
> Can we simply use only
> of_platform_populate(child, NULL, NULL, &pdev->dev)
>
> That way we get rid of the if..else and let OF core take care of
> creating buses or devices.

Surely, you mean

>of_platform_populate(child, of_default_bus_match_table, NULL, &pdev->dev);

? If matches is NULL, we won't match any busses. Or did you mean to
just replace the second conditional?

I'll try that and see it works.

Regards,

Robert