[PATCH] Staging: media: vino: Replace C99 with C89 style comment.

[PATCH] Staging: media: vino: Replace C99 with C89 style comment.

[Ksenija Stanojevic]

This patch fixes checkpatch.pl error in saa7191.c file
ERROR: "do not use C99 // comments"

Signed-off-by: Ksenija Stanojevic<ksenija.stanojevic@gmail.com>
---
 drivers/staging/media/vino/saa7191.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/vino/saa7191.c b/drivers/staging/media/vino/saa7191.c
index 8e96992..087acab 100644
--- a/drivers/staging/media/vino/saa7191.c
+++ b/drivers/staging/media/vino/saa7191.c
@@ -33,7 +33,7 @@ MODULE_AUTHOR("Mikael Nousiainen <tmnousia@cc.hut.fi>");
 MODULE_LICENSE("GPL");
 
 
-// #define SAA7191_DEBUG
+/* #define SAA7191_DEBUG */
 
 #ifdef SAA7191_DEBUG
 #define dprintk(x...) printk("SAA7191: " x);
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: media: vino: Replace C99 with C89 style comment.

[Arnd Bergmann]

On Tuesday 17 February 2015 15:27:24 Ksenija Stanojevic wrote:
> diff --git a/drivers/staging/media/vino/saa7191.c b/drivers/staging/media/vino/saa7191.c
> index 8e96992..087acab 100644
> --- a/drivers/staging/media/vino/saa7191.c
> +++ b/drivers/staging/media/vino/saa7191.c
> @@ -33,7 +33,7 @@ MODULE_AUTHOR("Mikael Nousiainen <tmnousia@cc.hut.fi>");
>  MODULE_LICENSE("GPL");
>  
>  
> -// #define SAA7191_DEBUG
> +/* #define SAA7191_DEBUG */
>  
>  #ifdef SAA7191_DEBUG
>  #define dprintk(x...) printk("SAA7191: " x);
> 

The patch looks correct, but it's worth noting that the comment here
is used for a particular purpose that is also against coding style:
instead of defining its own dprintk() macro that depends on
SAA7191_DEBUG, the driver should just use the 'pr_debug' symbol
that is provided by the kernel for the same purpose.

Can you try replacing all uses of dprintk in this driver with
pr_debug or (better) dev_dbg() and remove the other definitions
as well?

	Arnd

Re: [PATCH] Staging: media: vino: Replace C99 with C89 style comment.

[Ksenija Stanojevic]

[-- Attachment #1.1: Type: text/plain, Size: 966 bytes --]

Yes, I can try. Should I make those changes in form of individual patch(es) 
or make a patchset along with this patch

On Tuesday, February 17, 2015 at 3:30:08 PM UTC+1, Ksenija Stanojevic wrote:
>
> This patch fixes checkpatch.pl error in saa7191.c file 
> ERROR: "do not use C99 // comments" 
>
> Signed-off-by: Ksenija Stanojevic<ksenija.stanojevic@gmail.com> 
> --- 
>  drivers/staging/media/vino/saa7191.c | 2 +- 
>  1 file changed, 1 insertion(+), 1 deletion(-) 
>
> diff --git a/drivers/staging/media/vino/saa7191.c 
> b/drivers/staging/media/vino/saa7191.c 
> index 8e96992..087acab 100644 
> --- a/drivers/staging/media/vino/saa7191.c 
> +++ b/drivers/staging/media/vino/saa7191.c 
> @@ -33,7 +33,7 @@ MODULE_AUTHOR("Mikael Nousiainen <tmnousia@cc.hut.fi>"); 
>
>  MODULE_LICENSE("GPL"); 
>   
>   
> -// #define SAA7191_DEBUG 
> +/* #define SAA7191_DEBUG */ 
>   
>  #ifdef SAA7191_DEBUG 
>  #define dprintk(x...) printk("SAA7191: " x); 
> -- 
> 1.9.1 
>
>

[-- Attachment #1.2: Type: text/html, Size: 1398 bytes --]

Re: [Outreachy kernel] Re: [PATCH] Staging: media: vino: Replace C99 with C89 style comment.

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1958 bytes --]

On Tue, 17 Feb 2015, Ksenija Stanojevic wrote:

> Yes, I can try. Should I make those changes in form of individual patch(es)
> or make a patchset along with this patch

I don't think that you need to preserve this patch.  When you make the
change that Arnd proposes, all of the code involved in this patch will go
away.  When you make the new patch, it will be doing one thing over and
over in a single file, so that would be just one patch.

julia

>
> On Tuesday, February 17, 2015 at 3:30:08 PM UTC+1, Ksenija Stanojevic wrote:
>       This patch fixes checkpatch.pl error in saa7191.c file
>       ERROR: "do not use C99 // comments"
>
>       Signed-off-by: Ksenija Stanojevic<ksenija.stanojevic@gmail.com>
>       ---
>        drivers/staging/media/vino/saa7191.c | 2 +-
>        1 file changed, 1 insertion(+), 1 deletion(-)
>
>       diff --git a/drivers/staging/media/vino/saa7191.c
>       b/drivers/staging/media/vino/saa7191.c
>       index 8e96992..087acab 100644
>       --- a/drivers/staging/media/vino/saa7191.c
>       +++ b/drivers/staging/media/vino/saa7191.c
>       @@ -33,7 +33,7 @@ MODULE_AUTHOR("Mikael Nousiainen
>       <tmnousia@cc.hut.fi>");
>        MODULE_LICENSE("GPL");
>        
>        
>       -// #define SAA7191_DEBUG
>       +/* #define SAA7191_DEBUG */
>        
>        #ifdef SAA7191_DEBUG
>        #define dprintk(x...) printk("SAA7191: " x);
>       --
>       1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/b15e99a1-8a07-44ea-a6c5-
> b749f6e3d8cc%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Re: [PATCH] Staging: media: vino: Replace C99 with C89 style comment.

[Ksenija Stanojevic]

[-- Attachment #1.1: Type: text/plain, Size: 861 bytes --]

Ok thanks ;)

On Tuesday, February 17, 2015 at 3:30:08 PM UTC+1, Ksenija Stanojevic wrote:
>
> This patch fixes checkpatch.pl error in saa7191.c file 
> ERROR: "do not use C99 // comments" 
>
> Signed-off-by: Ksenija Stanojevic<ksenija.stanojevic@gmail.com> 
> --- 
>  drivers/staging/media/vino/saa7191.c | 2 +- 
>  1 file changed, 1 insertion(+), 1 deletion(-) 
>
> diff --git a/drivers/staging/media/vino/saa7191.c 
> b/drivers/staging/media/vino/saa7191.c 
> index 8e96992..087acab 100644 
> --- a/drivers/staging/media/vino/saa7191.c 
> +++ b/drivers/staging/media/vino/saa7191.c 
> @@ -33,7 +33,7 @@ MODULE_AUTHOR("Mikael Nousiainen <tmnousia@cc.hut.fi>"); 
>
>  MODULE_LICENSE("GPL"); 
>   
>   
> -// #define SAA7191_DEBUG 
> +/* #define SAA7191_DEBUG */ 
>   
>  #ifdef SAA7191_DEBUG 
>  #define dprintk(x...) printk("SAA7191: " x); 
> -- 
> 1.9.1 
>
>

[-- Attachment #1.2: Type: text/html, Size: 1294 bytes --]