From: Dario Faggioli <dario.faggioli@citrix.com>
To: "ufimtseva@gmail.com" <ufimtseva@gmail.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
"JBeulich@suse.com" <JBeulich@suse.com>,
Ian Jackson <Ian.Jackson@citrix.com>
Subject: Re: [PATCH v5 08/24] libxl: introduce libxl__vnuma_config_check
Date: Tue, 17 Feb 2015 16:51:03 +0000 [thread overview]
Message-ID: <1424191861.4235.98.camel@citrix.com> (raw)
In-Reply-To: <CAEr7rXiqFXFOe-oytpsHkcv-yccj-yD8ZcyOm5Duj7kBFiqLkg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1294 bytes --]
On Fri, 2015-02-13 at 11:11 -0500, Elena Ufimtseva wrote:
> On Fri, Feb 13, 2015 at 11:06 AM, Wei Liu <wei.liu2@citrix.com> wrote:
> > On Fri, Feb 13, 2015 at 10:39:25AM -0500, Elena Ufimtseva wrote:
> >> Any sanity checks for distances?
> >>
> >
> > The same applies, what is a valid distance what is not? I guess zero is
> > not valid? Or do we enforce that the distance to local node must be
> > smaller than or equal to the distance to remote node?
>
> Yes, I think the second condition is enough for strict checking.
>
That would not harm, probably but I honestly would not put down much
enforcement on distance values. We can enforce non-zero values, we can
enforce local < remote, we can enforce the symmetry of the distance
matrix, but, really, I wouldn't go that far.
What matters most wrt specification of the distances, is to provide a
sane default, in case one does not want to bother writing it down (or
does not want to write it down completely, as it could be tedious).
So, if one does not say anything, we should come up with something that
makes sense (and I'll say more about this while reviewing patch 24). If
the user does say something, I would just go with that... perhaps after
printing a warning, but no more than that.
Regards,
Dario
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-02-17 16:51 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 19:44 [PATCH v5 00/24] Virtual NUMA for PV and HVM Wei Liu
2015-02-12 19:44 ` [PATCH v5 01/24] xen: dump vNUMA information with debug key "u" Wei Liu
2015-02-13 11:50 ` Andrew Cooper
2015-02-16 14:35 ` Dario Faggioli
2015-02-12 19:44 ` [PATCH v5 02/24] xen: make two memory hypercalls vNUMA-aware Wei Liu
2015-02-13 12:00 ` Andrew Cooper
2015-02-13 13:24 ` Wei Liu
2015-02-12 19:44 ` [PATCH v5 03/24] libxc: duplicate snippet to allocate p2m_host array Wei Liu
2015-02-12 19:44 ` [PATCH v5 04/24] libxc: add p2m_size to xc_dom_image Wei Liu
2015-02-16 14:46 ` Dario Faggioli
2015-02-16 14:49 ` Wei Liu
2015-02-12 19:44 ` [PATCH v5 05/24] libxc: allocate memory with vNUMA information for PV guest Wei Liu
2015-02-13 14:30 ` Andrew Cooper
2015-02-13 15:05 ` Wei Liu
2015-02-13 15:17 ` Andrew Cooper
2015-02-16 16:58 ` Dario Faggioli
2015-02-16 17:44 ` Wei Liu
2015-02-12 19:44 ` [PATCH v5 06/24] libxl: introduce vNUMA types Wei Liu
2015-02-16 14:58 ` Dario Faggioli
2015-02-16 15:17 ` Wei Liu
2015-02-16 15:56 ` Dario Faggioli
2015-02-16 16:11 ` Wei Liu
2015-02-16 16:51 ` Dario Faggioli
2015-02-16 17:38 ` Wei Liu
2015-02-17 10:42 ` Dario Faggioli
2015-02-12 19:44 ` [PATCH v5 07/24] libxl: add vmemrange to libxl__domain_build_state Wei Liu
2015-02-16 16:00 ` Dario Faggioli
2015-02-16 16:15 ` Wei Liu
2015-02-12 19:44 ` [PATCH v5 08/24] libxl: introduce libxl__vnuma_config_check Wei Liu
2015-02-13 14:15 ` Ian Jackson
2015-02-13 15:12 ` Wei Liu
2015-02-13 15:39 ` Elena Ufimtseva
2015-02-13 16:06 ` Wei Liu
2015-02-13 16:11 ` Elena Ufimtseva
2015-02-17 16:51 ` Dario Faggioli [this message]
2015-02-22 15:50 ` Wei Liu
2015-02-17 16:44 ` Dario Faggioli
2015-02-13 15:40 ` Andrew Cooper
2015-02-17 12:56 ` Wei Liu
2015-03-02 15:13 ` Ian Campbell
2015-03-02 15:25 ` Andrew Cooper
2015-03-02 16:05 ` Ian Campbell
2015-02-17 16:38 ` Dario Faggioli
2015-02-22 15:47 ` Wei Liu
2015-02-12 19:44 ` [PATCH v5 09/24] libxl: x86: factor out e820_host_sanitize Wei Liu
2015-02-13 15:42 ` Andrew Cooper
2015-02-16 17:00 ` Dario Faggioli
2015-02-12 19:44 ` [PATCH v5 10/24] libxl: functions to build vmemranges for PV guest Wei Liu
2015-02-13 15:49 ` Andrew Cooper
2015-02-17 14:08 ` Wei Liu
2015-02-17 15:28 ` Dario Faggioli
2015-02-17 15:32 ` Wei Liu
2015-02-12 19:44 ` [PATCH v5 11/24] libxl: build, check and pass vNUMA info to Xen " Wei Liu
2015-02-13 15:54 ` Andrew Cooper
2015-02-17 14:49 ` Dario Faggioli
2015-02-12 19:44 ` [PATCH v5 12/24] hvmloader: retrieve vNUMA information from hypervisor Wei Liu
2015-02-13 15:58 ` Andrew Cooper
2015-02-17 11:36 ` Jan Beulich
2015-02-17 11:42 ` Wei Liu
2015-02-12 19:44 ` [PATCH v5 13/24] hvmloader: construct SRAT Wei Liu
2015-02-13 16:07 ` Andrew Cooper
2015-02-12 19:44 ` [PATCH v5 14/24] hvmloader: construct SLIT Wei Liu
2015-02-13 16:10 ` Andrew Cooper
2015-02-12 19:44 ` [PATCH v5 15/24] libxc: indentation change to xc_hvm_build_x86.c Wei Liu
2015-02-12 19:44 ` [PATCH v5 16/24] libxc: allocate memory with vNUMA information for HVM guest Wei Liu
2015-02-13 16:22 ` Andrew Cooper
2015-02-12 19:44 ` [PATCH v5 17/24] libxl: build, check and pass vNUMA info to Xen " Wei Liu
2015-02-13 14:21 ` Ian Jackson
2015-02-13 15:18 ` Wei Liu
2015-02-17 14:26 ` Dario Faggioli
2015-02-17 14:41 ` Wei Liu
2015-02-12 19:44 ` [PATCH v5 18/24] libxl: disallow memory relocation when vNUMA is enabled Wei Liu
2015-02-13 14:17 ` Ian Jackson
2015-02-13 15:18 ` Wei Liu
2015-02-12 19:44 ` [PATCH v5 19/24] libxl: define LIBXL_HAVE_VNUMA Wei Liu
2015-02-13 14:12 ` Ian Jackson
2015-02-13 15:21 ` Wei Liu
2015-02-13 15:26 ` Ian Jackson
2015-02-13 15:27 ` Ian Jackson
2015-02-13 15:28 ` Wei Liu
2015-02-12 19:44 ` [PATCH v5 20/24] libxlu: rework internal representation of setting Wei Liu
2015-02-13 14:24 ` Ian Jackson
2015-02-12 19:44 ` [PATCH v5 21/24] libxlu: nested list support Wei Liu
2015-02-12 19:44 ` [PATCH v5 22/24] libxlu: introduce new APIs Wei Liu
2015-02-13 14:12 ` Ian Jackson
2015-02-16 19:10 ` Wei Liu
2015-02-16 19:47 ` Wei Liu
2015-02-12 19:44 ` [PATCH v5 23/24] xl: introduce xcalloc Wei Liu
2015-02-12 20:17 ` Andrew Cooper
2015-02-13 10:25 ` Wei Liu
2015-02-12 19:44 ` [PATCH v5 24/24] xl: vNUMA support Wei Liu
2015-02-24 16:19 ` Dario Faggioli
2015-02-24 16:31 ` Wei Liu
2015-02-24 16:44 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424191861.4235.98.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=JBeulich@suse.com \
--cc=ufimtseva@gmail.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.