All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: i2o: Remove uses of return value of seq_printf
@ 2015-02-17 19:02 Joe Perches
  0 siblings, 0 replies; only message in thread
From: Joe Perches @ 2015-02-17 19:02 UTC (permalink / raw)
  To: Greg KH; +Cc: LKML

Even though this subsystem will go away soonish, using
the return value of seq_printf prevents changing the
return type of seq_<foo> functions to void.

This allows seq_<foo> functions to become void functions
without breaking compilation if this subsystem isn't
deleted before the seq_<foo> functions are converted.

Eliminate these uses by changing the return value of
the enclosing i2o_report_query_status function to void.
Nothing uses the return value of this function.

Change one fixed string to seq_puts just to keep the
silly patch checker quiet.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/staging/i2o/i2o_proc.c | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/i2o/i2o_proc.c b/drivers/staging/i2o/i2o_proc.c
index ad84f33..6074eab 100644
--- a/drivers/staging/i2o/i2o_proc.c
+++ b/drivers/staging/i2o/i2o_proc.c
@@ -261,20 +261,23 @@ static char *chtostr(char *tmp, u8 *chars, int n)
 	return strncat(tmp, (char *)chars, n);
 }
 
-static int i2o_report_query_status(struct seq_file *seq, int block_status,
-				   char *group)
+static void i2o_report_query_status(struct seq_file *seq, int block_status,
+				    char *group)
 {
 	switch (block_status) {
 	case -ETIMEDOUT:
-		return seq_printf(seq, "Timeout reading group %s.\n", group);
+		seq_printf(seq, "Timeout reading group %s.\n", group);
+		break;
 	case -ENOMEM:
-		return seq_printf(seq, "No free memory to read the table.\n");
+		seq_puts(seq, "No free memory to read the table.\n");
+		break;
 	case -I2O_PARAMS_STATUS_INVALID_GROUP_ID:
-		return seq_printf(seq, "Group %s not supported.\n", group);
+		seq_printf(seq, "Group %s not supported.\n", group);
+		break;
 	default:
-		return seq_printf(seq,
-				  "Error reading group %s. BlockStatus 0x%02X\n",
-				  group, -block_status);
+		seq_printf(seq, "Error reading group %s. BlockStatus 0x%02X\n",
+			   group, -block_status);
+		break;
 	}
 }
 



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-02-17 19:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-17 19:02 [PATCH] staging: i2o: Remove uses of return value of seq_printf Joe Perches

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.