* [PATCH] Staging: rts5208: Remove braces around single if-statement
@ 2015-02-17 19:15 Haneen Mohammed
2015-02-18 20:35 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: Haneen Mohammed @ 2015-02-17 19:15 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Haneen Mohammed
This patch fixes the checkpatch.pl warning:
WARNING: suspect code indent for conditional statements (8, 8)
Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
---
drivers/staging/rts5208/rtsx_scsi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_scsi.c b/drivers/staging/rts5208/rtsx_scsi.c
index 1161082..42645834 100644
--- a/drivers/staging/rts5208/rtsx_scsi.c
+++ b/drivers/staging/rts5208/rtsx_scsi.c
@@ -519,10 +519,8 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)
#else
if (chip->mspro_formatter_enable)
#endif
- {
if (!card || (card == MS_CARD))
pro_formatter_flag = 1;
- }
if (pro_formatter_flag) {
if (scsi_bufflen(srb) < 56)
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] Staging: rts5208: Remove braces around single if-statement
2015-02-18 20:35 ` [Outreachy kernel] " Julia Lawall
@ 2015-02-17 20:38 ` Haneen Mohammed
2015-02-17 21:10 ` Haneen Mohammed
0 siblings, 1 reply; 6+ messages in thread
From: Haneen Mohammed @ 2015-02-17 20:38 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Haneen Mohammed
This patch fixes the following checkpatch.pl warning:
"WARNING: suspect code indent for conditional statements (8, 8)"
By removing unneeded braces around a single if-statement.
Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
---
drivers/staging/rts5208/rtsx_scsi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_scsi.c b/drivers/staging/rts5208/rtsx_scsi.c
index 1161082..42645834 100644
--- a/drivers/staging/rts5208/rtsx_scsi.c
+++ b/drivers/staging/rts5208/rtsx_scsi.c
@@ -519,10 +519,8 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)
#else
if (chip->mspro_formatter_enable)
#endif
- {
if (!card || (card == MS_CARD))
pro_formatter_flag = 1;
- }
if (pro_formatter_flag) {
if (scsi_bufflen(srb) < 56)
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] Staging: rts5208: Remove braces around single if-statement
2015-02-17 20:38 ` Haneen Mohammed
@ 2015-02-17 21:10 ` Haneen Mohammed
2015-02-18 22:16 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: Haneen Mohammed @ 2015-02-17 21:10 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Haneen Mohammed
This patch removes unneeded braces around a single if-statement.
This problem was found using checkpatch.pl.
Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
---
v2: changed commit message
drivers/staging/rts5208/rtsx_scsi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_scsi.c b/drivers/staging/rts5208/rtsx_scsi.c
index 1161082..42645834 100644
--- a/drivers/staging/rts5208/rtsx_scsi.c
+++ b/drivers/staging/rts5208/rtsx_scsi.c
@@ -519,10 +519,8 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)
#else
if (chip->mspro_formatter_enable)
#endif
- {
if (!card || (card == MS_CARD))
pro_formatter_flag = 1;
- }
if (pro_formatter_flag) {
if (scsi_bufflen(srb) < 56)
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] Staging: rts5208: Remove braces around single if-statement
2015-02-18 22:16 ` [Outreachy kernel] " Julia Lawall
@ 2015-02-17 21:21 ` Haneen Mohammed
0 siblings, 0 replies; 6+ messages in thread
From: Haneen Mohammed @ 2015-02-17 21:21 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Haneen Mohammed
This patch removes unneeded braces around a single if-statement.
This problem was found using checkpatch.pl.
Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
---
v2: changed commit message
drivers/staging/rts5208/rtsx_scsi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_scsi.c b/drivers/staging/rts5208/rtsx_scsi.c
index 1161082..42645834 100644
--- a/drivers/staging/rts5208/rtsx_scsi.c
+++ b/drivers/staging/rts5208/rtsx_scsi.c
@@ -519,10 +519,8 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)
#else
if (chip->mspro_formatter_enable)
#endif
- {
if (!card || (card == MS_CARD))
pro_formatter_flag = 1;
- }
if (pro_formatter_flag) {
if (scsi_bufflen(srb) < 56)
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rts5208: Remove braces around single if-statement
2015-02-17 19:15 [PATCH] Staging: rts5208: Remove braces around single if-statement Haneen Mohammed
@ 2015-02-18 20:35 ` Julia Lawall
2015-02-17 20:38 ` Haneen Mohammed
0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2015-02-18 20:35 UTC (permalink / raw)
To: Haneen Mohammed; +Cc: outreachy-kernel
On Tue, 17 Feb 2015, Haneen Mohammed wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: suspect code indent for conditional statements (8, 8)
Please change the commit message as well. It should reflect what was
done.
julia
>
> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> ---
> drivers/staging/rts5208/rtsx_scsi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx_scsi.c b/drivers/staging/rts5208/rtsx_scsi.c
> index 1161082..42645834 100644
> --- a/drivers/staging/rts5208/rtsx_scsi.c
> +++ b/drivers/staging/rts5208/rtsx_scsi.c
> @@ -519,10 +519,8 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)
> #else
> if (chip->mspro_formatter_enable)
> #endif
> - {
> if (!card || (card == MS_CARD))
> pro_formatter_flag = 1;
> - }
>
> if (pro_formatter_flag) {
> if (scsi_bufflen(srb) < 56)
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424200549-23115-1-git-send-email-hamohammed.sa%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rts5208: Remove braces around single if-statement
2015-02-17 21:10 ` Haneen Mohammed
@ 2015-02-18 22:16 ` Julia Lawall
2015-02-17 21:21 ` [PATCH v2] " Haneen Mohammed
0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2015-02-18 22:16 UTC (permalink / raw)
To: Haneen Mohammed; +Cc: outreachy-kernel
You need to put [PATCH v2] up in the subject line as well. Then is
immediately clear that this is the second version of the patch.
julia
On Wed, 18 Feb 2015, Haneen Mohammed wrote:
> This patch removes unneeded braces around a single if-statement.
> This problem was found using checkpatch.pl.
>
> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> ---
> v2: changed commit message
>
> drivers/staging/rts5208/rtsx_scsi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx_scsi.c b/drivers/staging/rts5208/rtsx_scsi.c
> index 1161082..42645834 100644
> --- a/drivers/staging/rts5208/rtsx_scsi.c
> +++ b/drivers/staging/rts5208/rtsx_scsi.c
> @@ -519,10 +519,8 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)
> #else
> if (chip->mspro_formatter_enable)
> #endif
> - {
> if (!card || (card == MS_CARD))
> pro_formatter_flag = 1;
> - }
>
> if (pro_formatter_flag) {
> if (scsi_bufflen(srb) < 56)
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424207434-24078-1-git-send-email-hamohammed.sa%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-02-18 22:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-17 19:15 [PATCH] Staging: rts5208: Remove braces around single if-statement Haneen Mohammed
2015-02-18 20:35 ` [Outreachy kernel] " Julia Lawall
2015-02-17 20:38 ` Haneen Mohammed
2015-02-17 21:10 ` Haneen Mohammed
2015-02-18 22:16 ` [Outreachy kernel] " Julia Lawall
2015-02-17 21:21 ` [PATCH v2] " Haneen Mohammed
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.