* [PATCH] arc: do not export symbols in troubleshoot.c
@ 2015-02-18 19:13 Davidlohr Bueso
2015-02-18 19:20 ` Davidlohr Bueso
0 siblings, 1 reply; 3+ messages in thread
From: Davidlohr Bueso @ 2015-02-18 19:13 UTC (permalink / raw)
To: Vineet Gupta, Andrew Morton; +Cc: linux-kernel, dave
print_task_path_n_nm() is local to this file, its only
user being show_regs(). Mark the function static and avoid
the EXPORT_SYMBOL.
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
---
Compile tested only.
arch/arc/kernel/troubleshoot.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arc/kernel/troubleshoot.c b/arch/arc/kernel/troubleshoot.c
index 1badf9b..e00a018 100644
--- a/arch/arc/kernel/troubleshoot.c
+++ b/arch/arc/kernel/troubleshoot.c
@@ -52,7 +52,7 @@ static void show_callee_regs(struct callee_regs *cregs)
print_reg_file(&(cregs->r13), 13);
}
-void print_task_path_n_nm(struct task_struct *tsk, char *buf)
+static void print_task_path_n_nm(struct task_struct *tsk, char *buf)
{
struct path path;
char *path_nm = NULL;
@@ -77,7 +77,6 @@ void print_task_path_n_nm(struct task_struct *tsk, char *buf)
done:
pr_info("Path: %s\n", path_nm);
}
-EXPORT_SYMBOL(print_task_path_n_nm);
static void show_faulting_vma(unsigned long address, char *buf)
{
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arc: do not export symbols in troubleshoot.c
2015-02-18 19:13 [PATCH] arc: do not export symbols in troubleshoot.c Davidlohr Bueso
@ 2015-02-18 19:20 ` Davidlohr Bueso
2015-02-19 10:51 ` Vineet Gupta
0 siblings, 1 reply; 3+ messages in thread
From: Davidlohr Bueso @ 2015-02-18 19:20 UTC (permalink / raw)
To: Vineet Gupta; +Cc: Andrew Morton, linux-kernel
On Wed, 2015-02-18 at 11:13 -0800, Davidlohr Bueso wrote:
> print_task_path_n_nm() is local to this file, its only
> user being show_regs(). Mark the function static and avoid
> the EXPORT_SYMBOL.
>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> ---
>
> Compile tested only.
What am I saying! not tested. Got confused with another patch :)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arc: do not export symbols in troubleshoot.c
2015-02-18 19:20 ` Davidlohr Bueso
@ 2015-02-19 10:51 ` Vineet Gupta
0 siblings, 0 replies; 3+ messages in thread
From: Vineet Gupta @ 2015-02-19 10:51 UTC (permalink / raw)
To: Davidlohr Bueso; +Cc: Andrew Morton, linux-kernel
On Thursday 19 February 2015 12:50 AM, Davidlohr Bueso wrote:
> On Wed, 2015-02-18 at 11:13 -0800, Davidlohr Bueso wrote:
>> > print_task_path_n_nm() is local to this file, its only
>> > user being show_regs(). Mark the function static and avoid
>> > the EXPORT_SYMBOL.
>> >
>> > Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
>> > ---
>> >
>> > Compile tested only.
> What am I saying! not tested. Got confused with another patch :)
>
And I got excited that core kernel developers are now starting to compile for ARC
:-) I'm sure we will get there.
Thx for the patch David.
Acked-by: Vineet Gupta <vgupta@synoipsys.com>
-Vineet
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-19 10:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-18 19:13 [PATCH] arc: do not export symbols in troubleshoot.c Davidlohr Bueso
2015-02-18 19:20 ` Davidlohr Bueso
2015-02-19 10:51 ` Vineet Gupta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.