* [PATCH 1/2] ath10k: increase duty cycle maximum limit
@ 2015-02-19 17:55 ` Rajkumar Manoharan
0 siblings, 0 replies; 8+ messages in thread
From: Rajkumar Manoharan @ 2015-02-19 17:55 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Rajkumar Manoharan
Allow user to configure the duty cycle upto 100%. Since thermal
mitigation algorithm is running in user space, remove the driver
level limitation and let the user to control the temperature.
Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/thermal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/thermal.h b/drivers/net/wireless/ath/ath10k/thermal.h
index bccc17a..5e87d9a 100644
--- a/drivers/net/wireless/ath/ath10k/thermal.h
+++ b/drivers/net/wireless/ath/ath10k/thermal.h
@@ -19,7 +19,7 @@
#define ATH10K_QUIET_PERIOD_DEFAULT 100
#define ATH10K_QUIET_PERIOD_MIN 25
#define ATH10K_QUIET_START_OFFSET 10
-#define ATH10K_QUIET_DUTY_CYCLE_MAX 70
+#define ATH10K_QUIET_DUTY_CYCLE_MAX 100
#define ATH10K_HWMON_NAME_LEN 15
#define ATH10K_THERMAL_SYNC_TIMEOUT_HZ (5*HZ)
--
2.3.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/2] ath10k: increase duty cycle maximum limit
@ 2015-02-19 17:55 ` Rajkumar Manoharan
0 siblings, 0 replies; 8+ messages in thread
From: Rajkumar Manoharan @ 2015-02-19 17:55 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Rajkumar Manoharan
Allow user to configure the duty cycle upto 100%. Since thermal
mitigation algorithm is running in user space, remove the driver
level limitation and let the user to control the temperature.
Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/thermal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/thermal.h b/drivers/net/wireless/ath/ath10k/thermal.h
index bccc17a..5e87d9a 100644
--- a/drivers/net/wireless/ath/ath10k/thermal.h
+++ b/drivers/net/wireless/ath/ath10k/thermal.h
@@ -19,7 +19,7 @@
#define ATH10K_QUIET_PERIOD_DEFAULT 100
#define ATH10K_QUIET_PERIOD_MIN 25
#define ATH10K_QUIET_START_OFFSET 10
-#define ATH10K_QUIET_DUTY_CYCLE_MAX 70
+#define ATH10K_QUIET_DUTY_CYCLE_MAX 100
#define ATH10K_HWMON_NAME_LEN 15
#define ATH10K_THERMAL_SYNC_TIMEOUT_HZ (5*HZ)
--
2.3.0
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ath10k: fix quiet duration configuration
2015-02-19 17:55 ` Rajkumar Manoharan
@ 2015-02-19 17:55 ` Rajkumar Manoharan
-1 siblings, 0 replies; 8+ messages in thread
From: Rajkumar Manoharan @ 2015-02-19 17:55 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Rajkumar Manoharan
Duty cycle is nothing but percentage of one period in which a
signal is active. But it is wrongly interpreted as ratio of quiet
duration. So fix the quiet duration to the remaining percentage
of duty cycle (active ratio).
Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/thermal.c b/drivers/net/wireless/ath/ath10k/thermal.c
index aede750..0d89ab5 100644
--- a/drivers/net/wireless/ath/ath10k/thermal.c
+++ b/drivers/net/wireless/ath/ath10k/thermal.c
@@ -98,7 +98,7 @@ static int ath10k_thermal_set_cur_dutycycle(struct thermal_cooling_device *cdev,
}
period = max(ATH10K_QUIET_PERIOD_MIN,
(ATH10K_QUIET_PERIOD_DEFAULT / num_bss));
- duration = (period * duty_cycle) / 100;
+ duration = (period * (100 - duty_cycle)) / 100;
enabled = duration ? 1 : 0;
ret = ath10k_wmi_pdev_set_quiet_mode(ar, period, duration,
--
2.3.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ath10k: fix quiet duration configuration
@ 2015-02-19 17:55 ` Rajkumar Manoharan
0 siblings, 0 replies; 8+ messages in thread
From: Rajkumar Manoharan @ 2015-02-19 17:55 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Rajkumar Manoharan
Duty cycle is nothing but percentage of one period in which a
signal is active. But it is wrongly interpreted as ratio of quiet
duration. So fix the quiet duration to the remaining percentage
of duty cycle (active ratio).
Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/thermal.c b/drivers/net/wireless/ath/ath10k/thermal.c
index aede750..0d89ab5 100644
--- a/drivers/net/wireless/ath/ath10k/thermal.c
+++ b/drivers/net/wireless/ath/ath10k/thermal.c
@@ -98,7 +98,7 @@ static int ath10k_thermal_set_cur_dutycycle(struct thermal_cooling_device *cdev,
}
period = max(ATH10K_QUIET_PERIOD_MIN,
(ATH10K_QUIET_PERIOD_DEFAULT / num_bss));
- duration = (period * duty_cycle) / 100;
+ duration = (period * (100 - duty_cycle)) / 100;
enabled = duration ? 1 : 0;
ret = ath10k_wmi_pdev_set_quiet_mode(ar, period, duration,
--
2.3.0
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ath10k: fix quiet duration configuration
2015-02-19 17:55 ` Rajkumar Manoharan
@ 2015-03-06 7:39 ` Rajkumar Manoharan
-1 siblings, 0 replies; 8+ messages in thread
From: Rajkumar Manoharan @ 2015-03-06 7:39 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, mka
On Thu, Feb 19, 2015 at 11:25:06PM +0530, Rajkumar Manoharan wrote:
> Duty cycle is nothing but percentage of one period in which a
> signal is active. But it is wrongly interpreted as ratio of quiet
> duration. So fix the quiet duration to the remaining percentage
> of duty cycle (active ratio).
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> ---
Kalle,
Please drop this change as it breaks the user space interface. Will send
updated patch ASAP. Sorry for the inconvenience.
-Rajkumar
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ath10k: fix quiet duration configuration
@ 2015-03-06 7:39 ` Rajkumar Manoharan
0 siblings, 0 replies; 8+ messages in thread
From: Rajkumar Manoharan @ 2015-03-06 7:39 UTC (permalink / raw)
To: ath10k; +Cc: mka, linux-wireless
On Thu, Feb 19, 2015 at 11:25:06PM +0530, Rajkumar Manoharan wrote:
> Duty cycle is nothing but percentage of one period in which a
> signal is active. But it is wrongly interpreted as ratio of quiet
> duration. So fix the quiet duration to the remaining percentage
> of duty cycle (active ratio).
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> ---
Kalle,
Please drop this change as it breaks the user space interface. Will send
updated patch ASAP. Sorry for the inconvenience.
-Rajkumar
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ath10k: increase duty cycle maximum limit
2015-02-19 17:55 ` Rajkumar Manoharan
@ 2015-03-07 7:53 ` Kalle Valo
-1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2015-03-07 7:53 UTC (permalink / raw)
To: Rajkumar Manoharan; +Cc: ath10k, linux-wireless
Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
> Allow user to configure the duty cycle upto 100%. Since thermal
> mitigation algorithm is running in user space, remove the driver
> level limitation and let the user to control the temperature.
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Thanks, patch 1 applied. And I dropped patch 2 as you requested.
--
Kalle Valo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ath10k: increase duty cycle maximum limit
@ 2015-03-07 7:53 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2015-03-07 7:53 UTC (permalink / raw)
To: Rajkumar Manoharan; +Cc: linux-wireless, ath10k
Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
> Allow user to configure the duty cycle upto 100%. Since thermal
> mitigation algorithm is running in user space, remove the driver
> level limitation and let the user to control the temperature.
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Thanks, patch 1 applied. And I dropped patch 2 as you requested.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-03-07 7:54 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-19 17:55 [PATCH 1/2] ath10k: increase duty cycle maximum limit Rajkumar Manoharan
2015-02-19 17:55 ` Rajkumar Manoharan
2015-02-19 17:55 ` [PATCH 2/2] ath10k: fix quiet duration configuration Rajkumar Manoharan
2015-02-19 17:55 ` Rajkumar Manoharan
2015-03-06 7:39 ` Rajkumar Manoharan
2015-03-06 7:39 ` Rajkumar Manoharan
2015-03-07 7:53 ` [PATCH 1/2] ath10k: increase duty cycle maximum limit Kalle Valo
2015-03-07 7:53 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.