* [PATCH] input: edt-ft5x06, Add i2c device ids
@ 2015-02-20 15:56 Markus Pargmann
2015-02-20 18:32 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Markus Pargmann @ 2015-02-20 15:56 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Lothar Waßmann, linux-input, kernel, Markus Pargmann
These ids are necessary to use edt-ft5x06 as a kernel module. Otherwise
it is not loaded automatically in userspace because the ids do not match.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
drivers/input/touchscreen/edt-ft5x06.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index d4c24fb7704f..63ad6d545bbe 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -1119,6 +1119,9 @@ static SIMPLE_DEV_PM_OPS(edt_ft5x06_ts_pm_ops,
static const struct i2c_device_id edt_ft5x06_ts_id[] = {
{ "edt-ft5x06", 0, },
+ { "edt-ft5206", 0, },
+ { "edt-ft5306", 0, },
+ { "edt-ft5406", 0, },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(i2c, edt_ft5x06_ts_id);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] input: edt-ft5x06, Add i2c device ids
2015-02-20 15:56 [PATCH] input: edt-ft5x06, Add i2c device ids Markus Pargmann
@ 2015-02-20 18:32 ` Dmitry Torokhov
2015-02-23 22:06 ` Markus Pargmann
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2015-02-20 18:32 UTC (permalink / raw)
To: Markus Pargmann; +Cc: Lothar Waßmann, linux-input, kernel
Hi Markus,
On Fri, Feb 20, 2015 at 04:56:25PM +0100, Markus Pargmann wrote:
> These ids are necessary to use edt-ft5x06 as a kernel module. Otherwise
> it is not loaded automatically in userspace because the ids do not match.
>
We already have all module aliases needed, please fix i2c to generate modalias
for devices described in OF properly.
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
> drivers/input/touchscreen/edt-ft5x06.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> index d4c24fb7704f..63ad6d545bbe 100644
> --- a/drivers/input/touchscreen/edt-ft5x06.c
> +++ b/drivers/input/touchscreen/edt-ft5x06.c
> @@ -1119,6 +1119,9 @@ static SIMPLE_DEV_PM_OPS(edt_ft5x06_ts_pm_ops,
>
> static const struct i2c_device_id edt_ft5x06_ts_id[] = {
> { "edt-ft5x06", 0, },
> + { "edt-ft5206", 0, },
> + { "edt-ft5306", 0, },
> + { "edt-ft5406", 0, },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(i2c, edt_ft5x06_ts_id);
> --
> 2.1.4
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] input: edt-ft5x06, Add i2c device ids
2015-02-20 18:32 ` Dmitry Torokhov
@ 2015-02-23 22:06 ` Markus Pargmann
0 siblings, 0 replies; 3+ messages in thread
From: Markus Pargmann @ 2015-02-23 22:06 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Lothar Waßmann, linux-input, kernel
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
Hi Dmitry,
On Fri, Feb 20, 2015 at 10:32:50AM -0800, Dmitry Torokhov wrote:
> Hi Markus,
>
> On Fri, Feb 20, 2015 at 04:56:25PM +0100, Markus Pargmann wrote:
> > These ids are necessary to use edt-ft5x06 as a kernel module. Otherwise
> > it is not loaded automatically in userspace because the ids do not match.
> >
>
> We already have all module aliases needed, please fix i2c to generate modalias
> for devices described in OF properly.
Yes, that's probably the better way to fix it. I will have a look into this.
Thanks,
Markus
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-23 22:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-20 15:56 [PATCH] input: edt-ft5x06, Add i2c device ids Markus Pargmann
2015-02-20 18:32 ` Dmitry Torokhov
2015-02-23 22:06 ` Markus Pargmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.