All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bond: changed port_id type to uint8_t to prevent data loss.
@ 2015-02-20 16:11 Maciej Gajdzica
  0 siblings, 0 replies; only message in thread
From: Maciej Gajdzica @ 2015-02-20 16:11 UTC (permalink / raw)
  To: dev-VfR2kkLFssw

In some places port_id is declared as int, which causes data loss when
using functions expecting port_id as uint8_t. Issue found with static
code analysis tool.

Signed-off-by: Maciej Gajdzica <maciejx.t.gajdzica-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 lib/librte_pmd_bond/rte_eth_bond_pmd.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c b/lib/librte_pmd_bond/rte_eth_bond_pmd.c
index a8df699..3ddba25 100644
--- a/lib/librte_pmd_bond/rte_eth_bond_pmd.c
+++ b/lib/librte_pmd_bond/rte_eth_bond_pmd.c
@@ -417,7 +417,7 @@ bandwidth_cmp(const void *a, const void *b)
 }
 
 static void
-bandwidth_left(int port_id, uint64_t load, uint8_t update_idx,
+bandwidth_left(uint8_t port_id, uint64_t load, uint8_t update_idx,
 		struct bwg_slave *bwg_slave)
 {
 	struct rte_eth_link link_status;
@@ -1681,7 +1681,8 @@ bond_ethdev_configure(struct rte_eth_dev *dev)
 	char *name = dev->data->name;
 	struct bond_dev_private *internals = dev->data->dev_private;
 	struct rte_kvargs *kvlist = internals->kvlist;
-	int arg_count, port_id = dev - rte_eth_devices;
+	int arg_count;
+	uint8_t port_id = dev - rte_eth_devices;
 
 	/*
 	 * if no kvlist, it means that this bonded device has been created
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-02-20 16:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-20 16:11 [PATCH] bond: changed port_id type to uint8_t to prevent data loss Maciej Gajdzica

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.