* [PATCH 0/2] Cleanup and fix touch_down implementation
@ 2015-02-20 22:25 Ping Cheng
2015-02-27 7:38 ` Jiri Kosina
2015-03-02 23:28 ` Jiri Kosina
0 siblings, 2 replies; 6+ messages in thread
From: Ping Cheng @ 2015-02-20 22:25 UTC (permalink / raw)
To: jkosina; +Cc: linux-input, Ping Cheng
Hi Jiri,
This set is based on your for-3.20/upstream-fixes branch.
If pen comes in proximity while touch is down, we force touch up
before sending pen events. This idea has been implemented for
Tablet PCs. But other tablets that support both pen and touch are
not fully considered.
Ping Cheng (2):
HID: wacom: do not send pen events before touch is up/forced out
HID: wacom: rely on actual touch down count to decide touch_down
drivers/hid/wacom_wac.c | 81 ++++++++++++++++++++++++++++++-------------------
1 file changed, 49 insertions(+), 32 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Cleanup and fix touch_down implementation
2015-02-20 22:25 [PATCH 0/2] Cleanup and fix touch_down implementation Ping Cheng
@ 2015-02-27 7:38 ` Jiri Kosina
2015-02-27 17:41 ` Ping Cheng
2015-03-02 23:28 ` Jiri Kosina
1 sibling, 1 reply; 6+ messages in thread
From: Jiri Kosina @ 2015-02-27 7:38 UTC (permalink / raw)
To: Ping Cheng; +Cc: linux-input, Ping Cheng
On Fri, 20 Feb 2015, Ping Cheng wrote:
> Hi Jiri,
>
> This set is based on your for-3.20/upstream-fixes branch.
>
> If pen comes in proximity while touch is down, we force touch up
> before sending pen events. This idea has been implemented for
> Tablet PCs. But other tablets that support both pen and touch are
> not fully considered.
>
> Ping Cheng (2):
> HID: wacom: do not send pen events before touch is up/forced out
> HID: wacom: rely on actual touch down count to decide touch_down
Ping, looking at the code, I think this both should go into 4.0 still
(i.e. not postponed for the next merge window), as it's purely fixes.
Could you please confirm that for me?
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Cleanup and fix touch_down implementation
2015-02-27 7:38 ` Jiri Kosina
@ 2015-02-27 17:41 ` Ping Cheng
2015-02-27 20:18 ` Jiri Kosina
0 siblings, 1 reply; 6+ messages in thread
From: Ping Cheng @ 2015-02-27 17:41 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-input
On Thu, Feb 26, 2015 at 11:38 PM, Jiri Kosina <jkosina@suse.cz> wrote:
> On Fri, 20 Feb 2015, Ping Cheng wrote:
>
>> Hi Jiri,
>>
>> This set is based on your for-3.20/upstream-fixes branch.
>>
>> If pen comes in proximity while touch is down, we force touch up
>> before sending pen events. This idea has been implemented for
>> Tablet PCs. But other tablets that support both pen and touch are
>> not fully considered.
>>
>> Ping Cheng (2):
>> HID: wacom: do not send pen events before touch is up/forced out
>> HID: wacom: rely on actual touch down count to decide touch_down
>
> Ping, looking at the code, I think this both should go into 4.0 still
> (i.e. not postponed for the next merge window), as it's purely fixes.
>
> Could you please confirm that for me?
Sure, they can go to 4.0.
Thank you.
Ping
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Cleanup and fix touch_down implementation
2015-02-27 17:41 ` Ping Cheng
@ 2015-02-27 20:18 ` Jiri Kosina
2015-02-27 20:32 ` Ping Cheng
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Kosina @ 2015-02-27 20:18 UTC (permalink / raw)
To: Ping Cheng; +Cc: linux-input
On Fri, 27 Feb 2015, Ping Cheng wrote:
> >> before sending pen events. This idea has been implemented for
> >> Tablet PCs. But other tablets that support both pen and touch are
> >> not fully considered.
> >>
> >> Ping Cheng (2):
> >> HID: wacom: do not send pen events before touch is up/forced out
> >> HID: wacom: rely on actual touch down count to decide touch_down
> >
> > Ping, looking at the code, I think this both should go into 4.0 still
> > (i.e. not postponed for the next merge window), as it's purely fixes.
> >
> > Could you please confirm that for me?
>
> Sure, they can go to 4.0.
The question rather is "do they absolutely have to?" :)
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Cleanup and fix touch_down implementation
2015-02-27 20:18 ` Jiri Kosina
@ 2015-02-27 20:32 ` Ping Cheng
0 siblings, 0 replies; 6+ messages in thread
From: Ping Cheng @ 2015-02-27 20:32 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-input
On Fri, Feb 27, 2015 at 12:18 PM, Jiri Kosina <jkosina@suse.cz> wrote:
> On Fri, 27 Feb 2015, Ping Cheng wrote:
>
>> >> before sending pen events. This idea has been implemented for
>> >> Tablet PCs. But other tablets that support both pen and touch are
>> >> not fully considered.
>> >>
>> >> Ping Cheng (2):
>> >> HID: wacom: do not send pen events before touch is up/forced out
>> >> HID: wacom: rely on actual touch down count to decide touch_down
>> >
>> > Ping, looking at the code, I think this both should go into 4.0 still
>> > (i.e. not postponed for the next merge window), as it's purely fixes.
>> >
>> > Could you please confirm that for me?
>>
>> Sure, they can go to 4.0.
>
> The question rather is "do they absolutely have to?" :)
I patched them under for-3.20/upstream-fixes in hope of merging them
sooner. Sounds like getting in 4.0 is quicker.
Anyway, the sooner we can get them merged upstream, the better, since
they are bug fixes.
Cheers,
PIng
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Cleanup and fix touch_down implementation
2015-02-20 22:25 [PATCH 0/2] Cleanup and fix touch_down implementation Ping Cheng
2015-02-27 7:38 ` Jiri Kosina
@ 2015-03-02 23:28 ` Jiri Kosina
1 sibling, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2015-03-02 23:28 UTC (permalink / raw)
To: Ping Cheng; +Cc: linux-input, Ping Cheng
On Fri, 20 Feb 2015, Ping Cheng wrote:
> Hi Jiri,
>
> This set is based on your for-3.20/upstream-fixes branch.
>
> If pen comes in proximity while touch is down, we force touch up
> before sending pen events. This idea has been implemented for
> Tablet PCs. But other tablets that support both pen and touch are
> not fully considered.
>
> Ping Cheng (2):
> HID: wacom: do not send pen events before touch is up/forced out
> HID: wacom: rely on actual touch down count to decide touch_down
>
> drivers/hid/wacom_wac.c | 81 ++++++++++++++++++++++++++++++-------------------
> 1 file changed, 49 insertions(+), 32 deletions(-)
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-02 23:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-20 22:25 [PATCH 0/2] Cleanup and fix touch_down implementation Ping Cheng
2015-02-27 7:38 ` Jiri Kosina
2015-02-27 17:41 ` Ping Cheng
2015-02-27 20:18 ` Jiri Kosina
2015-02-27 20:32 ` Ping Cheng
2015-03-02 23:28 ` Jiri Kosina
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.