* [PATCH] Staging: rtl8192u: Convert comment from C99 to C89 style.
@ 2015-02-21 9:21 Ksenija Stanojevic
2015-02-26 21:23 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Ksenija Stanojevic @ 2015-02-21 9:21 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Ksenija Stanojevic, Ksenija Stanojevic
Kernel style for comments is C89 style. Issue found by checkpatch.pl.
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@googlegroups.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
index 447af93..a826d88 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
@@ -5,13 +5,13 @@
* Portions Copyright (C) 2004, Intel Corporation <jketreno@linux.intel.com>
*
* This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
+i * it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation. See README and COPYING for
* more details.
*
*/
-//#include <linux/config.h>
+/* #include <linux/config.h> */
#include <linux/module.h>
#include <linux/init.h>
#include <linux/slab.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: Convert comment from C99 to C89 style.
2015-02-21 9:21 [PATCH] Staging: rtl8192u: Convert comment from C99 to C89 style Ksenija Stanojevic
@ 2015-02-26 21:23 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-02-26 21:23 UTC (permalink / raw)
To: Ksenija Stanojevic; +Cc: outreachy-kernel, Ksenija Stanojevic
On Sat, Feb 21, 2015 at 10:21:01AM +0100, Ksenija Stanojevic wrote:
> Kernel style for comments is C89 style. Issue found by checkpatch.pl.
>
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@googlegroups.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> index 447af93..a826d88 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> @@ -5,13 +5,13 @@
> * Portions Copyright (C) 2004, Intel Corporation <jketreno@linux.intel.com>
> *
> * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> +i * it under the terms of the GNU General Public License version 2 as
I don't think this line is correct :(
And nice to see you are using vim :)
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-26 21:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-21 9:21 [PATCH] Staging: rtl8192u: Convert comment from C99 to C89 style Ksenija Stanojevic
2015-02-26 21:23 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.